summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorcheneym2 <acheney@nvidia.com>2024-11-05 13:39:14 -0500
committerGitHub <noreply@github.com>2024-11-05 13:39:14 -0500
commitfc7de92000aa378da32c830ad0999eb46729ad43 (patch)
tree990c6ed4e657c818cb2d454ab6389a43f3106222 /tools
parentb118451e301d734e3e783b3acdf871f3f6ea851c (diff)
Update slang-rhi and fix error handling (#5485)
Update slang-rhi to pick up a fix in webgpu compilation error handling. In doRenderComparisonTestRun(), only return TestResult::Pass if the shader is ran actually compiled. A similar check is in place elsewhere in slang-test-main, but was missed in doRenderComparisonTestRun(). Add two tests to the github CI skiplist, and use the skiplist in one additional CI config that was running without it. Closes 5291
Diffstat (limited to 'tools')
-rw-r--r--tools/slang-test/slang-test-main.cpp5
1 files changed, 5 insertions, 0 deletions
diff --git a/tools/slang-test/slang-test-main.cpp b/tools/slang-test/slang-test-main.cpp
index fccba8fd8..bdc7a082b 100644
--- a/tools/slang-test/slang-test-main.cpp
+++ b/tools/slang-test/slang-test-main.cpp
@@ -3583,6 +3583,11 @@ TestResult doRenderComparisonTestRun(
*outOutput = output;
+ // Always fail if the compilation produced a failure.
+ if (exeRes.resultCode != 0)
+ {
+ return TestResult::Fail;
+ }
return TestResult::Pass;
}