From fc7de92000aa378da32c830ad0999eb46729ad43 Mon Sep 17 00:00:00 2001 From: cheneym2 Date: Tue, 5 Nov 2024 13:39:14 -0500 Subject: Update slang-rhi and fix error handling (#5485) Update slang-rhi to pick up a fix in webgpu compilation error handling. In doRenderComparisonTestRun(), only return TestResult::Pass if the shader is ran actually compiled. A similar check is in place elsewhere in slang-test-main, but was missed in doRenderComparisonTestRun(). Add two tests to the github CI skiplist, and use the skiplist in one additional CI config that was running without it. Closes 5291 --- tools/slang-test/slang-test-main.cpp | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'tools') diff --git a/tools/slang-test/slang-test-main.cpp b/tools/slang-test/slang-test-main.cpp index fccba8fd8..bdc7a082b 100644 --- a/tools/slang-test/slang-test-main.cpp +++ b/tools/slang-test/slang-test-main.cpp @@ -3583,6 +3583,11 @@ TestResult doRenderComparisonTestRun( *outOutput = output; + // Always fail if the compilation produced a failure. + if (exeRes.resultCode != 0) + { + return TestResult::Fail; + } return TestResult::Pass; } -- cgit v1.2.3