diff options
| author | Tim Foley <tfoleyNV@users.noreply.github.com> | 2020-02-19 13:25:13 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-02-19 13:25:13 -0800 |
| commit | 9603fde866eacdde6c7cb93b04138b637a505079 (patch) | |
| tree | f7bb19d0ecfcbe5782f9603311a436cb0022a43a /tools/render-test/shader-input-layout.cpp | |
| parent | 46a1b5f58a528bf1cd2fa2907234a9090cd7ba10 (diff) | |
Fix a reference-counting bug in one of the session creation routines. (#1230)
This is pretty straightforward, because we were calling `Session::init` (which can retain/release the session) on a `Session*` (no reference held).
The catch is that our current tests use the older form of the Slang API, while Falcor relies on the newer API, and so the recent change to our reference-counting logic introduced a regression that we didn't detect in testing.
This change just fixes the direct issue but doesn't address the gap in testing. A better long-term fix would be to fully define our "1.0" API, shift our testing to it, and layer the old API on top of it (to try and avoid regressions for client code).
Diffstat (limited to 'tools/render-test/shader-input-layout.cpp')
0 files changed, 0 insertions, 0 deletions