diff options
| author | Tim Foley <tfoleyNV@users.noreply.github.com> | 2018-02-03 07:30:54 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-02-03 07:30:54 -0800 |
| commit | 662f43fff6721c6cd013a8f1b2639c2e29fe6be3 (patch) | |
| tree | 9e57c4a9f1a922418fbae2390ee1998984a6ea26 /tests/hlsl/simple | |
| parent | 58475a8aa42284722a3763aa3bde49f2fa40366e (diff) | |
Remove non-IR codegen paths (#398)
The basic change is simple: remove support for all code generation paths other than the IR.
There is a lot of vestigial code left, but the main logic in `ast-legalize.*` is gone.
Doing this breaks a *lot* of tests, for various reasons:
- We can no longer guarantee exactly matching DXBC or SPIR-V output after things pass through out IR
- Many builtins don't have matching versions defined for GLSL output via IR (even when they had versions defined via the earlier approach that worked with the AST)
- A lot of code creates intermediate values of opaque types in the IR, which turn into opaque-type temporaries that aren't allowed (this breaks many GLSL tests, but also some HLSL)
I implemented some small fixes for issues that I could get working in the time I had, but most of the above are larger than made sense to fix in this commit.
For now I'm disabling the tests that cause problems, but we will need to make a concerted effort to get things working on this new substrate if we are going to make good on our goals.
Diffstat (limited to 'tests/hlsl/simple')
| -rw-r--r-- | tests/hlsl/simple/allow-uav-conditional.hlsl | 6 | ||||
| -rw-r--r-- | tests/hlsl/simple/compute-numthreads.hlsl | 2 | ||||
| -rw-r--r-- | tests/hlsl/simple/implicit_conversion.hlsl | 2 | ||||
| -rw-r--r-- | tests/hlsl/simple/literal-typing.hlsl | 2 |
4 files changed, 7 insertions, 5 deletions
diff --git a/tests/hlsl/simple/allow-uav-conditional.hlsl b/tests/hlsl/simple/allow-uav-conditional.hlsl index 3da239860..1526244a2 100644 --- a/tests/hlsl/simple/allow-uav-conditional.hlsl +++ b/tests/hlsl/simple/allow-uav-conditional.hlsl @@ -1,4 +1,4 @@ -//TEST:COMPARE_HLSL: -profile cs_5_0 -target dxbc-assembly +//TEST:COMPARE_HLSL:-no-mangle -profile cs_5_0 -target dxbc-assembly // Check output for `[allow_uav_conditional]` @@ -11,8 +11,10 @@ void main( uint index = tid; [allow_uav_condition] - while(gBuffer[index] != 0) + for(;;) { + if(gBuffer[index] == 0) + break; index = gBuffer[index]; gBuffer[index]--; } diff --git a/tests/hlsl/simple/compute-numthreads.hlsl b/tests/hlsl/simple/compute-numthreads.hlsl index 3843c401f..ba18a8d16 100644 --- a/tests/hlsl/simple/compute-numthreads.hlsl +++ b/tests/hlsl/simple/compute-numthreads.hlsl @@ -1,4 +1,4 @@ -//TEST:COMPARE_HLSL: -no-checking -target dxbc-assembly -profile cs_5_0 -entry main +//TEST:COMPARE_HLSL:-no-mangle -target dxbc-assembly -profile cs_5_0 -entry main // Confirm that we properly pass along the `numthreads` attribute on an entry point. diff --git a/tests/hlsl/simple/implicit_conversion.hlsl b/tests/hlsl/simple/implicit_conversion.hlsl index 8db62fa9c..d46661341 100644 --- a/tests/hlsl/simple/implicit_conversion.hlsl +++ b/tests/hlsl/simple/implicit_conversion.hlsl @@ -1,4 +1,4 @@ -//TEST:COMPARE_HLSL: -target dxbc-assembly -profile cs_5_0 -entry main +//TEST_DISABLED:COMPARE_HLSL:-no-mangle -target dxbc-assembly -profile cs_5_0 -entry main // Test various cases of implicit type conversion and preference // for overload resolution. diff --git a/tests/hlsl/simple/literal-typing.hlsl b/tests/hlsl/simple/literal-typing.hlsl index 71acb0d92..359b875f9 100644 --- a/tests/hlsl/simple/literal-typing.hlsl +++ b/tests/hlsl/simple/literal-typing.hlsl @@ -1,4 +1,4 @@ -//TEST:COMPARE_HLSL: -target dxbc-assembly -profile cs_5_0 -entry main +//TEST:COMPARE_HLSL:-no-mangle -target dxbc-assembly -profile cs_5_0 -entry main // Confirm that we get the typing of literal suffixes correct |
