[CBP] Pointer frontend changes + groupshared pointer support (#7848)

Resolves #7628
Resolves: #8197

Primary Goals:
1. Add `Access` to pointer
2. AddressSpace::GroupShared support for pointers (SPIR-V)
3. Add `__getAddress()` to replace `&`
* `&` is not updated to `require(cpu)` since slangpy uses `&`. This
means we must: (1) merge PR; (2) replace `&` with `__getAddress()`; (3)
add `require(cpu)` to `&`

Changes:
* Added to `Ptr` the `Access` generic argument & logic (for
`Access::Read`).
* Moved the generic argument `AddressSpace` from `Ptr` to the end of the
type.
* Added pointer casting support between any `Ptr` as long as the
`AddressSpace` is the same
* Disallow globallycoherent T* and coherent T*
* Disallow const T*, T const*, and const T*
* Fixed .natvis display of `ConstantValue` `ValOperandNode`
* Support generic resolution of type-casted integers
* Added `VariablePointer` emitting for spirv + other minor logic needed
for groupshared pointers

Breaking Changes:
* Anyone using the `AddressSpace` of `Ptr` will now have to account for
the `Access` argument
* we disallow various syntax paired with `Ptr` and `T*`

---------

Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com>

1 files changed, 11 insertions, 5 deletions

diff --git a/tests/diagnostics/invalid-constant-pointer-taking.slang b/tests/diagnostics/invalid-constant-pointer-taking.slang
index 349f8cc25..658a84b1b 100644
--- a/tests/diagnostics/invalid-constant-pointer-taking.slang
+++ b/tests/diagnostics/invalid-constant-pointer-taking.slang
@@ -1,4 +1,4 @@
-//DIAGNOSTIC_TEST:SIMPLE(filecheck=CHECK): -stage compute -entry computeMain -target spirv
+//TEST:SIMPLE(filecheck=CHECK): -stage compute -entry computeMain -target spirv
 
 RWStructuredBuffer<float> mutable_float_buffer;
 RWStructuredBuffer<uint> mutable_uint_buffer;
@@ -6,18 +6,24 @@ RWStructuredBuffer<uint> mutable_uint_buffer;
 StructuredBuffer<float> constant_float_buffer;
 StructuredBuffer<uint> constant_uint_buffer;
 
+// We do not allow taking a pointer from a StructuredBuffer/RWStructuredBuffer.
 [shader("compute")]
 [numthreads(1,1,1)]
 void computeMain(uint3 threadId : SV_DispatchThreadID)
 {
-    float* mutablePtr = &mutable_float_buffer[threadId.x];
+    float* mutablePtr1 = &mutable_float_buffer[threadId.x];
+
+    // CHECK: ([[# @LINE+1]]): error 31160
+    float* mutablePtr2 = __getAddress(mutable_float_buffer[threadId.x]);
 
     InterlockedAdd(mutable_uint_buffer[threadId.x], 1);
 
     // Constant pointers arent a thing in slang
-    // CHECK: error 30078:
-    float* ptr = &constant_float_buffer[threadId.x];
+    // CHECK: ([[# @LINE+1]]): error 30079:
+    float* ptr1 = &constant_float_buffer[threadId.x];
 
+    // CHECK: ([[# @LINE+1]]): error 31160
+    float* ptr2 = __getAddress(constant_float_buffer[threadId.x]);
 
     InterlockedAdd(constant_uint_buffer[0], 1);
-}
\ No newline at end of file
+}