summaryrefslogtreecommitdiffstats
path: root/tests/bugs
diff options
context:
space:
mode:
authorArielG-NV <159081215+ArielG-NV@users.noreply.github.com>2025-08-29 15:52:34 -0700
committerGitHub <noreply@github.com>2025-08-29 22:52:34 +0000
commit7758625d3fea67e55e98e7e4103d56c9918365be (patch)
tree2ed40aeb4d16262866e5540dad1a519951b5f772 /tests/bugs
parent450ef7934c1adfdf4a3a3c72967de3c5798a020d (diff)
[CBP] Pointer frontend changes + groupshared pointer support (#7848)
Resolves #7628 Resolves: #8197 Primary Goals: 1. Add `Access` to pointer 2. AddressSpace::GroupShared support for pointers (SPIR-V) 3. Add `__getAddress()` to replace `&` * `&` is not updated to `require(cpu)` since slangpy uses `&`. This means we must: (1) merge PR; (2) replace `&` with `__getAddress()`; (3) add `require(cpu)` to `&` Changes: * Added to `Ptr` the `Access` generic argument & logic (for `Access::Read`). * Moved the generic argument `AddressSpace` from `Ptr` to the end of the type. * Added pointer casting support between any `Ptr` as long as the `AddressSpace` is the same * Disallow globallycoherent T* and coherent T* * Disallow const T*, T const*, and const T* * Fixed .natvis display of `ConstantValue` `ValOperandNode` * Support generic resolution of type-casted integers * Added `VariablePointer` emitting for spirv + other minor logic needed for groupshared pointers Breaking Changes: * Anyone using the `AddressSpace` of `Ptr` will now have to account for the `Access` argument * we disallow various syntax paired with `Ptr` and `T*` --------- Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com>
Diffstat (limited to 'tests/bugs')
-rw-r--r--tests/bugs/gh-3601.slang8
1 files changed, 4 insertions, 4 deletions
diff --git a/tests/bugs/gh-3601.slang b/tests/bugs/gh-3601.slang
index 5d545262b..65245f971 100644
--- a/tests/bugs/gh-3601.slang
+++ b/tests/bugs/gh-3601.slang
@@ -4,7 +4,7 @@ struct TestStruct
uint index;
};
-[[vk::binding(2, 0)]] StructuredBuffer<uint64_t> test;
+[[vk::binding(2, 0)]] uniform uint64_t* test;
struct PP
{
@@ -28,15 +28,15 @@ int* funcThatReturnsPointer(PP* p)
// CHECK: OpEntryPoint
-[[vk::binding(0, 0)]] StructuredBuffer<Data> buffer;
+[[vk::binding(0, 0)]] uniform Data* buffer;
[[vk::binding(1, 0)]] RWStructuredBuffer<int> output;
[shader("compute")]
[numthreads(8, 8, 1)]
void main(int id : SV_DispatchThreadID)
{
- TestStruct * ptr = (TestStruct *)(test[0]);
+ TestStruct* ptr = (TestStruct*)(test[0]);
output[0] = buffer[ptr.index].pNext.data;
- let pData = &(buffer[0].pNext.data);
+ let pData = __getAddress(buffer[0].pNext.data);
// CHECK: OpPtrAccessChain
int* pData1 = pData + 1;
*pData1 = 3;