summaryrefslogtreecommitdiffstats
path: root/source
diff options
context:
space:
mode:
authorTim Foley <tfoley@nvidia.com>2017-07-18 15:21:04 -0700
committerTim Foley <tfoley@nvidia.com>2017-07-18 15:21:04 -0700
commit4d6da3a1177f27807d47ca46ec25ed96eda4642c (patch)
tree2cc4e5645e56df929d1a8eee1815f26ab4a7c3e9 /source
parentb2b46a9ced9dad18b41df0361cb91b0afb1ea710 (diff)
Swizzle result of buffer load based on element type
When lowering `buf[i]` to `texelFetch(..., i)` we need to deal with the case where the type of `b` might be `Buffer<float>` in which case we want to add a `.x` swizzle to the end of the fetch.
Diffstat (limited to 'source')
-rw-r--r--source/slang/emit.cpp46
-rw-r--r--source/slang/slang-stdlib.cpp4
2 files changed, 48 insertions, 2 deletions
diff --git a/source/slang/emit.cpp b/source/slang/emit.cpp
index 76dc9c75f..8660b5f93 100644
--- a/source/slang/emit.cpp
+++ b/source/slang/emit.cpp
@@ -1943,6 +1943,52 @@ struct EmitVisitor
}
break;
+ case 'z':
+ // If we are calling a D3D texturing operation in the form t.Foo(s, ...),
+ // where `t` is a `Texture*<T>`, then this is the step where we try to
+ // properly swizzle the output of the equivalent GLSL call into the right
+ // shape.
+ assert(argCount > 0);
+ if (auto memberExpr = callExpr->FunctionExpr.As<MemberExpressionSyntaxNode>())
+ {
+ auto base = memberExpr->BaseExpression;
+ if (auto baseTextureType = base->Type->As<TextureType>())
+ {
+ auto elementType = baseTextureType->elementType;
+ if (auto basicType = elementType->As<BasicExpressionType>())
+ {
+ // A scalar result is expected
+ Emit(".x");
+ }
+ else if (auto vectorType = elementType->As<VectorExpressionType>())
+ {
+ // A vector result is expected
+ auto elementCount = GetIntVal(vectorType->elementCount);
+
+ if (elementCount < 4)
+ {
+ char const* swiz[] = { "", ".x", ".xy", ".xyz", "" };
+ Emit(swiz[elementCount]);
+ }
+ }
+ else
+ {
+ // What other cases are possible?
+ }
+ }
+ else
+ {
+ assert(!"unexpected");
+ }
+
+ }
+ else
+ {
+ assert(!"unexpected");
+ }
+ break;
+
+
default:
assert(!"unexpected");
break;
diff --git a/source/slang/slang-stdlib.cpp b/source/slang/slang-stdlib.cpp
index 8aa0d0e4c..a62db693c 100644
--- a/source/slang/slang-stdlib.cpp
+++ b/source/slang/slang-stdlib.cpp
@@ -2024,12 +2024,12 @@ namespace Slang
sb << "__intrinsic void GetDimensions(out uint dim);\n";
- sb << "__intrinsic(glsl, \"texelFetch($P, $0)\")\n";
+ sb << "__intrinsic(glsl, \"texelFetch($P, $0)$z\")\n";
sb << "__intrinsic T Load(int location);\n";
sb << "__intrinsic T Load(int location, out uint status);\n";
- sb << "__intrinsic(glsl, \"texelFetch($P, int($0))\")\n";
+ sb << "__intrinsic(glsl, \"texelFetch($P, int($0))$z\")\n";
sb << "__intrinsic __subscript(uint index) -> T";
if (kBaseBufferAccessLevels[aa].access != SLANG_RESOURCE_ACCESS_READ)