diff options
| author | Jay Kwak <82421531+jkwak-work@users.noreply.github.com> | 2024-04-24 08:06:50 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-04-24 08:06:50 -0700 |
| commit | 211b2ffc20d7798cab0b8483ccc3ec2b7ade49ab (patch) | |
| tree | 5e626aa8a41146d3a2f63c1d3593a8ee0a4863fe /source | |
| parent | 97631e9a8aae44315a96d57fa8bca75b3799f9cb (diff) | |
Silent compiler warning about missing override keywords (#4018)
Adding "override" keywords for member functions whereever they need.
The compiler warning was visible on CI build but not visible on local
visual studio build.
Diffstat (limited to 'source')
| -rw-r--r-- | source/compiler-core/slang-metal-compiler.cpp | 2 | ||||
| -rw-r--r-- | source/slang/slang-check-decl.cpp | 2 | ||||
| -rwxr-xr-x | source/slang/slang-compiler.h | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/source/compiler-core/slang-metal-compiler.cpp b/source/compiler-core/slang-metal-compiler.cpp index 04bcf0f57..d3bf92bf3 100644 --- a/source/compiler-core/slang-metal-compiler.cpp +++ b/source/compiler-core/slang-metal-compiler.cpp @@ -26,7 +26,7 @@ namespace Slang virtual SLANG_NO_THROW bool SLANG_MCALL isFileBased() override { return true; } - virtual SLANG_NO_THROW SlangResult SLANG_MCALL compile(const CompileOptions& options, IArtifact** outArtifact) + virtual SLANG_NO_THROW SlangResult SLANG_MCALL compile(const CompileOptions& options, IArtifact** outArtifact) override { // All compile requests should be routed directly to the inner compiler. return cppCompiler->compile(options, outArtifact); diff --git a/source/slang/slang-check-decl.cpp b/source/slang/slang-check-decl.cpp index cb68dced9..0f9da12c4 100644 --- a/source/slang/slang-check-decl.cpp +++ b/source/slang/slang-check-decl.cpp @@ -9847,7 +9847,7 @@ namespace Slang loc = Base::sourceLocStack.getLast(); handleReferenceFunc(decl, decl->inferredCapabilityRequirements, loc); } - virtual void processDeclModifiers(Decl* decl) + virtual void processDeclModifiers(Decl* decl) override { if (decl) handleReferenceFunc(decl, decl->inferredCapabilityRequirements, decl->loc); diff --git a/source/slang/slang-compiler.h b/source/slang/slang-compiler.h index fc4bc355b..105db5789 100755 --- a/source/slang/slang-compiler.h +++ b/source/slang/slang-compiler.h @@ -1346,7 +1346,7 @@ namespace Slang char const* name, SlangStage stage, slang::IEntryPoint** outEntryPoint, - ISlangBlob** outDiagnostics) + ISlangBlob** outDiagnostics) override { ComPtr<slang::IEntryPoint> entryPoint(findAndCheckEntryPoint(UnownedStringSlice(name), stage, outDiagnostics)); if ((!entryPoint)) |
