From 211b2ffc20d7798cab0b8483ccc3ec2b7ade49ab Mon Sep 17 00:00:00 2001 From: Jay Kwak <82421531+jkwak-work@users.noreply.github.com> Date: Wed, 24 Apr 2024 08:06:50 -0700 Subject: Silent compiler warning about missing override keywords (#4018) Adding "override" keywords for member functions whereever they need. The compiler warning was visible on CI build but not visible on local visual studio build. --- source/compiler-core/slang-metal-compiler.cpp | 2 +- source/slang/slang-check-decl.cpp | 2 +- source/slang/slang-compiler.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) (limited to 'source') diff --git a/source/compiler-core/slang-metal-compiler.cpp b/source/compiler-core/slang-metal-compiler.cpp index 04bcf0f57..d3bf92bf3 100644 --- a/source/compiler-core/slang-metal-compiler.cpp +++ b/source/compiler-core/slang-metal-compiler.cpp @@ -26,7 +26,7 @@ namespace Slang virtual SLANG_NO_THROW bool SLANG_MCALL isFileBased() override { return true; } - virtual SLANG_NO_THROW SlangResult SLANG_MCALL compile(const CompileOptions& options, IArtifact** outArtifact) + virtual SLANG_NO_THROW SlangResult SLANG_MCALL compile(const CompileOptions& options, IArtifact** outArtifact) override { // All compile requests should be routed directly to the inner compiler. return cppCompiler->compile(options, outArtifact); diff --git a/source/slang/slang-check-decl.cpp b/source/slang/slang-check-decl.cpp index cb68dced9..0f9da12c4 100644 --- a/source/slang/slang-check-decl.cpp +++ b/source/slang/slang-check-decl.cpp @@ -9847,7 +9847,7 @@ namespace Slang loc = Base::sourceLocStack.getLast(); handleReferenceFunc(decl, decl->inferredCapabilityRequirements, loc); } - virtual void processDeclModifiers(Decl* decl) + virtual void processDeclModifiers(Decl* decl) override { if (decl) handleReferenceFunc(decl, decl->inferredCapabilityRequirements, decl->loc); diff --git a/source/slang/slang-compiler.h b/source/slang/slang-compiler.h index fc4bc355b..105db5789 100755 --- a/source/slang/slang-compiler.h +++ b/source/slang/slang-compiler.h @@ -1346,7 +1346,7 @@ namespace Slang char const* name, SlangStage stage, slang::IEntryPoint** outEntryPoint, - ISlangBlob** outDiagnostics) + ISlangBlob** outDiagnostics) override { ComPtr entryPoint(findAndCheckEntryPoint(UnownedStringSlice(name), stage, outDiagnostics)); if ((!entryPoint)) -- cgit v1.2.3