diff options
| author | Yong He <yonghe@outlook.com> | 2018-02-19 19:53:45 -0500 |
|---|---|---|
| committer | Yong He <yonghe@outlook.com> | 2018-02-19 19:53:45 -0500 |
| commit | 5de62bbe4dddc64895ddb17c4eb3572c3c9be248 (patch) | |
| tree | d12fd2a9bad9a632430e1262de8f7e7da388bffa /source/slang/syntax-base-defs.h | |
| parent | ff8adf7b45121aada0b4f4403b0f45a6e2dfe475 (diff) | |
more to fixing memory leaks
1. reorder destruction order of several key classes to avoid using deleted IR objects when destroying Types
2. remove Session::canonicalTypes and make each Type own a RefPtr to the canonicalType, to allow types to be destroyed along with each IRModule it belongs to.
Diffstat (limited to 'source/slang/syntax-base-defs.h')
| -rw-r--r-- | source/slang/syntax-base-defs.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/source/slang/syntax-base-defs.h b/source/slang/syntax-base-defs.h index 2eb130863..2c15f7215 100644 --- a/source/slang/syntax-base-defs.h +++ b/source/slang/syntax-base-defs.h @@ -119,7 +119,7 @@ public: protected: virtual bool EqualsImpl(Type * type) = 0; - virtual Type* CreateCanonicalType() = 0; + virtual RefPtr<Type> CreateCanonicalType() = 0; Type* canonicalType = nullptr; RefPtr<Type> canonicalTypeRefPtr; @@ -227,7 +227,7 @@ RAW( return rs; } typedef List<KeyValuePair<RefPtr<Type>, RefPtr<Val>>> WitnessTableLookupTable; -) + ) // The witness tables for each interface this actual type implements SYNTAX_FIELD(WitnessTableLookupTable, witnessTables) END_SYNTAX_CLASS() |