Make a warning if a [mutating] method is called on an in param. (#3184)

* Make a warning if a [mutating] method is passed as an in param.

* Kick CI.

---------

Co-authored-by: Yong He <yonghe@outlook.com>

1 files changed, 7 insertions, 1 deletions

diff --git a/source/slang/slang-check-overload.cpp b/source/slang/slang-check-overload.cpp
index 50da2d3eb..5e626705a 100644
--- a/source/slang/slang-check-overload.cpp
+++ b/source/slang/slang-check-overload.cpp
@@ -586,7 +586,13 @@ namespace Slang
                 {
                     if(auto paramDecl = isReferenceIntoFunctionInputParameter(context.baseExpr))
                     {
-                        getSink()->diagnose(context.loc, Diagnostics::mutatingMethodOnFunctionInputParameter,
+                        const bool isNonCopyable = isNonCopyableType(paramDecl->getType());
+
+                        const auto& diagnotic = isNonCopyable ?
+                            Diagnostics::mutatingMethodOnFunctionInputParameterError :
+                            Diagnostics::mutatingMethodOnFunctionInputParameterWarning;
+
+                        getSink()->diagnose(context.loc, diagnotic,
                             funcDeclRef.getName(),
                             paramDecl->getName());
                     }