diff options
| author | jsmall-nvidia <jsmall@nvidia.com> | 2023-09-06 19:32:06 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-09-06 16:32:06 -0700 |
| commit | 891a6cf376c6b2560231502614b37c332f44ddea (patch) | |
| tree | 556f95d0125fda05fcf9dbf18b956f21fc800451 /source | |
| parent | 20bd5e7440e3d28715bed449a336003ba02d7d0f (diff) | |
Make a warning if a [mutating] method is called on an in param. (#3184)
* Make a warning if a [mutating] method is passed as an in param.
* Kick CI.
---------
Co-authored-by: Yong He <yonghe@outlook.com>
Diffstat (limited to 'source')
| -rw-r--r-- | source/slang/slang-check-overload.cpp | 8 | ||||
| -rw-r--r-- | source/slang/slang-diagnostic-defs.h | 3 |
2 files changed, 9 insertions, 2 deletions
diff --git a/source/slang/slang-check-overload.cpp b/source/slang/slang-check-overload.cpp index 50da2d3eb..5e626705a 100644 --- a/source/slang/slang-check-overload.cpp +++ b/source/slang/slang-check-overload.cpp @@ -586,7 +586,13 @@ namespace Slang { if(auto paramDecl = isReferenceIntoFunctionInputParameter(context.baseExpr)) { - getSink()->diagnose(context.loc, Diagnostics::mutatingMethodOnFunctionInputParameter, + const bool isNonCopyable = isNonCopyableType(paramDecl->getType()); + + const auto& diagnotic = isNonCopyable ? + Diagnostics::mutatingMethodOnFunctionInputParameterError : + Diagnostics::mutatingMethodOnFunctionInputParameterWarning; + + getSink()->diagnose(context.loc, diagnotic, funcDeclRef.getName(), paramDecl->getName()); } diff --git a/source/slang/slang-diagnostic-defs.h b/source/slang/slang-diagnostic-defs.h index 76e96f2d5..5a28c8188 100644 --- a/source/slang/slang-diagnostic-defs.h +++ b/source/slang/slang-diagnostic-defs.h @@ -316,7 +316,8 @@ DIAGNOSTIC(30064, Note, implicitCastUsedAsLValue, "argument was implicitly cast DIAGNOSTIC(30065, Error, newCanOnlyBeUsedToInitializeAClass, "`new` can only be used to initialize a class") DIAGNOSTIC(30066, Error, classCanOnlyBeInitializedWithNew, "a class can only be initialized by a `new` clause") -DIAGNOSTIC(30067, Error, mutatingMethodOnFunctionInputParameter, "mutating method '$0' called on `in` parameter '$1'; changes will not be visible to caller. copy the parameter into a local variable if this behavior is intended") +DIAGNOSTIC(30067, Error, mutatingMethodOnFunctionInputParameterError, "mutating method '$0' called on `in` parameter '$1'; changes will not be visible to caller. copy the parameter into a local variable if this behavior is intended") +DIAGNOSTIC(30068, Warning, mutatingMethodOnFunctionInputParameterWarning, "mutating method '$0' called on `in` parameter '$1'; changes will not be visible to caller. copy the parameter into a local variable if this behavior is intended") DIAGNOSTIC(30100, Error, staticRefToNonStaticMember, "type '$0' cannot be used to refer to non-static member '$1'") |