String/List closer to conventions, and use Index type (#959)

* List made members m_
Tweaked types to closer match conventions.

* Use asserts for checking conditions on List.
Other small improvements.

* List<T>.Count() -> getSize()

* List<T>
Add -> add
First -> getFirst
Last -> getLast
RemoveLast -> removeLast
ReleaseBuffer -> detachBuffer
GetArrayView -> getArrayView

* List<T>::
AddRange -> addRange
Capacity -> getCapacity
Insert -> insert
InsertRange -> insertRange
AddRange -> addRange
RemoveRange -> removeRange
RemoveAt -> removeAt
Remove -> remove
Reverse -> reverse
FastRemove -> fastRemove
FastRemoveAt -> fastRemoveAt
Clear -> clear

* List<T>
FreeBuffer -> _deallocateBuffer
Free -> clearAndDeallocate
SwapWith -> swapWith

* List<T>
SetSize -> setSize
Reserve -> reserve
GrowToSize growToSize

* UnsafeShrinkToSize -> unsafeShrinkToSize
Compress -> compress
FindLast -> findLastIndex
FindLast -> findLastIndex
Simplify Contains

* List<T>
Removed m_allocator (wasn't used)
Swap -> swapElements
Sort -> sort
Contains -> contains
ForEach -> forEach
QuickSort -> quickSort
InsertionSort -> insertionSort
BinarySearch -> binarySearch

Max -> calcMax
Min -> calcMin

* Initializer::Initialize -> initialize
List<T>::
Allocate -> _allocate
Init -> _init
IndexOf -> indexOf

* * Put #include <assert.h> in common.h, and remove unneeded inclusions
* Small refactor of ArrayView - remove stride as not used

* getSize -> getCount
setSize -> setCount
unsafeShrinkToSize->unsafeShrinkToCount
growToSize -> growToCount
m_size -> m_count

* Some tidy up around Allocator.

* Use Index type on List.

* Refactor of IntSet.
First tentative look at using Index.

* Made Index an Int
Did preliminary fixes.
Made String use Index.

* Partial refactor of String.

* String::Buffer -> getBuffer
ToWString -> toWString

* Small improvements to String.
String::
Buffer() -> getBuffer()
Equals() -> equals

* Try to use Index where appropriate.

* Fix warnings on windows x86 builds.

1 files changed, 5 insertions, 5 deletions

diff --git a/source/slang/lookup.cpp b/source/slang/lookup.cpp
index 2c822eb15..fe535d6e7 100644
--- a/source/slang/lookup.cpp
+++ b/source/slang/lookup.cpp
@@ -42,7 +42,7 @@ void buildMemberDictionary(ContainerDecl* decl)
         return;
 
     decl->memberDictionary.Clear();
-    decl->transparentMembers.Clear();
+    decl->transparentMembers.clear();
 
     // are we a generic?
     GenericDecl* genericDecl = as<GenericDecl>(decl);
@@ -56,7 +56,7 @@ void buildMemberDictionary(ContainerDecl* decl)
         {
             TransparentMemberInfo info;
             info.decl = m.Ptr();
-            decl->transparentMembers.Add(info);
+            decl->transparentMembers.add(info);
         }
 
         // Ignore members with no name
@@ -121,13 +121,13 @@ void AddToLookupResult(
     else if (!result.isOverloaded())
     {
         // We are about to make this overloaded
-        result.items.Add(result.item);
-        result.items.Add(item);
+        result.items.add(result.item);
+        result.items.add(item);
     }
     else
     {
         // The result was already overloaded, so we pile on
-        result.items.Add(item);
+        result.items.add(item);
     }
 }