Feature/casting tidyup (#822)

* Use 'is' over 'as' where appropriate.

* dynamic_cast -> dynamicCast

* Replace 'dynamicCast' with 'as' where has no change in behavior/ambiguity.

* Replace dynamicCast with as where doesn't change behavior/non ambiguous.

1 files changed, 5 insertions, 5 deletions

diff --git a/source/slang/lookup.cpp b/source/slang/lookup.cpp
index 0ded328c7..2c822eb15 100644
--- a/source/slang/lookup.cpp
+++ b/source/slang/lookup.cpp
@@ -45,7 +45,7 @@ void buildMemberDictionary(ContainerDecl* decl)
     decl->transparentMembers.Clear();
 
     // are we a generic?
-    GenericDecl* genericDecl = dynamic_cast<GenericDecl*>(decl);
+    GenericDecl* genericDecl = as<GenericDecl>(decl);
 
     for (auto m : decl->Members)
     {
@@ -84,21 +84,21 @@ void buildMemberDictionary(ContainerDecl* decl)
 bool DeclPassesLookupMask(Decl* decl, LookupMask mask)
 {
     // type declarations
-    if(auto aggTypeDecl = dynamic_cast<AggTypeDecl*>(decl))
+    if(auto aggTypeDecl = as<AggTypeDecl>(decl))
     {
         return int(mask) & int(LookupMask::type);
     }
-    else if(auto simpleTypeDecl = dynamic_cast<SimpleTypeDecl*>(decl))
+    else if(auto simpleTypeDecl = as<SimpleTypeDecl>(decl))
     {
         return int(mask) & int(LookupMask::type);
     }
     // function declarations
-    else if(auto funcDecl = dynamic_cast<FunctionDeclBase*>(decl))
+    else if(auto funcDecl = as<FunctionDeclBase>(decl))
     {
         return (int(mask) & int(LookupMask::Function)) != 0;
     }
     // attribute declaration
-    else if( auto attrDecl = dynamic_cast<AttributeDecl*>(decl) )
+    else if( auto attrDecl = as<AttributeDecl>(decl) )
     {
         return (int(mask) & int(LookupMask::Attribute)) != 0;
     }