1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
|
// slang-win-process-util.cpp
#include "../slang-process-util.h"
#include "../slang-string.h"
#ifdef _WIN32
// Include Windows header in a way that minimized namespace pollution.
// TODO: We could try to avoid including this at all, but it would
// mean trying to hide certain struct layouts, which would add
// more dynamic allocation.
# define WIN32_LEAN_AND_MEAN
# define NOMINMAX
# include <Windows.h>
# undef WIN32_LEAN_AND_MEAN
# undef NOMINMAX
#endif
#include <stdio.h>
#include <stdlib.h>
namespace Slang {
namespace { // anonymous
struct ThreadInfo
{
HANDLE file;
String output;
};
// Has behavior very similar to unique_ptr - assignment is a move.
class WinHandle
{
public:
/// Detach the encapsulated handle. Returns the handle (which now must be externally handled)
HANDLE detach() { HANDLE handle = m_handle; m_handle = nullptr; return handle; }
/// Return as a handle
operator HANDLE() const { return m_handle; }
/// Assign
void operator=(HANDLE handle) { setNull(); m_handle = handle; }
void operator=(WinHandle&& rhs) { HANDLE handle = m_handle; m_handle = rhs.m_handle; rhs.m_handle = handle; }
/// Get ready for writing
SLANG_FORCE_INLINE HANDLE* writeRef() { setNull(); return &m_handle; }
/// Get for read access
SLANG_FORCE_INLINE const HANDLE* readRef() const { return &m_handle; }
void setNull()
{
if (m_handle)
{
CloseHandle(m_handle);
m_handle = nullptr;
}
}
/// Ctor
WinHandle(HANDLE handle = nullptr):m_handle(handle) {}
WinHandle(WinHandle&& rhs):m_handle(rhs.m_handle) { rhs.m_handle = nullptr; }
/// Dtor
~WinHandle() { setNull(); }
private:
WinHandle(const WinHandle&) = delete;
void operator=(const WinHandle& rhs) = delete;
HANDLE m_handle;
};
} // anonymous
static DWORD WINAPI _readerThreadProc(LPVOID threadParam)
{
ThreadInfo* info = (ThreadInfo*)threadParam;
HANDLE file = info->file;
static const int kChunkSize = 1024;
char buffer[kChunkSize];
StringBuilder outputBuilder;
// We need to re-write the output to deal with line
// endings, so we check for paired '\r' and '\n'
// characters, which may span chunks.
int prevChar = -1;
for (;;)
{
DWORD bytesRead = 0;
BOOL readResult = ReadFile(file, buffer, kChunkSize, &bytesRead, nullptr);
const DWORD lastError = GetLastError();
if (lastError == ERROR_BROKEN_PIPE)
{
break;
}
if (!readResult)
{
break;
}
// walk the buffer and rewrite to eliminate '\r' '\n' pairs
char* readCursor = buffer;
char const* end = buffer + bytesRead;
char* writeCursor = buffer;
while (readCursor != end)
{
int p = prevChar;
int c = *readCursor++;
prevChar = c;
switch (c)
{
case '\r': case '\n':
// swallow input if '\r' and '\n' appear in sequence
if ((p ^ c) == ('\r' ^ '\n'))
{
// but don't swallow the next byte
prevChar = -1;
continue;
}
// always replace '\r' with '\n'
c = '\n';
break;
default:
break;
}
*writeCursor++ = (char)c;
}
bytesRead = (DWORD)(writeCursor - buffer);
// Note: Current "core" implementation gives no way to know
// the length of the buffer, so we ultimately have
// to just assume null termination...
outputBuilder.Append(buffer, bytesRead);
}
info->output = outputBuilder.ProduceString();
return 0;
}
/* static */UnownedStringSlice ProcessUtil::getExecutableSuffix()
{
return UnownedStringSlice::fromLiteral(".exe");
}
/* static */void ProcessUtil::appendCommandLineEscaped(const UnownedStringSlice& slice, StringBuilder& out)
{
// TODO(JS): This escaping is not complete... !
if ((slice.indexOf(' ') >= 0 || slice.indexOf('"') >= 0))
{
out << "\"";
const char* cur = slice.begin();
const char* end = slice.end();
while (cur < end)
{
char c = *cur++;
switch (c)
{
case '\"':
{
// Escape quotes.
out << "\\\"";
break;
}
default:
out.append(c);
}
}
out << "\"";
return;
}
else
{
out << slice;
}
}
/* static */String ProcessUtil::getCommandLineString(const CommandLine& commandLine)
{
StringBuilder cmd;
appendCommandLineEscaped(commandLine.m_executable.getUnownedSlice(), cmd);
for (const auto& arg : commandLine.m_args)
{
cmd << " ";
if (arg.type == CommandLine::ArgType::Unescaped)
{
appendCommandLineEscaped(arg.value.getUnownedSlice(), cmd);
}
else
{
cmd << arg.value;
}
}
return cmd.ToString();
}
#define SLANG_RETURN_FAIL_ON_FALSE(x) if (!(x)) return SLANG_FAIL;
/* static */SlangResult ProcessUtil::execute(const CommandLine& commandLine, ExecuteResult& outExecuteResult)
{
outExecuteResult.init();
SECURITY_ATTRIBUTES securityAttributes;
securityAttributes.nLength = sizeof(securityAttributes);
securityAttributes.lpSecurityDescriptor = nullptr;
securityAttributes.bInheritHandle = true;
WinHandle childStdOutRead;
WinHandle childStdErrRead;
WinHandle childStdInWrite;
// Now we can actually get around to starting a process
PROCESS_INFORMATION processInfo;
ZeroMemory(&processInfo, sizeof(processInfo));
{
WinHandle childStdOutWrite;
WinHandle childStdErrWrite;
WinHandle childStdInRead;
{
WinHandle childStdOutReadTmp;
WinHandle childStdErrReadTmp;
WinHandle childStdInWriteTmp;
// create stdout pipe for child process
SLANG_RETURN_FAIL_ON_FALSE(CreatePipe(childStdOutReadTmp.writeRef(), childStdOutWrite.writeRef(), &securityAttributes, 0));
// create stderr pipe for child process
SLANG_RETURN_FAIL_ON_FALSE(CreatePipe(childStdErrReadTmp.writeRef(), childStdErrWrite.writeRef(), &securityAttributes, 0));
// create stdin pipe for child process
SLANG_RETURN_FAIL_ON_FALSE(CreatePipe(childStdInRead.writeRef(), childStdInWriteTmp.writeRef(), &securityAttributes, 0));
HANDLE currentProcess = GetCurrentProcess();
// create a non-inheritable duplicate of the stdout reader
SLANG_RETURN_FAIL_ON_FALSE(DuplicateHandle(currentProcess, childStdOutReadTmp, currentProcess, childStdOutRead.writeRef(), 0, FALSE, DUPLICATE_SAME_ACCESS));
// create a non-inheritable duplicate of the stderr reader
SLANG_RETURN_FAIL_ON_FALSE(DuplicateHandle(currentProcess, childStdErrReadTmp, currentProcess, childStdErrRead.writeRef(), 0, FALSE, DUPLICATE_SAME_ACCESS));
// create a non-inheritable duplicate of the stdin writer
SLANG_RETURN_FAIL_ON_FALSE(DuplicateHandle(currentProcess, childStdInWriteTmp, currentProcess, childStdInWrite.writeRef(), 0, FALSE, DUPLICATE_SAME_ACCESS));
}
// TODO: switch to proper wide-character versions of these...
STARTUPINFOW startupInfo;
ZeroMemory(&startupInfo, sizeof(startupInfo));
startupInfo.cb = sizeof(startupInfo);
startupInfo.hStdError = childStdErrWrite;
startupInfo.hStdOutput = childStdOutWrite;
startupInfo.hStdInput = childStdInRead;
startupInfo.dwFlags = STARTF_USESTDHANDLES;
OSString pathBuffer;
LPCWSTR path = nullptr;
if (commandLine.m_executableType == CommandLine::ExecutableType::Path)
{
StringBuilder cmd;
appendCommandLineEscaped(commandLine.m_executable.getUnownedSlice(), cmd);
pathBuffer = cmd.toWString();
path = pathBuffer.begin();
}
// Produce the command line string
String cmdString = getCommandLineString(commandLine);
OSString cmdStringBuffer = cmdString.toWString();
// https://docs.microsoft.com/en-us/windows/desktop/api/processthreadsapi/nf-processthreadsapi-createprocessa
// `CreateProcess` requires write access to this, for some reason...
BOOL success = CreateProcessW(
path,
(LPWSTR)cmdStringBuffer.begin(),
nullptr,
nullptr,
true,
CREATE_NO_WINDOW,
nullptr, // TODO: allow specifying environment variables?
nullptr,
&startupInfo,
&processInfo);
if (!success)
{
DWORD err = GetLastError();
SLANG_UNUSED(err);
return SLANG_FAIL;
}
// close handles we are now done with
CloseHandle(processInfo.hThread);
}
// Create a thread to read from the child's stdout.
ThreadInfo stdOutThreadInfo;
stdOutThreadInfo.file = childStdOutRead;
WinHandle stdOutThread = CreateThread(nullptr, 0, &_readerThreadProc, (LPVOID)&stdOutThreadInfo, 0, nullptr);
// Create a thread to read from the child's stderr.
ThreadInfo stdErrThreadInfo;
stdErrThreadInfo.file = childStdErrRead;
WinHandle stdErrThread = CreateThread(nullptr, 0, &_readerThreadProc, (LPVOID)&stdErrThreadInfo, 0, nullptr);
// wait for the process to exit
// TODO: set a timeout as a safety measure...
WaitForSingleObject(processInfo.hProcess, INFINITE);
// get exit code for process
// https://docs.microsoft.com/en-us/windows/desktop/api/processthreadsapi/nf-processthreadsapi-getexitcodeprocess
DWORD childExitCode = 0;
if (!GetExitCodeProcess(processInfo.hProcess, &childExitCode))
{
// TODO(JS): Do we want to close here? It seems plausible because just because reading the exit code failed, doesn't mean the handle is closed
CloseHandle(processInfo.hProcess);
return SLANG_FAIL;
}
// wait for the reader threads
WaitForSingleObject(stdOutThread, INFINITE);
WaitForSingleObject(stdErrThread, INFINITE);
CloseHandle(processInfo.hProcess);
outExecuteResult.standardOutput = stdOutThreadInfo.output;
outExecuteResult.standardError = stdErrThreadInfo.output;
outExecuteResult.resultCode = childExitCode;
return SLANG_OK;
}
}
|