diff options
Diffstat (limited to 'source')
| -rw-r--r-- | source/slang/slang-parser.cpp | 27 |
1 files changed, 13 insertions, 14 deletions
diff --git a/source/slang/slang-parser.cpp b/source/slang/slang-parser.cpp index e71b6162c..5b6f30477 100644 --- a/source/slang/slang-parser.cpp +++ b/source/slang/slang-parser.cpp @@ -7249,7 +7249,7 @@ static IntegerLiteralValue _fixIntegerLiteral( // If the masked value is 0 or equal to the mask, we 'assume' no information is // lost // This allows for example -1u, to give 0xffffffff - // It also means 0xfffffffffffffffffu will give 0xffffffff, without a warning. + // It also means 0xffffffffffffffffu will give 0xffffffff, without a warning. if ((!(maskedValue == 0 || maskedValue == mask)) && sink && token) { // Output a warning that number has been altered @@ -7306,20 +7306,19 @@ static BaseType _determineNonSuffixedIntegerLiteralType( { baseType = BaseType::UInt64; - if (isDecimalBase) - { - // There is an edge case here where 9223372036854775808 or INT64_MAX + 1 - // brings us here, but the complete literal is -9223372036854775808 or INT64_MIN and is - // valid. Unfortunately because the lexer handles the negative(-) part of the literal - // separately it is impossible to know whether the literal has a negative sign or not. - // We emit the warning and initially process it as a uint64 anyways, and the negative - // sign will be properly parsed and the value will still be properly stored as a - // negative INT64_MIN. + // Emit warning if the value is too large for signed 64-bit, regardless of base - // Decimal integer is too large to be represented as signed. - // Output warning that it is represented as unsigned instead. - sink->diagnose(*token, Diagnostics::integerLiteralTooLarge); - } + // There is an edge case here where 9223372036854775808 or INT64_MAX + 1 + // brings us here, but the complete literal is -9223372036854775808 or INT64_MIN and is + // valid. Unfortunately because the lexer handles the negative(-) part of the literal + // separately it is impossible to know whether the literal has a negative sign or not. + // We emit the warning and initially process it as a uint64 anyways, and the negative + // sign will be properly parsed and the value will still be properly stored as a + // negative INT64_MIN. + + // Decimal integer is too large to be represented as signed. + // Output warning that it is represented as unsigned instead. + sink->diagnose(*token, Diagnostics::integerLiteralTooLarge); } return baseType; |