diff options
Diffstat (limited to 'source/slang/slang-emit-cpp.cpp')
| -rw-r--r-- | source/slang/slang-emit-cpp.cpp | 20 |
1 files changed, 20 insertions, 0 deletions
diff --git a/source/slang/slang-emit-cpp.cpp b/source/slang/slang-emit-cpp.cpp index ffc4b97ef..66829308d 100644 --- a/source/slang/slang-emit-cpp.cpp +++ b/source/slang/slang-emit-cpp.cpp @@ -307,6 +307,25 @@ SlangResult CPPSourceEmitter::calcTypeName(IRType* type, CodeGenTarget target, S case kIROp_PtrType: case kIROp_ConstRefType: { + // Special note on `constref` types and why they are not emitted + // as a `const` pointer: + // + // We currently do not propegate/manage "constness" for locals. + // This is important since it means that we rely on opimization + // passes to remove all temporary pointer-variables created from + // our constref, otherwise we will generate invalid code like + // `T* var = const_ptr` or `T* var = &const_ptr->member`. + // + // If emitting `constref` fails due to this error, it is likely + // a missing compiler-optimization. + // + // Additionally, for C++/CUDA, downstream methods are required + // to be `const` if we want to use const pointers. This is currently + // not handled robustly. + // + // Due to these cascading issues, we do not emit const and instead + // emit as a regular pointer for the time being. + auto elementType = (IRType*)type->getOperand(0); SLANG_RETURN_ON_FAIL(calcTypeName(elementType, target, out)); out << "*"; @@ -599,6 +618,7 @@ CPPSourceEmitter::CPPSourceEmitter(const Desc& desc) void CPPSourceEmitter::emitParamTypeImpl(IRType* type, String const& name) { + // For use the CPP-specific emitType implementation emitType(type, name); } |