diff options
Diffstat (limited to 'source/slang/slang-check-overload.cpp')
| -rw-r--r-- | source/slang/slang-check-overload.cpp | 30 |
1 files changed, 29 insertions, 1 deletions
diff --git a/source/slang/slang-check-overload.cpp b/source/slang/slang-check-overload.cpp index 21fc21df6..b818c9e06 100644 --- a/source/slang/slang-check-overload.cpp +++ b/source/slang/slang-check-overload.cpp @@ -711,7 +711,35 @@ bool SemanticsVisitor::TryCheckOverloadCandidateTypes( } else { - arg.argExpr = coerce(CoercionSite::Argument, paramType, arg.argExpr); + Expr* coercedExpr = coerce(CoercionSite::Argument, paramType, arg.argExpr); + + // Check if concrete-to-interface coercion caused loss of l-valueness. + if (coercedExpr && !coercedExpr->type.isLeftValue && paramType.isLeftValue && + !isInterfaceType(arg.type) && isInterfaceType(paramType.type)) + { + if (context.mode != OverloadResolveContext::Mode::JustTrying) + { + String name; + if (candidate.flavor == OverloadCandidate::Flavor::Func) + { + auto decl = getParameters( + m_astBuilder, + candidate.item.declRef.as<CallableDecl>())[paramIndex]; + name = getText(decl.getName()); + } + else + name.append(paramIndex, 10); + + getSink()->diagnose( + context.loc, + Diagnostics::concreteArgumentToOutputInterface, + name, + arg.type, + paramType.type); + } + return {nullptr, nullptr}; + } + arg.argExpr = coercedExpr; } return arg; }; |
