summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--source/slang/slang-check-decl.cpp14
-rw-r--r--source/slang/slang-diagnostic-defs.h3
-rw-r--r--tests/language-server/incomplete-inheritance.slang10
-rw-r--r--tests/language-server/incomplete-inheritance.slang.expected.txt12
4 files changed, 36 insertions, 3 deletions
diff --git a/source/slang/slang-check-decl.cpp b/source/slang/slang-check-decl.cpp
index 7871d35dd..94858b679 100644
--- a/source/slang/slang-check-decl.cpp
+++ b/source/slang/slang-check-decl.cpp
@@ -3039,8 +3039,13 @@ namespace Slang
return true;
}
}
-
- getSink()->diagnose(inheritanceDecl, Diagnostics::unimplemented, "type not supported for inheritance");
+ if (!as<ErrorType>(superType))
+ {
+ getSink()->diagnose(
+ inheritanceDecl,
+ Diagnostics::invalidTypeForInheritance,
+ superType);
+ }
return false;
}
@@ -4566,7 +4571,10 @@ namespace Slang
return;
}
}
- getSink()->diagnose(decl->targetType.exp, Diagnostics::unimplemented, "an 'extension' can only extend a nominal type");
+ if (!as<ErrorType>(decl->targetType.type))
+ {
+ getSink()->diagnose(decl->targetType.exp, Diagnostics::invalidExtensionOnType, decl->targetType);
+ }
}
void SemanticsDeclBasesVisitor::visitExtensionDecl(ExtensionDecl* decl)
diff --git a/source/slang/slang-diagnostic-defs.h b/source/slang/slang-diagnostic-defs.h
index 059df4453..ff2775328 100644
--- a/source/slang/slang-diagnostic-defs.h
+++ b/source/slang/slang-diagnostic-defs.h
@@ -364,6 +364,9 @@ DIAGNOSTIC(30821, Error, tagTypeMustBeListedFirst, "an unum type may only have a
DIAGNOSTIC(30820, Error, cannotInheritFromExplicitlySealedDeclarationInAnotherModule, "cannot inherit from type '$0' marked 'sealed' in module '$1'")
DIAGNOSTIC(30821, Error, cannotInheritFromImplicitlySealedDeclarationInAnotherModule, "cannot inherit from type '$0' in module '$1' because it is implicitly 'sealed'; mark the base type 'open' to allow inheritance across modules")
+DIAGNOSTIC(30822, Error, invalidTypeForInheritance, "type '$0' cannot be used for inheritance")
+
+DIAGNOSTIC(30850, Error, invalidExtensionOnType, "type '$0' cannot be extended. `extension` can only be used to extend a nominal type.")
// 309xx: subscripts
diff --git a/tests/language-server/incomplete-inheritance.slang b/tests/language-server/incomplete-inheritance.slang
new file mode 100644
index 000000000..fe3926a58
--- /dev/null
+++ b/tests/language-server/incomplete-inheritance.slang
@@ -0,0 +1,10 @@
+//TEST:LANG_SERVER:
+
+struct MyType : INotExist{};
+
+void m()
+{
+//HOVER:8,9
+ MyType b;
+ reinterpret<MyType, MyType>(b);
+}
diff --git a/tests/language-server/incomplete-inheritance.slang.expected.txt b/tests/language-server/incomplete-inheritance.slang.expected.txt
new file mode 100644
index 000000000..ceaf9104b
--- /dev/null
+++ b/tests/language-server/incomplete-inheritance.slang.expected.txt
@@ -0,0 +1,12 @@
+--------
+range: 7,4 - 7,10
+content:
+```
+struct MyType
+```
+
+
+
+{REDACTED}.slang(3)
+
+