diff options
| author | Tim Foley <tfoleyNV@users.noreply.github.com> | 2020-08-21 09:47:29 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-08-21 09:47:29 -0700 |
| commit | 49067fd2e97b40649df3fa2ce096f78c2e45da5a (patch) | |
| tree | 015b1d31a0e43b885d09d6ea2f5a8e033abb2ea8 /tools/slang-test | |
| parent | 5e64ae752407492f17b346e0429a6fd38238fbb6 (diff) | |
Fix stdlib declarations for texture Gather() (#1510)
Fixes #1507
These operations were failing to take into account the way that array textures require an extra coordinate to be passed in for the primary location (but not the additional offsets). Adding `isArray` to the component count is the existing solution used for similar intrinsics elsewhere in the stdlib, and it is adopted here.
Because our test framework isn't really set up to do a lot of texture testing (including having no support for texture arrays), the test added here is just a cross-compilation test that compares output with fxc for comparable input.
Diffstat (limited to 'tools/slang-test')
| -rw-r--r-- | tools/slang-test/slang-test-main.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/tools/slang-test/slang-test-main.cpp b/tools/slang-test/slang-test-main.cpp index 25aa13986..1144b4034 100644 --- a/tools/slang-test/slang-test-main.cpp +++ b/tools/slang-test/slang-test-main.cpp @@ -1732,6 +1732,7 @@ TestResult runCrossCompilerTest(TestContext* context, TestInput& input) switch (target) { + case SLANG_DXIL: case SLANG_DXIL_ASM: { expectedCmdLine.addArg(filePath + ".hlsl"); @@ -1739,6 +1740,7 @@ TestResult runCrossCompilerTest(TestContext* context, TestInput& input) expectedCmdLine.addArg("dxc"); break; } + case SLANG_DXBC: case SLANG_DXBC_ASM: { expectedCmdLine.addArg(filePath + ".hlsl"); |
