diff options
| author | Jay Kwak <82421531+jkwak-work@users.noreply.github.com> | 2025-09-23 23:46:31 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-09-23 23:46:31 -0700 |
| commit | 979e16a34ef9ff2806476b809e2dcba5a96c40d4 (patch) | |
| tree | 0572ac88539aa33ede15f8089cd9a7903b816f9f /tools/slang-test/test-context.cpp | |
| parent | 796ea80a0309002f7a4c959416b4b2cf67bf4a27 (diff) | |
Adding slang-test option to ignore abort popup message (#8492)
With the recent Windows runtime libraries, a new popup window started
appearing when `abort()` is called. This was observed when VVL prints a
message as a part of WGPU test.
Although it can be helpful when we want to debug it, it breaks the
behavior of CI scripts when the tests are expected to continue even when
they fail. When the test fail, CI script stops in the middle and wait
for a user to click on a button on the dialog window, which cannot
happen. As a result, when there is a VVL error message, CI run stops in
the middle and the testing stops prematurely.
This commit adds a new command-line argument, `-ignore-abort-msg`, that
ignores the abort message and it wouldn't show the dialog popup window.
From the implementation perspective, there are three places that are
related.
- slang-test itself should turn off the flag.
- render-test should turn off the flag after getting the argument from
slang-test
- test-server should turn off the flag after getting the argument from
slang-test
When test-server runs render-test, the arguments are already handled by
slang-test, so test-server needs to just pass through the arguments.
Diffstat (limited to 'tools/slang-test/test-context.cpp')
| -rw-r--r-- | tools/slang-test/test-context.cpp | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/tools/slang-test/test-context.cpp b/tools/slang-test/test-context.cpp index e3655e61d..a864cb326 100644 --- a/tools/slang-test/test-context.cpp +++ b/tools/slang-test/test-context.cpp @@ -196,6 +196,12 @@ SlangResult TestContext::_createJSONRPCConnection(RefPtr<JSONRPCConnection>& out { CommandLine cmdLine; cmdLine.setExecutableLocation(ExecutableLocation(exeDirectoryPath, "test-server")); + + if (options.ignoreAbortMsg) + { + cmdLine.addArg("-ignore-abort-msg"); + } + SLANG_RETURN_ON_FAIL(Process::create( cmdLine, Process::Flag::AttachDebugger | Process::Flag::DisableStdErrRedirection, |
