Remove support for the -no-checking flag (#392)

* Remove support for the -no-checking flag

Fixes #381
Fixes #383
Work on #382

- No longer expose flag through API (`SLANG_COMPILE_FLAG_NO_CHECKING`) and command-line (`-no-checking`) options

- Remove all logic in `check.cpp` that was withholding diagnostics (including errors) when the no-checking mode was enabled

- Remove `HiddenImplicitCastExpr`, which was only created to support no-checking mode (it represented an implicit cast that our checking through was needed, but couldn't emit because it might be wrong)

- Remove logic for storing function bodies as raw token lists when checking is turned off. I'm leaving in the `UnparsedStmt` AST node in case we ever need/want to lazily parse and check function bodies down the line.

- Remove a few of the code-generation paths we had to contend with, but keep the comment about them in place.

- Remove GLSL-based tests that can't meaningfully work with the new approach.

- Fix other tests that used a GLSL baseline so that their GLSL compiles with `-pass-through glslang` instead of invoking `slang` with the `-no-checking` flag.

- Remove tests that were explicitly added to test the "rewriter + IR" path, since that is no longer supported.

There is more cleanup that can be done here, now that we know that AST-based rewrite and IR will never co-exist, but it is probably easier to deal with that as part of removing the AST-based rewrite path.

We've lost some test coverage here, but actually not too much if we consider that we are dropping GLSL input anyway.

* Fixup: test runner was mis-counting ignored tests

* Fixup: turn on dumping on test failure under Travis

* Fixup: enable extensions in Linux build of glslang

1 files changed, 6 insertions, 6 deletions

diff --git a/tools/render-test/slang-support.cpp b/tools/render-test/slang-support.cpp
index a75e35bd4..2a6401d5b 100644
--- a/tools/render-test/slang-support.cpp
+++ b/tools/render-test/slang-support.cpp
@@ -34,13 +34,13 @@ struct SlangShaderCompilerWrapper : public ShaderCompiler
 		}
 		spAddPreprocessorDefine(slangRequest, langDefine, "1");
 
-        // If we aren't dealing with true Slang input, then don't enable checking.
-        //
-        // Note: do this before using command-line arguments to set flags, so
-        // that we don't accidentally clobber other flags.
-        if (sourceLanguage != SLANG_SOURCE_LANGUAGE_SLANG)
+        // If we are dealing with GLSL input, then we need to set up
+        // Slang to pass through to glslang instead of actually running
+        // the compiler (this is a workaround to make direct comparisons
+        // possible)
+        if (sourceLanguage == SLANG_SOURCE_LANGUAGE_GLSL)
         {
-            spSetCompileFlags(slangRequest, SLANG_COMPILE_FLAG_NO_CHECKING);
+            spSetPassThrough(slangRequest, SLANG_PASS_THROUGH_GLSLANG);
         }
 
         // Preocess any additional command-line options specified for Slang using