diff options
| author | cheneym2 <acheney@nvidia.com> | 2025-02-26 21:20:29 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-02-26 18:20:29 -0800 |
| commit | 02706dfc5f0526f4f8ca337be16d7b00640ba168 (patch) | |
| tree | 08a7b1a94aaa048a07864bf7dec68ab23fb00edb /tools/gfx/vulkan/vk-shader-program.cpp | |
| parent | 6e862bb370c1f64abf0e7f9efa73dec38a76555e (diff) | |
Fix precompiledTargetModule tests (#6455)
* Fix precompiledTargetModule tests
Add SPIRV-Tool linker support to gfx unit tests
and use the linker in precompileModule tests
that use precompiled modules to reconstitute
SPIRV shaders that were modularly compiled.
Fix a Slang reference count bug in the
precompile service.
* Use sm_6_6
New DXC requires higher version
for linkability.
* Rename helper function, pass by reference
* Link through slang-glslang
* Add missing files
* Fix metal
* format code
---------
Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com>
Co-authored-by: Yong He <yonghe@outlook.com>
Diffstat (limited to 'tools/gfx/vulkan/vk-shader-program.cpp')
| -rw-r--r-- | tools/gfx/vulkan/vk-shader-program.cpp | 14 |
1 files changed, 11 insertions, 3 deletions
diff --git a/tools/gfx/vulkan/vk-shader-program.cpp b/tools/gfx/vulkan/vk-shader-program.cpp index 43a295786..1627c95a7 100644 --- a/tools/gfx/vulkan/vk-shader-program.cpp +++ b/tools/gfx/vulkan/vk-shader-program.cpp @@ -1,6 +1,7 @@ // vk-shader-program.cpp #include "vk-shader-program.h" +#include "external/spirv-tools/include/spirv-tools/linker.hpp" #include "vk-device.h" #include "vk-util.h" @@ -71,15 +72,22 @@ VkPipelineShaderStageCreateInfo ShaderProgramImpl::compileEntryPoint( Result ShaderProgramImpl::createShaderModule( slang::EntryPointReflection* entryPointInfo, - ComPtr<ISlangBlob> kernelCode) + List<ComPtr<ISlangBlob>>& kernelCodes) { - m_codeBlobs.add(kernelCode); + ComPtr<ISlangBlob> linkedKernel = m_device->m_glslang.linkSPIRV(kernelCodes); + if (!linkedKernel) + { + return SLANG_FAIL; + } + + m_codeBlobs.add(linkedKernel); + VkShaderModule shaderModule; auto realEntryPointName = entryPointInfo->getNameOverride(); const char* spirvBinaryEntryPointName = "main"; m_stageCreateInfos.add(compileEntryPoint( spirvBinaryEntryPointName, - kernelCode, + linkedKernel, (VkShaderStageFlagBits)VulkanUtil::getShaderStage(entryPointInfo->getStage()), shaderModule)); m_entryPointNames.add(realEntryPointName); |
