Redesign `DeclRef` and systematic `Val` deduplication (#3049)

* Redesign DeclRef + Deduplicate Val.

* Update project files

* Fix warning.

* Fix.

* Fix.

* Remove `Val::_equalsImplOverride`.

* Rmove `Val::_getHashCodeOverride`.

* Remove `semanticVisitor` param from `resolve`.

* Cleanups.

---------

Co-authored-by: Yong He <yhe@nvidia.com>

6 files changed, 16 insertions, 9 deletions

diff --git a/tests/autodiff/generic-impl-jvp.slang b/tests/autodiff/generic-impl-jvp.slang
index 674d5c5ca..4e28eeaf8 100644
--- a/tests/autodiff/generic-impl-jvp.slang
+++ b/tests/autodiff/generic-impl-jvp.slang
@@ -11,6 +11,7 @@ typealias IDFloat = __BuiltinRealType & IDifferentiable;
 __generic<T : IDifferentiable, let N : int>
 struct dvector : IDifferentiable
 {
+    typedef dvector<T.Differential, N> Differential;
     T values[N];
 };
 
@@ -147,6 +148,8 @@ DifferentialPair<T> dot_jvp(dpvector<T, N> a, dpvector<T, N> b)
 __generic<let N : int>
 struct lineardvector : IDifferentiable
 {
+    typedef lineardvector<N> Differential;
+
     myvector<Real, N>.Differential val;
 
     __init(vector<Real.Differential, N> a)
diff --git a/tests/autodiff/getter-setter-multi.slang b/tests/autodiff/getter-setter-multi.slang
index 9f03ac4eb..3f8257897 100644
--- a/tests/autodiff/getter-setter-multi.slang
+++ b/tests/autodiff/getter-setter-multi.slang
@@ -6,6 +6,7 @@ RWStructuredBuffer<float> outputBuffer;
 
 struct B : IDifferentiable
 {
+    typedef B Differential;
     float3 z;
     float.Differential k[10];
 };
diff --git a/tests/autodiff/getter-setter.slang b/tests/autodiff/getter-setter.slang
index bc7343f27..1b0b8232e 100644
--- a/tests/autodiff/getter-setter.slang
+++ b/tests/autodiff/getter-setter.slang
@@ -6,6 +6,8 @@ RWStructuredBuffer<float> outputBuffer;
 
 struct B : IDifferentiable
 {
+    typedef B Differential;
+
     float z;
 };
 
diff --git a/tests/diagnostics/mismatching-types.slang.expected b/tests/diagnostics/mismatching-types.slang.expected
index 65a6df32e..3bbab624d 100644
--- a/tests/diagnostics/mismatching-types.slang.expected
+++ b/tests/diagnostics/mismatching-types.slang.expected
@@ -15,13 +15,13 @@ tests/diagnostics/mismatching-types.slang(57): error 30019: expected an expressi
 tests/diagnostics/mismatching-types.slang(59): error 30019: expected an expression of type 'GenericOuter<int>.NonGenericInner', got 'GenericOuter<float>.NonGenericInner'
     a.ng = b.ng;
              ^~
-tests/diagnostics/mismatching-types.slang(61): error 30019: expected an expression of type 'NonGenericOuter.GenericInner<int>', got 'int'
+tests/diagnostics/mismatching-types.slang(61): error 30019: expected an expression of type 'GenericInner<int>', got 'int'
     c.i = 0;
           ^
-tests/diagnostics/mismatching-types.slang(63): error 30019: expected an expression of type 'NonGenericOuter.GenericInner<int>', got 'NonGenericOuter.GenericInner<float>'
+tests/diagnostics/mismatching-types.slang(63): error 30019: expected an expression of type 'GenericInner<int>', got 'GenericInner<float>'
     c.i = c.f;
             ^
-tests/diagnostics/mismatching-types.slang(65): error 30019: expected an expression of type 'NonGenericOuter.GenericInner<int>.ReallyNested', got 'int'
+tests/diagnostics/mismatching-types.slang(65): error 30019: expected an expression of type 'GenericInner<int>.ReallyNested', got 'int'
     c.i.n = 0;
             ^
 tests/diagnostics/mismatching-types.slang(74): error 30019: expected an expression of type 'Texture1D<int>', got 'Texture1D<float>'
diff --git a/tests/doc/doc.slang.expected b/tests/doc/doc.slang.expected
index df51728e7..ed9892b33 100644
--- a/tests/doc/doc.slang.expected
+++ b/tests/doc/doc.slang.expected
@@ -49,7 +49,7 @@ A useless method hey ho
 ## Signature 
 
 ```
-ParentStruct.T ParentStruct<T>.ChildStruct<S>.getValue(ParentStruct<ParentStruct.T>.ChildStruct.S v);
+T ParentStruct<T>.ChildStruct<S>.getValue(S v);
 ```
 
 ## Parameters
@@ -77,7 +77,7 @@ ParentStruct.T ParentStruct<T>.ChildStruct<S>.getValue(ParentStruct<ParentStruct
 ## Signature 
 
 ```
-GenericStruct.T GenericStruct<T>.getValue();
+T GenericStruct<T>.getValue();
 ```
 
 --------------------------------------------------------------------------------
@@ -160,9 +160,9 @@ Add two integers
 ## Signature 
 
 ```
-IDoThing.V IDoThing.add(
-    IDoThing.V           a,
-    IDoThing.V           b);
+This.V IDoThing.add(
+    This.V               a,
+    This.V               b);
 ```
 
 ## Parameters
diff --git a/tests/language-server/smoke.slang.expected.txt b/tests/language-server/smoke.slang.expected.txt
index 0b37ed9db..212bcdabb 100644
--- a/tests/language-server/smoke.slang.expected.txt
+++ b/tests/language-server/smoke.slang.expected.txt
@@ -2,11 +2,12 @@
 first: 6  ,.;:()[]<>{}*&^%!-=+|/? 
 second: 6  ,.;:()[]<>{}*&^%!-=+|/? 
 getSum: 2  ,.;:()[]<>{}*&^%!-=+|/? 
+This: 14  ,.;:()[]<>{}*&^%!-=+|/? 
 --------
 range: 24,26 - 24,31
 content:
 ```
-(field) Pair.T Pair<Pair.T, Pair.U>.first
+(field) T Pair<T, U>.first
 ```