diff options
| author | Jay Kwak <82421531+jkwak-work@users.noreply.github.com> | 2025-08-28 10:45:07 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-08-28 17:45:07 +0000 |
| commit | c19e2e92ae8e713225262a17f39a438cd511d416 (patch) | |
| tree | 7c78e65d3c826c52b527c71500a72ecb18754254 /tests/spirv/debug-value-dynamic-index.slang | |
| parent | 3dc466487d489f09c835bdd872eb130cdc5784ea (diff) | |
Remove the embedded source to avoid self-matching in slang-test (#8305)
When `SIMPLE` type test is used with `-g[1-3]` option, the filecheck
pattern will most likely to match to the string itself on the embedded
source code rather than match to the emitted spirv-asm code.
This commit avoids the problem by removing the embedded source code.
This commit also provides an option to keep the embedded source code,
`-preserve-embedded-source`.
The source code removal is happening in two steps:
1. iterate all output lines and find SPIRV-ASM in the following pattern:
`%N = OpExtInst %void %M DebugSource %fileId %sourceId`. And then, store
the "%sourceId" value to identify which SPIRV instructions are for the
embedded source code.
2. iterate all output lines again to find the `%sourceId = OpString
"...."` and replace the whole string with the following string, ``` %1 =
OpString "// slang-test removed the embedded source // Use
`-preserve-embedded-source` to keep it explicitly " ```
This change revealed problems in the existing tests:
- tests/bugs/spirv-debug-info.slang : The expected text was missing and
it had to be added. The file also had Carrage-Return character on all
lines and the pre-commit git hook removed them.
- tests/spirv/debug-info.slang : the expected keyword DebugValue had to
change to DebugDeclare, because that's what we get with ToT.
- tests/spirv/debug-value-dynamic-index.slang : This test is currently
failing, and it will pass once DebugLocalVariable instruction missing
for parameter of the entry point function #7693 is resolved.
---------
Co-authored-by: slangbot <ellieh+slangbot@nvidia.com>
Diffstat (limited to 'tests/spirv/debug-value-dynamic-index.slang')
| -rw-r--r-- | tests/spirv/debug-value-dynamic-index.slang | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/tests/spirv/debug-value-dynamic-index.slang b/tests/spirv/debug-value-dynamic-index.slang index 591b1f6da..8b4f6b43e 100644 --- a/tests/spirv/debug-value-dynamic-index.slang +++ b/tests/spirv/debug-value-dynamic-index.slang @@ -1,4 +1,5 @@ -//TEST:SIMPLE(filecheck=CHECK):-target spirv -entry main -stage compute -g2 -emit-spirv-directly +// This will be re-enabled when github #7693 is resolved +//DISABLE_TEST:SIMPLE(filecheck=CHECK):-target spirv -entry main -stage compute -g2 -emit-spirv-directly struct TestType { @@ -25,5 +26,5 @@ void main(int id : SV_DispatchThreadID) // CHECK: DebugTypeComposite // CHECK: DebugFunctionDefinition // CHECK: DebugScope +// CHECK: DebugDeclare // CHECK: DebugLine -// CHECK: DebugValue |