Fix compiler warning with clang 18.1.8 on windows (#6843) - slang.git

path: root/tests/reflection/std430-layout.glsl.expected

diff options

author	Jay Kwak <82421531+jkwak-work@users.noreply.github.com>	2025-04-17 02:34:39 -0700
committer	GitHub <noreply@github.com>	2025-04-17 09:34:39 +0000
commit	04db5a95657a8c1ad1db36570eadaeedbea01cbb (patch)
tree	4d61bd130c86a0d60c55bf1fa14e79b6fce8dcd7 /tests/reflection/std430-layout.glsl.expected
parent	297417c754961d2c1c3f8a2e94126c668e4574bc (diff)

Fix compiler warning with clang 18.1.8 on windows (#6843)

* Fix compiler warning with clang 18.1.8 on windows

Diffstat (limited to 'tests/reflection/std430-layout.glsl.expected')

0 files changed, 0 insertions, 0 deletions

0 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677

#include "slang-ir-liveness.h"

#include "slang-ir-dominators.h"
#include "slang-ir-insts.h"
#include "slang-ir.h"

namespace Slang
{

/*
Discussion
==========

* We don't need to care about extractField / extractElement, as they only work directly on the value
* We need to track aliases created via getFieldPtr / getElementPtr
* There is a distinction between a 'pointer' and an 'address'.
  * A "pointer" can 'escape' just as in other languages, and is the general case
  * If we are talking about an "address", then this is constrained by our language rules,

NOTE! Confusingly there is getElementPtr and getFieldAddress (and getAddress). I also don't see
Addr/Addr type as a distinct thing from Ptr, so I assume that differentiation is aspirational?

A) We don't need to worry about a phi node temporary holding a pointer (or scope ending *on* the
branch), because the phi node will pass the result by value, leading to a *load* before the branch..

Other

```
 let foo : Ptr<SomeStruct> = var;
...
store(someOtherPtr, foo); // this is `store`, but not a store *to* foo!!!!!
...
```

Here a *pointer* is being stored into someOtherPtr. This means all bets are off. Liveness will have
to be assumed anywhere the variable is accessible.
TODO(JS): Note that currently this scenario isn't handled by this algorithm.

```
   let foo : Ptr<SomeStruct> = var;
   ...
   br SomeOtherThing(foo); // OH NO!!!
```

It is believed this can't happen in current code. Leading to assertion A) above.

* Long-term IR type-system thing: we should probably have an explicit instruction
  that casts a local `Ptr<Foo>` to either an `Out<Foo>` or `InOut<Foo>` for exactly
  these cases (and then use the *cast* operation to tell us what is going on).
*/

/*
Take the code sequence

```HLSL
    SomeStruct s;
    SomeStruct t = makeSomeStruct();
    SomeStruct u = {};
```

Produces something like...

```HLSL
    SomeStruct_0 s_1;
    SLANG_LIVE_START(s_1)
    SomeStruct_0 t_0;
    SLANG_LIVE_START(t_0)
    SomeStruct_0 _S4 = makeSomeStruct_0();
    t_0 = _S4;
    SomeStruct_0 u_0;
    SLANG_LIVE_START(u_0)
    SomeStruct_0 _S6 = { ... };
    u_0 = _S6;
```

This is good, in so far as the variables do get LIVE_START, however they are defined. It is perhaps
'bad' in so far as a temporary is created that is then just copied into the variable. That temporary
being something that is mutable, and can be partially modified (it's a struct) could perhaps have
liveness issues.
*/

namespace
{ // anonymous

/*
A helper class to enable using a backing array, used in a stack like manner. */
template<typename T>
class RAIIStackArray
{
public:
    ArrayView<T> getView()
    {
        return makeArrayView(m_list->getBuffer() + m_startIndex, m_list->getCount() - m_startIndex);
    }
    ConstArrayView<T> getConstView() const
    {
        return makeConstArrayView(
            m_list->getBuffer() + m_startIndex,
            m_list->getCount() - m_startIndex);
    }

    void setCount(Count count) { m_list->setCount(m_startIndex + count); }
    Count getCount() const { return m_list->getCount() - m_startIndex; }

    T& operator[](Index i) { return (*m_list)[m_startIndex + i]; }
    const T& operator[](Index i) const { return (*m_list)[m_startIndex + i]; }

    RAIIStackArray(List<T>* list)
        : m_startIndex(list->getCount()), m_list(list)
    {
        SLANG_ASSERT(list);
    }
    ~RAIIStackArray() { m_list->setCount(m_startIndex); }

    const Index m_startIndex;
    List<T>* m_list;
};

struct LivenessContext
{
    enum class BlockIndex : Index
    {
        Invalid = -1
    };

    // NOTE! Care must be taken changing the order.
    // canPromote checks if a result can be 'promoted'.
    enum class BlockResult
    {
        Found,    ///< All paths were either not dominated, found
        NotFound, ///< It is dominated but no access was found.
        Visited,  ///< The block has been visited (as part of a traversal), but does not yet have a
                  ///< result. Used to detect loops.
        NotVisited,   ///< Not visited
        NotDominated, ///< If it's not dominated it can't have a liveness end

        CountOf,
    };

    /// True if a result can be premoted `from` to `to`
    static bool canPromote(BlockResult from, BlockResult to)
    {
        return (from == BlockResult::NotVisited) ||
               (Index(to) <= Index(from) && from != BlockResult::NotDominated);
    }

    enum class AccessType
    {
        None,   ///< There is no access
        Alias,  ///< Produces an alias to the root
        Access, ///< Is an access to the root (perhaps through an alias)
    };

    /// Block info (indexed via BlockIndex), that is valid across analysing liveness of a root
    struct BlockInfo
    {
        /// Reset any information for a start
        void resetForStart() { result = BlockResult::NotVisited; }

        /// Reset any information needed for a new root
        void resetForRoot()
        {
            resetForStart();

            runStart = 0;
            runCount = 0;
            lastInst = nullptr;
            instCount = 0;
        }

        // These are reset for *each* liveness start
        BlockResult result; ///< The result for this block

        // These remain constant for all live starts to a root.
        Index runStart;   ///< The start index in m_instRuns index. This defines a instruction of
                          ///< interest in order in a block.
        Count runCount;   ///< The count of the amount insts in the run
        IRInst* lastInst; ///< Last inst seen
        Count instCount;  ///< The total amount of start/access instruction seen in the block
    };

    /// Block info (indexed via BlockIndex), that is fixed across a function
    struct FixedBlockInfo
    {
        void init(IRBlock* inBlock)
        {
            block = inBlock;
            successorsStart = 0;
            successorsCount = 0;
            breakBlockIndex = BlockIndex::Invalid;
            targetBlockIndex = BlockIndex::Invalid;
            owningLoopBlockIndex = BlockIndex::Invalid;
        }

        bool isLoopStart() const { return breakBlockIndex != BlockIndex::Invalid; }

        IRBlock* block; ///< The block

        BlockIndex breakBlockIndex;  ///< If this block terminates in a loop holds the break block
        BlockIndex targetBlockIndex; ///< If this block terminates in a loop holds the target block

        BlockIndex owningLoopBlockIndex; ///< The loop this block 'belongs' to (or Invalid if
                                         ///< doesn't belong to a loop)

        Index successorsStart; ///< Indexes into block successors
        Count successorsCount; ///< How many successors
    };

    struct Loop
    {
        const Loop* parentLoop; ///< The parent loop, which will be entered when this loop is left
                                ///< via a break
        BlockIndex targetBlockIndex; ///< The target block for this loop
        BlockIndex breakBlockIndex;  ///< The break block for this loop
        BlockIndex loopBlockIndex;   ///< Block id that terminates with loop we are currently in
    };

    /// Process the module
    void process();

    LivenessContext(IRModule* module, LivenessMode mode)
        : m_module(module), m_livenessMode(mode), m_builder(module)
    {
        // Disable warning if not used
        SLANG_UNUSED(&LivenessContext::_isAnyRunInst);
    }

    /// For a given live range start find it's end/s and insert a LiveRangeEnd/s
    /// Can only be called after a call to _findAliasesAndAccesses for the root.
    void _findAndEmitRangeEnd(IRLiveRangeStart* liveStart);

    /// Process a successor to a block
    /// Can only be called after a call to _findAliasesAndAccesses for the root.
    BlockResult _processSuccessor(BlockIndex blockIndex, const Loop* loop);

    /// Process a block
    /// Can only be called after a call to _findAliasesAndAccesses for the root.
    BlockResult _processBlock(
        BlockIndex blockIndex,
        const ConstArrayView<IRInst*>& run,
        const Loop* loop);

    /// Process all the locations in the function
    /// NOTE: All locations must be to the same function, and ordered by root.
    void _processFunction(IRFunc* func);

    /// Process a root
    /// NOTE: All starts must be to the same root/referenced item
    void _processRoot(IRLiveRangeStart* const* starts, Count count);

    /// Find all the aliases and accesses to the root
    /// The information is stored in m_accessSet and m_aliases
    void _findAliasesAndAccesses(IRInst* root);

    /// Add a result for the block
    /// Allows for promotion if there is already a result
    BlockResult _addBlockResult(BlockIndex blockIndex, BlockResult result);

    /// Find the runs of 'important instructions' all of the blocks
    /// 'important instructions are root starts, and accesses to the root
    /// The run stores these instructions in the order they appear in the block within the run.
    void _findInstRunsForBlocks();

    /// Adds an instruction that is an access to the root
    void _addAccessInst(IRInst* inst);
    /// Add a live range start
    void _addStartInst(IRLiveRangeStart* inst) { _addInst(inst); }
    /// Add an 'important instruction' that is significant for liveness tracking and so will be
    /// added to run
    void _addInst(IRInst* inst);

    /// True if it's an instruction of interest and so will go within a run for a block
    bool _isNormalRunInst(IRInst* inst);

    /// Returns true if is a normal run inst, or if is a return that accesses
    bool _isAnyRunInst(IRInst* inst);

    // Returns the index in the run of a start for the current root, else -1
    Index _indexOfRootStart(const ConstArrayView<IRInst*>& run);

    /// Returns the last index within the run which is a load-like access, else -1
    Index _findLastLoadLike(const ConstArrayView<IRInst*>& run);

    /// Adds an LiveRangeEnd for the root after `inst` if there isn't one there already
    void _maybeAddEndAfterInst(IRInst* inst);

    void _maybeAddEndBeforeInst(IRInst* inst);

    /// Maybe insert an end after the instruction
    void _maybeAddEndAfterRunIndex(
        BlockIndex blockIndex,
        const ConstArrayView<IRInst*>& run,
        Index runIndex);

    // Add a live end instruction at the start of block, referencing the root
    void _maybeAddEndAtBlockStart(BlockIndex blockIndex);

    /// Look from inst for an LiveEndRange to the root.
    IRInst* _findRootEnd(IRInst* inst);

    /// Complete the block using the run, which can *cannot* contain the current root start
    BlockResult _completeBlock(BlockIndex blockIndex, const ConstArrayView<IRInst*>& run);

    /// Get block info
    BlockInfo* _getBlockInfo(BlockIndex blockIndex) { return &m_blockInfos[Index(blockIndex)]; }

    /// Get block info fixed across a function being analyzed.
    const FixedBlockInfo& _getFixedBlockInfo(BlockIndex blockIndex) const
    {
        return m_fixedBlockInfos[Index(blockIndex)];
    }

    /// Get the block from the index
    IRBlock* _getBlock(BlockIndex blockIndex) const
    {
        return m_fixedBlockInfos[Index(blockIndex)].block;
    }

    /// True if the terminator can be considered an access
    /// This allows us to elide a scope end if the root is returned
    bool _isAccessTerminator(IRTerminatorInst* terminator);

    /// Order the range starts in a deterministic manner
    void _orderRangeStartsDeterministically();

    /// Remove any end/start spands within a block, that aren't 'interesting.
    void _tidyUninterestingSpans();

    /// Gets the instructions of interest for this info, in the order they appear within the block
    ConstArrayView<IRInst*> _getRun(const BlockInfo* info)
    {
        IRInst* const* buffer = m_instRuns.getBuffer();
        return ConstArrayView<IRInst*>(buffer + info->runStart, info->runCount);
    }
    /// Gets all of the successors for the blockIdnex
    ConstArrayView<BlockIndex> _getSuccessors(BlockIndex blockIndex)
    {
        const auto& info = m_fixedBlockInfos[Index(blockIndex)];
        return makeConstArrayView(
            m_blockSuccessors.getBuffer() + info.successorsStart,
            info.successorsCount);
    }

    /// Determine which loops blocks 'belong' to. The owning block is the block that *contains* the
    /// loop instruction as it's terminator.
    void _calcLoopOwnership();

    RefPtr<IRDominatorTree> m_dominatorTree; ///< The dominator tree for the current function

    IRLiveRangeStart* m_rootLiveStart = nullptr; ///< The current live start for the root
    IRBlock* m_rootLiveStartBlock = nullptr;     ///< The current block for the live start

    IRInst* m_root = nullptr;       ///< The current root
    IRBlock* m_rootBlock = nullptr; ///< The block the root is in

    List<BlockResult> m_successorResults; ///< Storage for successor results

    List<IRInst*> m_aliases; ///< A list of instructions that alias to the root

    HashSet<IRInst*> m_accessSet; ///< If instruction is in set it is an `access` indicating it must
                                  ///< be live at least up to this instruction

    Dictionary<IRBlock*, BlockIndex> m_blockIndexMap; ///< Map from a block to a block index
    List<BlockInfo> m_blockInfos; ///< Information about blocks, for the current root
    List<FixedBlockInfo>
        m_fixedBlockInfos;              ///< Information about blocks across the current function
    List<BlockIndex> m_blockSuccessors; ///< Successors for a blocks, accessed via FixedBlockInfo

    List<IRInst*> m_instRuns; ///< Instructions of interest in order. Indexed into via BlockInfo
                              ///< [runStart, runStart + runCount)

    List<IRLiveRangeStart*>
        m_rangeStarts;                 ///< All the starts within a function, ordered by referenced
    List<IRLiveRangeEnd*> m_rangeEnds; ///< All of the ends added

    IRModule* m_module;
    IRBuilder m_builder;

    LivenessMode m_livenessMode;
};

static void _findLiveStarts(IRFunc* funcInst, List<IRLiveRangeStart*>& ioStarts)
{
    // If it has no body, then we are done
    if (funcInst->getFirstBlock() == nullptr)
    {
        return;
    }

    // Iterate through blocks looking for start
    for (auto block = funcInst->getFirstBlock(); block; block = block->getNextBlock())
    {
        for (auto inst = block->getFirstChild(); inst; inst = inst->getNextInst())
        {
            // We look for LiveRangeStarts
            if (auto rangeStartInst = as<IRLiveRangeStart>(inst))
            {
                ioStarts.add(rangeStartInst);
            }
        }
    }
}

static void _findFuncs(IRModule* module, List<IRFunc*>& ioFuncs)
{
    IRModuleInst* moduleInst = module->getModuleInst();
    for (IRInst* child : moduleInst->getChildren())
    {
        // If we find a function add it to the list
        if (auto funcInst = as<IRFunc>(child))
        {
            ioFuncs.add(funcInst);
        }
    }
}

void LivenessContext::_maybeAddEndAtBlockStart(BlockIndex blockIndex)
{
    auto block = _getBlock(blockIndex);

    // Insert before the first ordinary inst
    auto inst = block->getFirstOrdinaryInst();
    // A block has to end with a terminator... so must always be an ordinary inst, if there is a
    // function body
    SLANG_ASSERT(inst);
    _maybeAddEndBeforeInst(inst);
}

LivenessContext::BlockResult LivenessContext::_addBlockResult(
    BlockIndex blockIndex,
    BlockResult result)
{
    auto& currentResult = _getBlockInfo(blockIndex)->result;
    // Check we can promote
    SLANG_ASSERT(canPromote(currentResult, result));
    currentResult = result;
    return result;
}

LivenessContext::BlockResult LivenessContext::_processSuccessor(
    BlockIndex blockIndex,
    const Loop* loop)
{
    auto blockInfo = _getBlockInfo(blockIndex);

    // Check if there is already a result for this block.
    // If there is just return that.
    auto result = blockInfo->result;

    switch (result)
    {
    case BlockResult::NotVisited:
        {
            // If not visited we need to process
            break;
        }
    case BlockResult::Visited:
        {
            const auto block = _getBlock(blockIndex);

            // If visited, it can't have a domination issue
            // Unless it is the start block (the block containing live start) *and* the root is
            // in the block.
            // The live start can only be after the var, because the var is only in scope then.

            // We need to check if we are in the live start block, as we then need to process
            // up until the live start.
            if (block == m_rootLiveStartBlock)
            {
                // We want the run to search to go from the start up to *this specific* liveness
                // start (as opposed to any liveness start for the root)
                auto run = _getRun(blockInfo);

                // We need to fix the run to be *after* this specific start
                const Index startIndex = run.indexOf(m_rootLiveStart);
                SLANG_ASSERT(startIndex >= 0);

                // We want to run all the way up to the start
                return _processBlock(blockIndex, run.head(startIndex), loop);
            }

            // If we are looping and branching to the start of the current loop
            if (loop && loop->targetBlockIndex == blockIndex)
            {
                // This block has been visisted, that means it has been traversed to get here
                // meaning the root *must* be live on the looping.

                // TODO(JS):
                // The solution used here is somewhat conservative, it assumes if a branch back to
                // the start of the loop can be reached that
                //
                // * There might be some path where the loop might exit
                // * There might be some path where the root(variable or alias) may be loaded/or
                // stored
                //
                // If these assumptions are wrong it will lead to
                //
                // * Potentially a liveness end that is never hit(outside of the loop)
                // * Potentially liveness for a root that spans across the loop even if that is not
                // actually necessary
                //
                // This could be improved on but would probably need something like 'loop analysis'
                // that specially determined those scenarios, such that the assumptions aren't
                // needed. It would need to be 'separate analysis', because the liveness traversal
                // is a kind of incremental depth first traversal. But for loop analysis it would
                // require at loop start the result on all paths through the loop.

                const auto breakBlockIndex = loop->breakBlockIndex;

                // Process what comes after the loop (in the scope of the parent loop if any)
                result = _processSuccessor(breakBlockIndex, loop->parentLoop);
                if (result != BlockResult::Found)
                {
                    // If an end is not found from the break,
                    // we just insert an end at the start of the break block

                    _maybeAddEndAtBlockStart(breakBlockIndex);
                    result = _addBlockResult(breakBlockIndex, BlockResult::Found);
                }

                return result;
            }

            // Otherwise just return result
            return result;
        }
    default:
        {
            // Otherwise just return result
            return result;
        }
    }

    const auto block = _getBlock(blockIndex);

    // If the block is *not* dominated by the root block, we know it can't
    // end liveness.
    // Return that it is not dominated, and add to the cache for the block
    if (!m_dominatorTree->properlyDominates(m_rootBlock, block))
    {
        return _addBlockResult(blockIndex, BlockResult::NotDominated);
    }

    // Mark that it is visited
    _addBlockResult(blockIndex, BlockResult::Visited);

    // Special case leaving the loop.
    // If we are in a loop, and the block we are going to is the break block then we are no longer
    // in this loop
    if (loop && loop->breakBlockIndex == blockIndex)
    {
        // We are in the parent loop
        loop = loop->parentLoop;
    }

    // Else process the block to try and find the last used instruction
    return _processBlock(blockIndex, _getRun(blockInfo), loop);
}

Index LivenessContext::_indexOfRootStart(const ConstArrayView<IRInst*>& run)
{
    const Count count = run.getCount();
    for (Index i = 0; i < count; ++i)
    {
        if (auto liveStart = as<IRLiveRangeStart>(run[i]))
        {
            if (liveStart->getReferenced() == m_root)
            {
                return i;
            }
        }
    }
    return -1;
}

Index LivenessContext::_findLastLoadLike(const ConstArrayView<IRInst*>& run)
{
    for (Index i = run.getCount() - 1; i >= 0; --i)
    {
        auto inst = run[i];

        const auto op = inst->getOp();
        if (op != kIROp_LiveRangeStart && op != kIROp_Store)
        {
            // Must be 'load like then'
            SLANG_ASSERT(_isAnyRunInst(inst));
            return i;
        }
    }
    return -1;
}

IRInst* LivenessContext::_findRootEnd(IRInst* inst)
{
    for (auto cur = inst; cur; cur = cur->getNextInst())
    {
        IRLiveRangeEnd* end = as<IRLiveRangeEnd>(cur);
        if (end == nullptr)
        {
            break;
        }

        // If we hit an end which is already the root, then we don't need to add an
        // end of the root
        if (end->getReferenced() == m_root)
        {
            return cur;
        }
    }

    return nullptr;
}

void LivenessContext::_maybeAddEndAfterRunIndex(
    BlockIndex blockIndex,
    const ConstArrayView<IRInst*>& run,
    Index runIndex)
{
    SLANG_UNUSED(blockIndex);
    return _maybeAddEndAfterInst(run[runIndex]);
}

void LivenessContext::_maybeAddEndAfterInst(IRInst* inst)
{
    // We can't add after the inst, if it's a terminator
    // or if we find an end.
    if (as<IRTerminatorInst>(inst) == nullptr && !_findRootEnd(inst->getNextInst()))
    {
        // Just add end of scope after the inst
        m_builder.setInsertLoc(IRInsertLoc::after(inst));
        // Add the live end inst
        m_rangeEnds.add(m_builder.emitLiveRangeEnd(m_root));
    }
}

void LivenessContext::_maybeAddEndBeforeInst(IRInst* inst)
{
    if (!_findRootEnd(inst))
    {
        // Just add end of scope after the inst
        m_builder.setInsertLoc(IRInsertLoc::before(inst));
        // Add the live end inst
        m_rangeEnds.add(m_builder.emitLiveRangeEnd(m_root));
    }
}

LivenessContext::BlockResult LivenessContext::_completeBlock(
    BlockIndex blockIndex,
    const ConstArrayView<IRInst*>& run)
{
    // We can't have a root start in the run!
    SLANG_ASSERT(_indexOfRootStart(run) < 0);

    // Look for the last load like access
    const auto lastLoadLikeIndex = _findLastLoadLike(run);

    // If we found one, that is the end of the range
    if (lastLoadLikeIndex >= 0)
    {
        _maybeAddEndAfterRunIndex(blockIndex, run, lastLoadLikeIndex);

        // Add the result
        return _addBlockResult(blockIndex, BlockResult::Found);
    }

    // We didn't find anything, so mark as not found
    return _addBlockResult(blockIndex, BlockResult::NotFound);
}

static IRLoop* _getLoopTerminator(IRBlock* block)
{
    auto terminator = block->getTerminator();
    if (terminator->getOp() == kIROp_Loop)
    {
        return static_cast<IRLoop*>(terminator);
    }
    return nullptr;
}

LivenessContext::BlockResult LivenessContext::_processBlock(
    BlockIndex blockIndex,
    const ConstArrayView<IRInst*>& run,
    const Loop* loop)
{
    // Note that the run must be some part of the run for the block indicated by blockIndex. One of
    //
    // * If root start block - before the start (if accessed via successor)
    // * If root start block - after the start (if accessed initially in search)
    // * Otherwise the whole run for the block
    //
    // Since this is the case, we know start is not part of the run
    SLANG_ASSERT(run.indexOf(m_rootLiveStart) < 0);

    // If there is *another* start to the same root, we can't traverse to other blocks, and the last
    // access in this block must be the result
    {
        // NOTE! We shouldn't/can't use run.indexOf here, because we are looking for *any* start to
        // the root _indexOfRootStart does this search. Moreover we know (it's a condition on run
        // passed into this function) run cannot contain the root start.
        const Index startIndex = _indexOfRootStart(run);
        if (startIndex >= 0)
        {
            // Complete the block with this run
            return _completeBlock(blockIndex, run.head(startIndex));
        }
    }

    // Find all the successors for this block
    auto successors = _getSuccessors(blockIndex);

    const Index successorCount = successors.getCount();

    // NOTE! Care is needed around successorResults, because _processorSuccessor may cause the
    // underlying list to be reallocated. If we always access through successorResults (ie
    // RAIIStackArray type), things will be fine though.

    // Set up space to store successor results
    RAIIStackArray<BlockResult> successorResults(&m_successorResults);
    successorResults.setCount(successorCount);

    // If we hit a loop add the information and make this the current loop info
    {
        const auto& fixedInfo = _getFixedBlockInfo(blockIndex);
        if (fixedInfo.isLoopStart())
        {
            SLANG_ASSERT(_getLoopTerminator(fixedInfo.block));

            Loop nextLoop;
            nextLoop.parentLoop = loop;
            nextLoop.breakBlockIndex = fixedInfo.breakBlockIndex;
            nextLoop.targetBlockIndex = fixedInfo.targetBlockIndex;
            nextLoop.loopBlockIndex = blockIndex;

            for (Index i = 0; i < successorCount; ++i)
            {
                const auto result = _processSuccessor(successors[i], &nextLoop);
                successorResults[i] = result;
            }
        }
        else
        {
            for (Index i = 0; i < successorCount; ++i)
            {
                const auto result = _processSuccessor(successors[i], loop);
                successorResults[i] = result;
            }
        }
    }

    // Zero initialize all the counts
    Index foundCounts[Index(BlockResult::CountOf)] = {0};
    for (const auto successorResult : successorResults.getConstView())
    {
        // Change counts depending on the result
        foundCounts[Index(successorResult)]++;
    }

    const Index foundCount = foundCounts[Index(BlockResult::Found)];
    const Index notFoundCount = foundCounts[Index(BlockResult::NotFound)];

    const Index otherCount = successorCount - (foundCount + notFoundCount);

    // If one or more of the successors (or successors of successors),
    // was found to have the last access, we need to mark the end of scope
    // at the start of any other paths (which are dominated).
    if (foundCount > 0)
    {
        // If all successors have result, or are not dominated
        if (foundCount + otherCount == successorCount)
        {
            return _addBlockResult(blockIndex, BlockResult::Found);
        }

        auto successorResultsView = successorResults.getConstView();

        for (Index i = 0; i < successorCount; ++i)
        {
            const auto successorResult = successorResultsView[i];

            if (successorResult == BlockResult::NotFound)
            {
                const auto successorBlockIndex = successors[i];
                _maybeAddEndAtBlockStart(successorBlockIndex);
                _addBlockResult(successorBlockIndex, BlockResult::Found);
            }
        }

        // This block, can now be marked as found
        return _addBlockResult(blockIndex, BlockResult::Found);
    }

    return _completeBlock(blockIndex, run);
}

void LivenessContext::_addInst(IRInst* inst)
{
    // Get the block it's in
    auto block = as<IRBlock>(inst->getParent());

    // Get the index to get the info
    const BlockIndex blockIndex = m_blockIndexMap[block];

    auto blockInfo = _getBlockInfo(blockIndex);

    // Increase the count
    ++blockInfo->instCount;

    // Record that this is an instruction of interest for this block
    //
    // This only really exists to capture the scenario of only having one inst in a block, so we can
    // just overwrite what's already there.
    blockInfo->lastInst = inst;
}

void LivenessContext::_addAccessInst(IRInst* inst)
{
    // If we already have it don't need to add again
    if (m_accessSet.contains(inst))
    {
        return;
    }

    // Add to the access set
    m_accessSet.add(inst);

    // Add the instruction to the block info
    _addInst(inst);
}

void LivenessContext::_findAliasesAndAccesses(IRInst* root)
{
    // Clear all the aliases
    m_aliases.clear();
    // Clear the access set
    m_accessSet.clear();

    // Add the root to the list of aliases, to start lookup
    m_aliases.add(root);

    // The challenge here is to try and determine when a root is no longer accessed, and so is no
    // longer live
    //
    // Note that a root can be accessed directly, but also through `aliases`. For example if the
    // root is a structure, a pointer to a field in the root would be an alias.
    //
    // In terms of liveness, the only accesses that are important are loads. This is because if the
    // last operation on a root/alias is a store, if it is never read it will never be seen, so in
    // effect doesn't matter.
    //
    // The algorithm here works as follows
    // 0) Prior to this function, a dominator tree is built for the function
    //    This is usefuly because variables defined in block A, is only accessible to blocks
    //    *dominated* by A
    // 1) Deterime all of the aliases, and accesses to the root
    //    Add all the access instructions into m_accessSet
    //    Add all the aliases to m_aliases

    for (Index i = 0; i < m_aliases.getCount(); ++i)
    {
        IRInst* alias = m_aliases[i];

        // Find all the uses of this alias/root
        for (IRUse* use = alias->firstUse; use; use = use->nextUse)
        {
            IRInst* cur = use->getUser();
            IRInst* base = nullptr;

            IRBlock* block = as<IRBlock>(cur->getParent());
            if (!block)
            {
                continue;
            }

            AccessType accessType = AccessType::None;

            // We want to find instructions that access the root
            switch (cur->getOp())
            {
            case kIROp_GetElementPtr:
                {
                    base = static_cast<IRGetElementPtr*>(cur)->getBase();
                    accessType = AccessType::Alias;
                    break;
                }
            case kIROp_FieldAddress:
                {
                    base = static_cast<IRFieldAddress*>(cur)->getBase();
                    accessType = AccessType::Alias;
                    break;
                }
            case kIROp_GetAddress:
                {
                    IRGetAddress* getAddr = static_cast<IRGetAddress*>(cur);
                    base = getAddr->getOperand(0);
                    accessType = AccessType::Alias;
                    break;
                }
            case kIROp_Call:
                {
                    // TODO(JS): This is arguably too conservative.
                    //
                    // Depending on how the parameter is used - in, out, inout changes the
                    // interpretation
                    //
                    // *If we are talking about a real "pointer" then this is basically the general
                    // case again.
                    //     the callee  could store  the pointer into a global, dictionary, whatever.
                    //
                    // * If we are talking about an "address", then this is constrained by our
                    // language rules,
                    //    and we kind of need to find the type of the matching parameter :
                    //   * If the parameter is an `out` parameter, this is basically like a `store`
                    //   * If the parameter is an `inout` parameter, this is basically like a `load`

                    // We can assume it accesses the base
                    base = alias;
                    accessType = AccessType::Access;
                    break;
                }
            case kIROp_Load:
                {
                    // We normally only care about loads in terms of identifying liveness within a
                    // block the last load being the last necessay live point.
                    base = static_cast<IRLoad*>(cur)->getPtr();
                    accessType = AccessType::Access;
                    break;
                }
            case kIROp_Store:
                {
                    // We need stores for loop analysis
                    base = static_cast<IRStore*>(cur)->getPtr();
                    accessType = AccessType::Access;
                    break;
                }
            case kIROp_GetElement:
            case kIROp_FieldExtract:
                {
                    // These will never take place on the var which is accessed through a pointer,
                    // so can be ignored
                    break;
                }

            default:
                break;
            }

            // Make sure the access is through the alias (as opposed to some other part of the
            // instructions 'use')
            if (base == alias)
            {
                switch (accessType)
                {
                case AccessType::Alias:
                    {
                        // Add this instruction to the aliases
                        m_aliases.add(cur);
                        break;
                    }
                case AccessType::Access:
                    {
                        _addAccessInst(cur);
                        break;
                    }
                default:
                    break;
                }
            }
        }
    }
}

void LivenessContext::_findAndEmitRangeEnd(IRLiveRangeStart* liveRangeStart)
{
    // Reset the result
    for (auto& blockInfo : m_blockInfos)
    {
        blockInfo.resetForStart();
    }

    // Store root information, so don't have to pass around methods
    m_rootLiveStart = liveRangeStart;
    m_rootLiveStartBlock = as<IRBlock>(liveRangeStart->getParent());

    // If either of these asserts fail it probably means there hasn't been a call
    // to `_findAliasesAndAccesses` which is required before this function can be called.
    //
    // There must be at least one alias (the root itself!)
    SLANG_ASSERT(m_aliases.getCount() > 0);
    // The first alias should be the root itself
    SLANG_ASSERT(m_aliases[0] == m_root);

    // Now we want to find the last access in the graph of successors
    //
    // This works by recursively starting from the block where the variable is defined, walking
    // depth first the graph of successors. We cache the results in m_blockResults
    //
    // There is an extra caveat around the dominator tree. In principal a variable in block A is
    // accessible by any block that is dominated by A. It's actually more restricted than this -
    // because IR has other rules that provide more tight scoping. The extra information can be seen
    // in a loop instruction also indicating the break and continue blocks.
    //
    // If we just traversed the successors, if there is a loop we'd end up in an infinite loop. We
    // can partly avoid this because we know that the root is only available in blocks dominated by
    // the root. There is also the scenario where there is a loop in blocks within the dominator
    // tree. That is handled by marking 'Visited' when a final result isn't known, but we want to
    // detect a loop. In most respect Visited behaves in the same manner as NotDominated.

    {
        const BlockIndex rootStartBlockIndex = m_blockIndexMap[m_rootLiveStartBlock];
        auto blockInfo = _getBlockInfo(rootStartBlockIndex);
        auto run = _getRun(blockInfo);

        // The run *must* contain this specific start start
        const auto startIndex = run.indexOf(m_rootLiveStart);
        SLANG_ASSERT(startIndex >= 0);

        // Make run scanning start *after* the start
        run = run.tail(startIndex + 1);

        // Mark the root as visited to stop an infinite loop
        _addBlockResult(rootStartBlockIndex, BlockResult::Visited);

        // Recursively find results
        auto foundResult = _processBlock(rootStartBlockIndex, run, nullptr);

        if (foundResult == BlockResult::NotFound)
        {
            // Means there is no access to this variable(!)
            // Which means we can end the scope, after the the start scope
            _maybeAddEndAfterInst(m_rootLiveStart);
        }
    }

    // Set back to nullptr for safety
    m_rootLiveStart = nullptr;
    m_rootLiveStartBlock = nullptr;
}

bool LivenessContext::_isNormalRunInst(IRInst* inst)
{
    const auto op = inst->getOp();

    // Detect if it's a range start for the root.
    if (op == kIROp_LiveRangeStart)
    {
        auto start = as<IRLiveRangeStart>(inst);
        return start->getReferenced() == m_root;
    }

    // NOTE!
    // The ops in the list above are the only ops *currently* that indicate an access.
    // Has to be consistent with `_findAliasesAndAccesses`
    if (op == kIROp_Call || op == kIROp_Load || op == kIROp_Store)
    {
        // Just because it's the right type *doesn't* mean it's an access, it has to also
        // be in the access set
        return m_accessSet.contains(inst);
    }

    return false;
}

bool LivenessContext::_isAccessTerminator(IRTerminatorInst* terminator)
{
    // This is to special case when a return, returns a root or an alias
    //
    // We need to detect if the return value accesses the root

    if (terminator->getOp() == kIROp_Return)
    {
        // We are going to special case return if it hits an alias
        auto returnVal = static_cast<IRReturn*>(terminator);

        auto val = returnVal->getVal();

        // TODO(JS): This is perhaps somewhat argable, but it means if
        // we have a cast between uint/int (for example) that isn't a problem

        // Strip construct
        switch (val->getOp())
        {
        case kIROp_CastIntToFloat:
        case kIROp_CastFloatToInt:
        case kIROp_IntCast:
        case kIROp_FloatCast:
        case kIROp_CastIntToPtr:
        case kIROp_CastPtrToInt:
        case kIROp_CastPtrToBool:
        case kIROp_PtrCast:
            val = val->getOperand(0);
            break;
        }

        // If it *is* the root it's an access
        if (val == m_root)
        {
            return true;
        }

        // If it's a load, see what is being loaded from an alias to the root
        if (auto load = as<IRLoad>(val))
        {
            const auto valPtr = load->getPtr();
            return m_aliases.contains(valPtr);
        }
    }

    return false;
}

bool LivenessContext::_isAnyRunInst(IRInst* inst)
{
    if (auto terminator = as<IRTerminatorInst>(inst))
    {
        return _isAccessTerminator(terminator);
    }
    return _isNormalRunInst(inst);
}

void LivenessContext::_findInstRunsForBlocks()
{
    const Count count = m_blockInfos.getCount();
    for (Index i = 0; i < count; ++i)
    {
        const auto blockIndex = BlockIndex(i);

        // Get the block
        auto block = _getBlock(blockIndex);

        // Get the block info
        auto* blockInfo = _getBlockInfo(blockIndex);

        const auto start = m_instRuns.getCount();
        blockInfo->runStart = start;

        if (blockInfo->instCount == 0)
        {
            // Nothing to do if it's empty
            SLANG_ASSERT(blockInfo->runCount == 0);
        }
        else if (blockInfo->instCount == 1)
        {
            // This is the easy case, since we don't need to determine the order of the instructions
            SLANG_ASSERT(blockInfo->lastInst);
            m_instRuns.add(blockInfo->lastInst);
            blockInfo->runCount = 1;
        }
        else
        {
            // TODO(JS):
            // NOTE That we don't need to keep all accesses in the run, only the last accesses
            // prior to a start or end of the block.
            //
            // For now we just add them all.

            blockInfo->runCount = blockInfo->instCount;

            m_instRuns.setCount(start + blockInfo->instCount);
            IRInst** dst = m_instRuns.getBuffer() + start;

            // Find all of the instructions of interest in order
            for (auto inst : block->getChildren())
            {
                if (_isNormalRunInst(inst))
                {
                    *dst++ = inst;
                    if (dst == m_instRuns.end())
                    {
                        break;
                    }
                }
            }
            SLANG_ASSERT(dst == m_instRuns.end());
        }

        SLANG_ASSERT(blockInfo->runCount == blockInfo->instCount);

        // Special case the terminator - we allow a return that accesses the root
        // to be added to the run.
        //
        // TODO(JS): We might want this behavior to be switchable with an option.
        // If we don't add the terminator, everything else will behave correctly with regard
        // adding live range end markers.
        {
            auto terminator = block->getTerminator();
            if (_isAccessTerminator(terminator))
            {
                m_instRuns.add(terminator);
                blockInfo->runCount++;
            }
        }

        SLANG_ASSERT(blockInfo->runStart + blockInfo->runCount == m_instRuns.getCount());

        // The run count must be at least as many as the found instCount
        // There can be more instructions as we allow some special cases (for example around return)
        SLANG_ASSERT(blockInfo->runCount >= blockInfo->instCount);
    }
}

void LivenessContext::_processRoot(IRLiveRangeStart* const* rangeStarts, Count rangeStartsCount)
{
    if (rangeStartsCount <= 0)
    {
        return;
    }

    // Reset the order range for all blocks
    for (auto& info : m_blockInfos)
    {
        info.resetForRoot();
    }
    m_instRuns.clear();

    auto root = rangeStarts[0]->getReferenced();

    // Set the root
    m_root = root;
    m_rootBlock = as<IRBlock>(m_root->parent);

    // Add all the live starts
    for (Index i = 0; i < rangeStartsCount; ++i)
    {
        auto rangeStart = rangeStarts[i];

        // Check it references the same root
        SLANG_ASSERT(rangeStart->getReferenced() == root);

        _addStartInst(rangeStart);
    }

    // Find all of the aliases and access to this root
    _findAliasesAndAccesses(root);

    // Find the runs of 'instructions of interest' (accesses/starts) for all the blocks
    _findInstRunsForBlocks();

    // Now we want to find all of the ends for each start
    for (Index i = 0; i < rangeStartsCount; ++i)
    {
        // We want to process this RangeStart for the root, to find all of the ends
        _findAndEmitRangeEnd(rangeStarts[i]);
    }

    // No root is active in processing
    m_root = nullptr;
    m_rootBlock = nullptr;
}

void LivenessContext::_calcLoopOwnership()
{
    // Should all be set to invalid initially
    for (const auto& fixedInfo : m_fixedBlockInfos)
    {
        // To stop an error when assert isn't defined...
        SLANG_UNUSED(fixedInfo);
        SLANG_ASSERT(fixedInfo.owningLoopBlockIndex == BlockIndex::Invalid);
    }

    const Count blocksCount = m_fixedBlockInfos.getCount();

    List<BlockIndex> work;

    for (Index i = 0; i < blocksCount; ++i)
    {
        const BlockIndex outerBlockIndex = BlockIndex(i);
        const auto& loopInfo = _getFixedBlockInfo(outerBlockIndex);
        if (loopInfo.isLoopStart())
        {
            const BlockIndex loopBlockIndex = outerBlockIndex;

            work.clear();

            BlockIndex blockIndex = loopInfo.targetBlockIndex;

            while (true)
            {
                // If it's already set we are done
                auto& curOwner = m_fixedBlockInfos[Index(blockIndex)].owningLoopBlockIndex;
                if (curOwner != BlockIndex::Invalid)
                {
                    SLANG_ASSERT(curOwner == loopBlockIndex);
                    continue;
                }

                // Set that it belongs to this loop
                curOwner = loopBlockIndex;

                BlockIndex successorStorage[1];
                ConstArrayView<BlockIndex> successors;

                const auto& info = _getFixedBlockInfo(blockIndex);
                if (info.isLoopStart())
                {
                    // The 'successor' is what comes after the loop
                    const BlockIndex breakIndex = info.breakBlockIndex;
                    successorStorage[0] = breakIndex;
                    successors = makeConstArrayView(successorStorage, 1);
                }
                else
                {
                    successors = _getSuccessors(blockIndex);
                }

                // Add any successors that aren't visited or terminators
                for (const auto successorBlockIndex : successors)
                {
                    // If it loops or repeats, we don't need to add
                    if (successorBlockIndex == loopInfo.breakBlockIndex ||
                        successorBlockIndex == loopInfo.targetBlockIndex)
                    {
                        continue;
                    }
                    // Check if already owned (must be by this loop)
                    const auto successorOwner =
                        _getFixedBlockInfo(successorBlockIndex).owningLoopBlockIndex;
                    if (successorOwner != BlockIndex::Invalid)
                    {
                        SLANG_ASSERT(successorOwner == loopBlockIndex);
                        continue;
                    }

                    work.add(successorBlockIndex);
                }

                // If nothing left we are done
                if (work.getCount() == 0)
                {
                    break;
                }

                blockIndex = work.getLast();
                work.removeLast();
            }
        }
    }
}

void LivenessContext::_processFunction(IRFunc* func)
{
    SLANG_ASSERT(m_rangeStarts.getCount() > 0);

    // Create the dominator tree, for the function
    m_dominatorTree = computeDominatorTree(func);

    // We are going to precalculate a variety of things for blocks.
    // Most processing is performed via BlockIndex, so we need to set up a map from the block
    // pointer to the index By having as an index we can easily/quickly associate information with
    // blocks with arrays

    // Set up the map from blocks to indices
    m_blockIndexMap.clear();

    m_blockInfos.clear();
    m_fixedBlockInfos.clear();
    m_blockSuccessors.clear();
    m_rangeEnds.clear();

    {
        // First we find all the blocks in the function, we add to the map
        // and initialize the functionBlockInfos, which hold information about blocks that is
        // constant across a function We will associate successors too, but we can only do this once
        // we have set up the map
        Index index = 0;
        for (auto block : func->getChildren())
        {
            IRBlock* blockInst = as<IRBlock>(block);
            m_blockIndexMap.add(blockInst, BlockIndex(index++));

            FixedBlockInfo fixedBlockInfo;
            fixedBlockInfo.init(blockInst);

            m_fixedBlockInfos.add(fixedBlockInfo);
        }

        // Allocate space for the root block infos
        m_blockInfos.setCount(index);

        // Now we have the map, work out the successors as BlockIndex for each block
        // and add those to m_blockSuccessors. They are indexed via successorsIndex/Count in the
        // FunctionBlockInfos
        for (auto& fixedInfo : m_fixedBlockInfos)
        {
            auto block = fixedInfo.block;

            // Set up the break block indices if we have a loop
            if (auto loop = _getLoopTerminator(block))
            {
                // Set the break/continue block indices
                fixedInfo.breakBlockIndex = m_blockIndexMap[loop->getBreakBlock()];
                fixedInfo.targetBlockIndex = m_blockIndexMap[loop->getTargetBlock()];
            }

            // Add all the successors
            auto successors = block->getSuccessors();

            const Index successorsStart = m_blockSuccessors.getCount();
            const Count successorsCount = successors.getCount();

            fixedInfo.successorsStart = successorsStart;
            fixedInfo.successorsCount = successorsCount;

            m_blockSuccessors.setCount(successorsStart + successorsCount);

            BlockIndex* dst = m_blockSuccessors.getBuffer() + successorsStart;

            for (auto successor : successors)
            {
                *dst++ = m_blockIndexMap[successor];
            }
        }

        // Once we have the successors set up we can determine which loops each block belongs to.
        // This can be useful for doing loop analysis
        _calcLoopOwnership();
    }

    // Find the run of locations that all access the same root
    {
        Index start = 0;
        const Count count = m_rangeStarts.getCount();
        while (start < count)
        {
            // Get the root at the start of this span
            const auto root = m_rangeStarts[start]->getReferenced();

            // Look for the end of the run of locations with the same root
            Index end = start + 1;
            for (; end < count && m_rangeStarts[end]->getReferenced() == root; ++end)
                ;

            // Process the root
            _processRoot(m_rangeStarts.getBuffer() + start, end - start);

            // Set start to the beginning of the next run
            start = end;
        }
    }

    // Remove any end/start spands within a block, that aren't 'interesting.
    _tidyUninterestingSpans();
}

static bool _isRootTypeScalar(IRType* type)
{
    // Liveness range start/end are through ptr type
    if (auto ptrType = as<IRPtrType>(type))
    {
        // Strip the ptr
        type = ptrType->getValueType();
    }
    return as<IRBasicType>(type) != nullptr;
}

void LivenessContext::_tidyUninterestingSpans()
{
    // We are looking for spans from an end to a start for a scalar variable.
    // Only scalar for now so even if the span is 'big' the cost is probably low.
    //
    // A more sophisticated implementation could perhaps look in the span if there is only a full
    // store for a struct/large type. Would also need some concept of the 'amount of insts' to
    // determine if worth it.

    const Count count = m_rangeEnds.getCount();

    for (Index i = 0; i < count; ++i)
    {
        auto end = m_rangeEnds[i];
        auto root = end->getReferenced();

        // If it's not scalar then we ignore
        if (!_isRootTypeScalar(root->getDataType()))
        {
            continue;
        }

        // Look for a start to the same root in the block
        // A more sophisticated implementation might try to look across unconditional branches
        // but since only *one* end is stored for potentially multiple starts, and that a block
        // might have multiple predecessors, we ignore for now.
        IRLiveRangeStart* start = nullptr;
        for (auto cur = end->getNextInst(); cur; cur = cur->getNextInst())
        {
            // If it's a start
            if (auto foundStart = as<IRLiveRangeStart>(cur))
            {
                // and a start to the same root
                if (foundStart->getReferenced() == root)
                {
                    start = foundStart;
                    break;
                }
            }
        }

        // If we found a matching start, lets just remove the span
        if (start)
        {
            m_rangeEnds[i] = nullptr;
            const Index startIndex = m_rangeStarts.indexOf(start);

            SLANG_ASSERT(startIndex >= 0);
            if (startIndex >= 0)
            {
                m_rangeStarts[startIndex] = nullptr;
            }

            // Delete the matching end -> start span
            start->removeAndDeallocate();
            end->removeAndDeallocate();
        }
    }
}

void LivenessContext::_orderRangeStartsDeterministically()
{
    const Index rangeStartsCount = m_rangeStarts.getCount();
    if (rangeStartsCount <= 1)
    {
        // One or less there is no reordering
        return;
    }

    // The fast way is to just order by the roots pointers.
    // Unfortunately that is unstable, as it depends on the allocation location which varies.

    // Sort into referenced/root start
    // m_rangeStarts.sort([&](IRLiveRangeStart* a, IRLiveRangeStart* b) -> bool { return
    // a->getReferenced() < b->getReferenced(); });

    // The order that the starts is *found* is deterministic, so we'll use that as part of the key
    // to sort.

    struct Entry
    {
        IRLiveRangeStart* start;
        Index foundIndex; ///< The found index
        Index rootIndex;  ///< Index for the root
    };

    Int orderCounter = 0;

    Dictionary<IRInst*, Index> rootOrderMap;
    List<Entry> entries;
    entries.setCount(rangeStartsCount);
    for (Index i = 0; i < rangeStartsCount; ++i)
    {
        auto start = m_rangeStarts[i];
        auto root = start->getReferenced();

        Index order = -1;

        if (auto orderPtr = rootOrderMap.tryGetValueOrAdd(root, orderCounter + 1))
        {
            order = *orderPtr;
        }
        else
        {
            order = ++orderCounter;
        }

        Entry& entry = entries[i];
        entry.start = start;
        entry.foundIndex = i;
        entry.rootIndex = order;
    }

    // Sort by the root indices and if equal sort by the found order
    entries.sort(
        [&](const Entry& a, const Entry& b) -> bool
        {
            return (a.rootIndex < b.rootIndex) ||
                   (a.rootIndex == b.rootIndex && a.foundIndex < b.foundIndex);
        });

    // Copy back
    for (Index i = 0; i < rangeStartsCount; ++i)
    {
        m_rangeStarts[i] = entries[i].start;
    }
}

void LivenessContext::process()
{
    // Find all of the funcs in the module
    List<IRFunc*> funcs;
    _findFuncs(m_module, funcs);

    for (auto func : funcs)
    {
        if (func->getFirstBlock() != nullptr)
        {
            m_rangeStarts.clear();
            _findLiveStarts(func, m_rangeStarts);

            if (m_rangeStarts.getCount() > 0)
            {
                // Order the range starts by root deterministically
                _orderRangeStartsDeterministically();

                // Process the function
                _processFunction(func);
            }
        }
    }
}

} // namespace

static void _processFunction(IRFunc* funcInst, List<IRVar*>& ioVars)
{
    // If it has no body, then we are done
    if (funcInst->getFirstBlock() == nullptr)
    {
        return;
    }

    // Iterate through blocks in the function, looking for variables to live track
    for (auto block = funcInst->getFirstBlock(); block; block = block->getNextBlock())
    {
        for (auto inst = block->getFirstChild(); inst; inst = inst->getNextInst())
        {
            // We look for var declarations.
            if (auto varInst = as<IRVar>(inst))
            {
                ioVars.add(varInst);
            }
        }
    }
}

/* static */ void LivenessUtil::addVariableRangeStarts(IRModule* module, LivenessMode livenessMode)
{
    if (!isEnabled(livenessMode))
    {
        return;


context:
space:
mode: