summaryrefslogtreecommitdiffstats
path: root/tests/reflection/ptr
diff options
context:
space:
mode:
authorHarsh Aggarwal (NVIDIA) <haaggarwal@nvidia.com>2025-08-01 14:48:53 +0530
committerGitHub <noreply@github.com>2025-08-01 09:18:53 +0000
commitbdda8a90cdd44ca822b21233ac988f92d1f20826 (patch)
tree4f628776a047b2719aee676287b3adc9d4f68f7a /tests/reflection/ptr
parent7a133445ef82232a6961c25d09b79f45cd92e709 (diff)
Fix 7441: CUDA boolean vector layout to use 1-byte elements (#7862)
* Fix 7441: CUDA boolean vector layout to use 1-byte elements Boolean vectors (bool1, bool2, bool3, bool4) were incorrectly implemented as integer-based types using 4 bytes per element instead of actual 1-byte boolean elements on CUDA targets. Changes: - Update CUDA prelude to define boolean vectors as structs with bool fields instead of typedef aliases to integer vectors - Implement CUDALayoutRulesImpl::GetVectorLayout to use 1-byte alignment for boolean vectors, matching actual CUDA memory layout behavior - Update make_bool functions to populate struct fields correctly This ensures boolean vectors have the same memory layout as bool[4] arrays: - bool1: 1 byte (was 4 bytes) - bool2: 2 bytes (was 8 bytes) - bool3: 3 bytes (was 12 bytes) - bool4: 4 bytes (was 16 bytes) Fixes memory layout mismatch between Slang reflection API and actual CUDA compilation, achieving 75% memory savings for boolean vector usage. * Fix CI issues - Add and update associated functions and operators * Make boolX same as uchar * Use align construct on struct for boolX * Improve Test case for robust alignment checks * Formatting * Disable selected slangpy tests * add metal check which is slightly different than cuda * Test-1 * Test-2 * Test-3 * Test-4 * ReflectionChange * cleanup and update * _slang_select with plain bool is needed for reverse-loop-checkpoint-test
Diffstat (limited to 'tests/reflection/ptr')
-rw-r--r--tests/reflection/ptr/ptr-generic.slang.expected4
-rw-r--r--tests/reflection/ptr/ptr-global.slang.expected10
-rw-r--r--tests/reflection/ptr/ptr-self-reference.slang.expected8
-rw-r--r--tests/reflection/ptr/ptr-struct.slang.expected20
4 files changed, 21 insertions, 21 deletions
diff --git a/tests/reflection/ptr/ptr-generic.slang.expected b/tests/reflection/ptr/ptr-generic.slang.expected
index e2473db42..1a4c8acfa 100644
--- a/tests/reflection/ptr/ptr-generic.slang.expected
+++ b/tests/reflection/ptr/ptr-generic.slang.expected
@@ -6,7 +6,7 @@ standard output = {
"parameters": [
{
"name": "genericPtr",
- "binding": {"kind": "uniform", "offset": 0, "size": 8},
+ "binding": {"kind": "uniform", "offset": 0, "size": 8, "elementStride": 0},
"type": {
"kind": "pointer",
"valueType": "GenericStruct"
@@ -14,7 +14,7 @@ standard output = {
},
{
"name": "outputBuffer",
- "binding": {"kind": "uniform", "offset": 8, "size": 16},
+ "binding": {"kind": "uniform", "offset": 8, "size": 16, "elementStride": 0},
"type": {
"kind": "resource",
"baseShape": "structuredBuffer",
diff --git a/tests/reflection/ptr/ptr-global.slang.expected b/tests/reflection/ptr/ptr-global.slang.expected
index 1a6c15a7e..d040027d5 100644
--- a/tests/reflection/ptr/ptr-global.slang.expected
+++ b/tests/reflection/ptr/ptr-global.slang.expected
@@ -6,7 +6,7 @@ standard output = {
"parameters": [
{
"name": "inputBuffer",
- "binding": {"kind": "uniform", "offset": 0, "size": 16},
+ "binding": {"kind": "uniform", "offset": 0, "size": 16, "elementStride": 0},
"type": {
"kind": "resource",
"baseShape": "structuredBuffer",
@@ -21,7 +21,7 @@ standard output = {
"kind": "pointer",
"valueType": "int"
},
- "binding": {"kind": "uniform", "offset": 0, "size": 8}
+ "binding": {"kind": "uniform", "offset": 0, "size": 8, "elementStride": 0}
},
{
"name": "regularGlobal2",
@@ -29,7 +29,7 @@ standard output = {
"kind": "pointer",
"valueType": "int"
},
- "binding": {"kind": "uniform", "offset": 8, "size": 8}
+ "binding": {"kind": "uniform", "offset": 8, "size": 8, "elementStride": 0}
},
{
"name": "regularGlobal3",
@@ -37,7 +37,7 @@ standard output = {
"kind": "scalar",
"scalarType": "int32"
},
- "binding": {"kind": "uniform", "offset": 16, "size": 4}
+ "binding": {"kind": "uniform", "offset": 16, "size": 4, "elementStride": 0}
}
]
}
@@ -45,7 +45,7 @@ standard output = {
},
{
"name": "outputBuffer",
- "binding": {"kind": "uniform", "offset": 16, "size": 16},
+ "binding": {"kind": "uniform", "offset": 16, "size": 16, "elementStride": 0},
"type": {
"kind": "resource",
"baseShape": "structuredBuffer",
diff --git a/tests/reflection/ptr/ptr-self-reference.slang.expected b/tests/reflection/ptr/ptr-self-reference.slang.expected
index 81745fb20..ed704579f 100644
--- a/tests/reflection/ptr/ptr-self-reference.slang.expected
+++ b/tests/reflection/ptr/ptr-self-reference.slang.expected
@@ -6,7 +6,7 @@ standard output = {
"parameters": [
{
"name": "inputBuffer",
- "binding": {"kind": "uniform", "offset": 0, "size": 16},
+ "binding": {"kind": "uniform", "offset": 0, "size": 16, "elementStride": 0},
"type": {
"kind": "resource",
"baseShape": "structuredBuffer",
@@ -21,7 +21,7 @@ standard output = {
"kind": "scalar",
"scalarType": "int32"
},
- "binding": {"kind": "uniform", "offset": 0, "size": 4}
+ "binding": {"kind": "uniform", "offset": 0, "size": 4, "elementStride": 0}
},
{
"name": "next",
@@ -29,7 +29,7 @@ standard output = {
"kind": "pointer",
"valueType": "SomeStruct"
},
- "binding": {"kind": "uniform", "offset": 8, "size": 8}
+ "binding": {"kind": "uniform", "offset": 8, "size": 8, "elementStride": 0}
}
]
}
@@ -37,7 +37,7 @@ standard output = {
},
{
"name": "outputBuffer",
- "binding": {"kind": "uniform", "offset": 16, "size": 16},
+ "binding": {"kind": "uniform", "offset": 16, "size": 16, "elementStride": 0},
"type": {
"kind": "resource",
"baseShape": "structuredBuffer",
diff --git a/tests/reflection/ptr/ptr-struct.slang.expected b/tests/reflection/ptr/ptr-struct.slang.expected
index 3ae17416c..71e495dd7 100644
--- a/tests/reflection/ptr/ptr-struct.slang.expected
+++ b/tests/reflection/ptr/ptr-struct.slang.expected
@@ -6,7 +6,7 @@ standard output = {
"parameters": [
{
"name": "inputBuffer",
- "binding": {"kind": "uniform", "offset": 0, "size": 16},
+ "binding": {"kind": "uniform", "offset": 0, "size": 16, "elementStride": 0},
"type": {
"kind": "resource",
"baseShape": "structuredBuffer",
@@ -21,7 +21,7 @@ standard output = {
"kind": "pointer",
"valueType": "int"
},
- "binding": {"kind": "uniform", "offset": 0, "size": 8}
+ "binding": {"kind": "uniform", "offset": 0, "size": 8, "elementStride": 0}
},
{
"name": "ptrInt2",
@@ -29,7 +29,7 @@ standard output = {
"kind": "pointer",
"valueType": "int"
},
- "binding": {"kind": "uniform", "offset": 8, "size": 8}
+ "binding": {"kind": "uniform", "offset": 8, "size": 8, "elementStride": 0}
},
{
"name": "anInt",
@@ -37,7 +37,7 @@ standard output = {
"kind": "scalar",
"scalarType": "int32"
},
- "binding": {"kind": "uniform", "offset": 16, "size": 4}
+ "binding": {"kind": "uniform", "offset": 16, "size": 4, "elementStride": 0}
},
{
"name": "another",
@@ -51,7 +51,7 @@ standard output = {
"kind": "scalar",
"scalarType": "float32"
},
- "binding": {"kind": "uniform", "offset": 0, "size": 4}
+ "binding": {"kind": "uniform", "offset": 0, "size": 4, "elementStride": 0}
},
{
"name": "b",
@@ -59,7 +59,7 @@ standard output = {
"kind": "scalar",
"scalarType": "int32"
},
- "binding": {"kind": "uniform", "offset": 4, "size": 4}
+ "binding": {"kind": "uniform", "offset": 4, "size": 4, "elementStride": 0}
},
{
"name": "ptrC",
@@ -67,11 +67,11 @@ standard output = {
"kind": "pointer",
"valueType": "int"
},
- "binding": {"kind": "uniform", "offset": 8, "size": 8}
+ "binding": {"kind": "uniform", "offset": 8, "size": 8, "elementStride": 0}
}
]
},
- "binding": {"kind": "uniform", "offset": 24, "size": 16}
+ "binding": {"kind": "uniform", "offset": 24, "size": 16, "elementStride": 0}
},
{
"name": "anotherPtr",
@@ -79,7 +79,7 @@ standard output = {
"kind": "pointer",
"valueType": "AnotherStruct"
},
- "binding": {"kind": "uniform", "offset": 40, "size": 8}
+ "binding": {"kind": "uniform", "offset": 40, "size": 8, "elementStride": 0}
}
]
}
@@ -87,7 +87,7 @@ standard output = {
},
{
"name": "outputBuffer",
- "binding": {"kind": "uniform", "offset": 16, "size": 16},
+ "binding": {"kind": "uniform", "offset": 16, "size": 16, "elementStride": 0},
"type": {
"kind": "resource",
"baseShape": "structuredBuffer",