diff options
| author | ArielG-NV <159081215+ArielG-NV@users.noreply.github.com> | 2025-08-29 15:52:34 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-08-29 22:52:34 +0000 |
| commit | 7758625d3fea67e55e98e7e4103d56c9918365be (patch) | |
| tree | 2ed40aeb4d16262866e5540dad1a519951b5f772 /tests/language-feature/pointer/const-ptr-variations.slang | |
| parent | 450ef7934c1adfdf4a3a3c72967de3c5798a020d (diff) | |
[CBP] Pointer frontend changes + groupshared pointer support (#7848)
Resolves #7628
Resolves: #8197
Primary Goals:
1. Add `Access` to pointer
2. AddressSpace::GroupShared support for pointers (SPIR-V)
3. Add `__getAddress()` to replace `&`
* `&` is not updated to `require(cpu)` since slangpy uses `&`. This
means we must: (1) merge PR; (2) replace `&` with `__getAddress()`; (3)
add `require(cpu)` to `&`
Changes:
* Added to `Ptr` the `Access` generic argument & logic (for
`Access::Read`).
* Moved the generic argument `AddressSpace` from `Ptr` to the end of the
type.
* Added pointer casting support between any `Ptr` as long as the
`AddressSpace` is the same
* Disallow globallycoherent T* and coherent T*
* Disallow const T*, T const*, and const T*
* Fixed .natvis display of `ConstantValue` `ValOperandNode`
* Support generic resolution of type-casted integers
* Added `VariablePointer` emitting for spirv + other minor logic needed
for groupshared pointers
Breaking Changes:
* Anyone using the `AddressSpace` of `Ptr` will now have to account for
the `Access` argument
* we disallow various syntax paired with `Ptr` and `T*`
---------
Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com>
Diffstat (limited to 'tests/language-feature/pointer/const-ptr-variations.slang')
| -rw-r--r-- | tests/language-feature/pointer/const-ptr-variations.slang | 40 |
1 files changed, 40 insertions, 0 deletions
diff --git a/tests/language-feature/pointer/const-ptr-variations.slang b/tests/language-feature/pointer/const-ptr-variations.slang new file mode 100644 index 000000000..a2619d6c4 --- /dev/null +++ b/tests/language-feature/pointer/const-ptr-variations.slang @@ -0,0 +1,40 @@ +//TEST:SIMPLE(filecheck=CHECK_1):-stage compute -entry computeMain -target spirv -DT1 +//TEST:SIMPLE(filecheck=CHECK_2):-stage compute -entry computeMain -target spirv -DT2 +//TEST:SIMPLE(filecheck=CHECK_3):-stage compute -entry computeMain -target spirv -DT3 +//TEST:SIMPLE(filecheck=CHECK_4):-stage compute -entry computeMain -target spirv -DT4 + +// Tests for invalid use of `const` with Ptr/T* +// Due to bad syntax breaking the parser, it is more robust to use disjoint tests with +// #define's. +cbuffer Globals +{ + int* ptr; +} + +[numthreads(1, 1, 1)] +void computeMain(int id : SV_DispatchThreadID) +{ + // disallowed syntax with modifier `const` +#ifdef T1 + // CHECK_1: ([[# @LINE+1]]): error + int const* ptr1 = ptr; +#endif + +#ifdef T2 + // CHECK_2: ([[# @LINE+1]]): error + int* const ptr2 = ptr; +#endif + +#ifdef T3 + // CHECK_3: ([[# @LINE+1]]): error 20017 + const int* ptr3 = ptr; + // CHECK_3: ([[# @LINE+1]]): error 20018 + Ptr<const int> ptr4 = ptr; +#endif + +#ifdef T4 + // CHECK_4: OpEntryPoint + // CHECK_4-NOT: error + const Ptr<int> ptr5 = ptr; +#endif +}
\ No newline at end of file |
