diff options
| author | Tim Foley <tfoleyNV@users.noreply.github.com> | 2021-04-01 16:15:09 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-04-01 16:15:09 -0700 |
| commit | 0ec8e5b016e56ad491a418ab72a5be28dd83f3b4 (patch) | |
| tree | e7934e78346cd63a4d944e68dc90fcafebc40d42 /tests/disabled-tests.txt | |
| parent | 9475b11045089c9bc9773b16f7eb84f843db70c4 (diff) | |
Refactor D3D12 renderer root signature creation (#1779)
This change originated as an attempt to re-enable a test case, but it has ended up disabling more tests (for good reasons) than it re-enables.
The main change here is a significant overhaul of the way that the D3D12 render path extracts information from the Slang reflection API to produce a root signature.
There were also some supporting fixes in the reflection information to make sure it returns what the D3D12 back-end needed.
The big picture here is that the D3D12 path now uses the descriptor ranges stored in the reflection data more or less directly.
It still needs to use register/space offset information queried via the "old" reflection API, but it only does so at the top level now, for the program and entry points themselves.
All other layout information is derived directly from what Slang provides.
Smaller changes:
* The "flat" reflection API was expanded to include `getBindingRangeDescriptorRangeCount()` which was clearly missing.
* The "flat" reflection results for a constant buffer or parameter block that didn't contain any uniform data and was mapped to a plain constant buffer needed to be fixed up. That logic is still way to subtle to be trusted.
* Several additional tests were disabled that relied on static specialization, global/entry-point generi type parameters, structured buffers of interfaces or other features we don't officially support with shader objects right now. All of the affected tests were somehow passing by sheer luck and because they often passed in specialization arguments via explicit `TEST_INPUT` lines.
* The `inteface-shader-param` test is re-enabled now that we can properly describe its input with the new `set` mode on `TEST_INPUT`
* `ShaderCursor::getElement()` can now be used on structure types (in addition to arrays) to support by-index access to fields
* The `TEST_INPUT` system was expanded to support both by-name and by-index setting of structure fields for aggregates
* The `TEST_INPUT` system was expanded to allow an `out` prefix to mark parts of an expression as outputs on a `set` lines
* The `TEST_INPUT` system was expanded so that anything that would be allowed on a `TEST_INPUT` line by itself (like `ubuffer(...)`) can now be used as a sub-expression on a `set` line
Co-authored-by: Yong He <yonghe@outlook.com>
Diffstat (limited to 'tests/disabled-tests.txt')
| -rw-r--r-- | tests/disabled-tests.txt | 41 |
1 files changed, 39 insertions, 2 deletions
diff --git a/tests/disabled-tests.txt b/tests/disabled-tests.txt index ffc9736db..ea1a2330e 100644 --- a/tests/disabled-tests.txt +++ b/tests/disabled-tests.txt @@ -9,15 +9,53 @@ Test that don't work with shader objects in render-test The following tests were disabled because they had been running on non `-shaderobj` code paths that have since been removed. These tests will need to be re-enabled together with changes to the shader object implementation, or removed entirely if they no longer test useful functionality. +### `ConstantBuffer<ISomething>` + +These tests rely on details of how a `ConstantBuffer<ISomething>` or `ParameterBlock<ISomething>` gets laid out. +We need to fix the compiler and shader object implementation to agree that a `ConstantBuffer<ISomething>` +should compile as `exists T : ISomething . ConstantBuffer<T>` and *not* `ConstantBuffer<exists T : ISomething . T>` +like it currently does. +(The reason for this choice is that we want a shader object created from `SomeConcreteType`, where `SomeConcreteType : ISomething`, to be directly usable for a `ConstantBuffer<ISomething>` parameter with its existing buffer allocation.) + * compute/dynamic-dispatch-12.slang + +### `StructuredBuffer<ISomething>` + +These tests require support for structured buffers where the element type either is an interface type or transitively contains one. + * compute/dynamic-dispatch-13.slang * compute/dynamic-dispatch-14.slang * compute/dynamic-dispatch-bindless-texture.slang -* compute/global-type-param2.slang +* compute/interface-func-param-in-struct.slang +* compute/interface-assoc-type-param.slang + +### Generic Specialization Parameters + +These tests make use of generic specialization parameters in ways that don't easily align with the implementation approach that is more focused on existential parameters. +They should either be ported to use existentials directly (at which point we potentially get rid of support for generic specialization at global or entry-point scope?) or we should refine the implementation of generic specialization to be consistent with existential specialization. + * compute/global-type-param-array.slang * compute/global-type-param1.slang +* compute/global-type-param2.slang +* bugs/gh-357.slang +* compute/assoctype-generic-arg.slang +* compute/global-generic-value-param.slang +* compute/global-type-param-in-entrypoint.slang +* compute/global-type-param.slang +* compute/int-generic.slang + +### Static Specialization + +These tests rely on the ability of the static specialization path to provide locations for data that doesn't "fit" into the fixed-size payload of an existential-type field/value. +They will need to wait until the shader object implementation(s) are updated to support that case. + * compute/interface-shader-param-in-struct.slang * compute/interface-shader-param-legalization.slang + +### Uncategorized + +These tests need to be binned according to what features they need. + * compute/interface-shader-param.slang * compute/performance-profile.slang * compute/rewriter-parameter-block-complex.hlsl @@ -40,4 +78,3 @@ These tests will need to be re-enabled together with changes to the shader objec * render/tess.hlsl * render/unused-discard.hlsl * compute/interface-param-partial-specialize.slang -* compute/array-existential-parameter.slang |
