diff options
| author | Copilot <198982749+Copilot@users.noreply.github.com> | 2025-07-22 09:27:05 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-07-22 16:27:05 +0000 |
| commit | 6e0c63b723cc81efcc82c2af778b26e507c71825 (patch) | |
| tree | 2aac55253168957c41b16d1ff37e858b569fe6c4 /tests/diagnostics | |
| parent | 52a45890b5ab71d7dbfdd01955afce129728d67e (diff) | |
Fix segfault when using -separate-debug-info with unsupported targets (#7777)
* Initial plan
* Fix segfault when using -separate-debug-info with unsupported targets
Add validation to emit a diagnostic error when -separate-debug-info is used
with targets other than SPIR-V binary. Previously, this would cause a segfault
because the separate debug info logic is only implemented for SPIR-V targets.
Changes:
- Added new diagnostic error (ID 18) for unsupported separate debug info usage
- Added validation in OptionsParser::_parse() to check target compatibility
- Created test cases for HLSL and GLSL targets to verify the fix
- Updated error message to clarify only SPIR-V binary targets are supported
The fix prevents segfaults and provides clear feedback to users about
target limitations for the -separate-debug-info option.
Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com>
* Address feedback: fix segfault properly instead of preventing it
Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com>
Diffstat (limited to 'tests/diagnostics')
| -rw-r--r-- | tests/diagnostics/command-line/separate-debug-info-unsupported-glsl.slang | 9 | ||||
| -rw-r--r-- | tests/diagnostics/command-line/separate-debug-info-unsupported-target.slang | 9 |
2 files changed, 18 insertions, 0 deletions
diff --git a/tests/diagnostics/command-line/separate-debug-info-unsupported-glsl.slang b/tests/diagnostics/command-line/separate-debug-info-unsupported-glsl.slang new file mode 100644 index 000000000..d8c58245a --- /dev/null +++ b/tests/diagnostics/command-line/separate-debug-info-unsupported-glsl.slang @@ -0,0 +1,9 @@ +// separate-debug-info-unsupported-glsl.slang + +//DIAGNOSTIC_TEST:SIMPLE(filecheck=CHECK):-target glsl -separate-debug-info -entry main -stage vertex + +// CHECK: warning 18: '-separate-debug-info' is not supported for target 'glsl' + +void main() +{ +}
\ No newline at end of file diff --git a/tests/diagnostics/command-line/separate-debug-info-unsupported-target.slang b/tests/diagnostics/command-line/separate-debug-info-unsupported-target.slang new file mode 100644 index 000000000..da65ec0f8 --- /dev/null +++ b/tests/diagnostics/command-line/separate-debug-info-unsupported-target.slang @@ -0,0 +1,9 @@ +// separate-debug-info-unsupported-target.slang + +//DIAGNOSTIC_TEST:SIMPLE(filecheck=CHECK):-target hlsl -separate-debug-info -entry main -stage vertex + +// CHECK: warning 18: '-separate-debug-info' is not supported for target 'hlsl' + +void main() +{ +}
\ No newline at end of file |