SourceLoc use in command line processing (#1848)

* #include an absolute path didn't work - because paths were taken to always be relative.

* Added SourceLoc handling for command line parsing.

* Fix typo in debug.

* Fix issue around the DiagnosticSink used in options parsing not having a writer available - by having DiagnosticSink parenting.

* Small rename for clarity.

Co-authored-by: T. Foley <tfoleyNV@users.noreply.github.com>

7 files changed, 21 insertions, 7 deletions

diff --git a/tests/diagnostics/command-line/option-missing-argument.slang.expected b/tests/diagnostics/command-line/option-missing-argument.slang.expected
index fde023ddd..3bad874a6 100644
--- a/tests/diagnostics/command-line/option-missing-argument.slang.expected
+++ b/tests/diagnostics/command-line/option-missing-argument.slang.expected
@@ -1,6 +1,8 @@
 result code = 1
 standard error = {
-(0): error 13: unknown code generation target '-profile'
+(1): error 13: unknown code generation target '-profile'
+tests/diagnostics/command-line/option-missing-argument.slang -target -profile ps_4_0
+                                                                     ^
 }
 standard output = {
 }
diff --git a/tests/diagnostics/command-line/unknown-codegen-target.slang.expected b/tests/diagnostics/command-line/unknown-codegen-target.slang.expected
index 0db8d267a..dd0bf5255 100644
--- a/tests/diagnostics/command-line/unknown-codegen-target.slang.expected
+++ b/tests/diagnostics/command-line/unknown-codegen-target.slang.expected
@@ -1,6 +1,8 @@
 result code = 1
 standard error = {
-(0): error 13: unknown code generation target 'z80'
+(1): error 13: unknown code generation target 'z80'
+tests/diagnostics/command-line/unknown-codegen-target.slang -target z80
+                                                                    ^
 }
 standard output = {
 }
diff --git a/tests/diagnostics/command-line/unknown-line-directive-mode.slang.expected b/tests/diagnostics/command-line/unknown-line-directive-mode.slang.expected
index 3451d191b..eef953199 100644
--- a/tests/diagnostics/command-line/unknown-line-directive-mode.slang.expected
+++ b/tests/diagnostics/command-line/unknown-line-directive-mode.slang.expected
@@ -1,6 +1,8 @@
 result code = 1
 standard error = {
-(0): error 24: unknown '#line' directive mode 'quizzical'
+(1): error 24: unknown '#line' directive mode 'quizzical'
+tests/diagnostics/command-line/unknown-line-directive-mode.slang -line-directive-mode quizzical
+                                                                                      ^
 }
 standard output = {
 }
diff --git a/tests/diagnostics/command-line/unknown-option.slang.expected b/tests/diagnostics/command-line/unknown-option.slang.expected
index a74219699..5b99ce862 100644
--- a/tests/diagnostics/command-line/unknown-option.slang.expected
+++ b/tests/diagnostics/command-line/unknown-option.slang.expected
@@ -1,6 +1,8 @@
 result code = 1
 standard error = {
-(0): error 17: unknown command-line option '-destroy-all-humans'
+(1): error 17: unknown command-line option '-destroy-all-humans'
+tests/diagnostics/command-line/unknown-option.slang -destroy-all-humans
+                                                    ^
 }
 standard output = {
 }
diff --git a/tests/diagnostics/command-line/unknown-pass-through-target.slang.expected b/tests/diagnostics/command-line/unknown-pass-through-target.slang.expected
index 0c4b1aa4d..d1a2555db 100644
--- a/tests/diagnostics/command-line/unknown-pass-through-target.slang.expected
+++ b/tests/diagnostics/command-line/unknown-pass-through-target.slang.expected
@@ -1,6 +1,8 @@
 result code = 1
 standard error = {
-(0): error 16: unknown pass-through target 'subcon'
+(1): error 16: unknown pass-through target 'subcon'
+tests/diagnostics/command-line/unknown-pass-through-target.slang -pass-through subcon
+                                                                               ^
 }
 standard output = {
 }
diff --git a/tests/diagnostics/command-line/unknown-profile.slang.expected b/tests/diagnostics/command-line/unknown-profile.slang.expected
index 7e53303fc..d1fe63c5c 100644
--- a/tests/diagnostics/command-line/unknown-profile.slang.expected
+++ b/tests/diagnostics/command-line/unknown-profile.slang.expected
@@ -1,6 +1,8 @@
 result code = 1
 standard error = {
-(0): error 14: unknown profile 'thunder_kiss_65'
+(1): error 14: unknown profile 'thunder_kiss_65'
+tests/diagnostics/command-line/unknown-profile.slang -profile thunder_kiss_65
+                                                              ^
 }
 standard output = {
 }
diff --git a/tests/diagnostics/command-line/unknown-stage.slang.expected b/tests/diagnostics/command-line/unknown-stage.slang.expected
index 4d00e6ff4..59dc2562e 100644
--- a/tests/diagnostics/command-line/unknown-stage.slang.expected
+++ b/tests/diagnostics/command-line/unknown-stage.slang.expected
@@ -1,6 +1,8 @@
 result code = 1
 standard error = {
-(0): error 15: unknown stage 'green_hills_zone'
+(1): error 15: unknown stage 'green_hills_zone'
+tests/diagnostics/command-line/unknown-stage.slang -stage green_hills_zone
+                                                          ^
 }
 standard output = {
 }