diff options
| author | Harsh Aggarwal (NVIDIA) <haaggarwal@nvidia.com> | 2025-08-01 14:48:53 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-08-01 09:18:53 +0000 |
| commit | bdda8a90cdd44ca822b21233ac988f92d1f20826 (patch) | |
| tree | 4f628776a047b2719aee676287b3adc9d4f68f7a /tests/cuda/cuda-reflection.slang.expected | |
| parent | 7a133445ef82232a6961c25d09b79f45cd92e709 (diff) | |
Fix 7441: CUDA boolean vector layout to use 1-byte elements (#7862)
* Fix 7441: CUDA boolean vector layout to use 1-byte elements
Boolean vectors (bool1, bool2, bool3, bool4) were incorrectly implemented
as integer-based types using 4 bytes per element instead of actual 1-byte
boolean elements on CUDA targets.
Changes:
- Update CUDA prelude to define boolean vectors as structs with bool fields
instead of typedef aliases to integer vectors
- Implement CUDALayoutRulesImpl::GetVectorLayout to use 1-byte alignment
for boolean vectors, matching actual CUDA memory layout behavior
- Update make_bool functions to populate struct fields correctly
This ensures boolean vectors have the same memory layout as bool[4] arrays:
- bool1: 1 byte (was 4 bytes)
- bool2: 2 bytes (was 8 bytes)
- bool3: 3 bytes (was 12 bytes)
- bool4: 4 bytes (was 16 bytes)
Fixes memory layout mismatch between Slang reflection API and actual
CUDA compilation, achieving 75% memory savings for boolean vector usage.
* Fix CI issues -
Add and update associated functions and operators
* Make boolX same as uchar
* Use align construct on struct for boolX
* Improve Test case for robust alignment checks
* Formatting
* Disable selected slangpy tests
* add metal check which is slightly different than cuda
* Test-1
* Test-2
* Test-3
* Test-4
* ReflectionChange
* cleanup and update
* _slang_select with plain bool is needed for reverse-loop-checkpoint-test
Diffstat (limited to 'tests/cuda/cuda-reflection.slang.expected')
| -rw-r--r-- | tests/cuda/cuda-reflection.slang.expected | 44 |
1 files changed, 22 insertions, 22 deletions
diff --git a/tests/cuda/cuda-reflection.slang.expected b/tests/cuda/cuda-reflection.slang.expected index 636bcedce..a6eeda092 100644 --- a/tests/cuda/cuda-reflection.slang.expected +++ b/tests/cuda/cuda-reflection.slang.expected @@ -6,7 +6,7 @@ standard output = { "parameters": [ { "name": "cb", - "binding": {"kind": "uniform", "offset": 0, "size": 8}, + "binding": {"kind": "uniform", "offset": 0, "size": 8, "elementStride": 0}, "type": { "kind": "constantBuffer", "elementType": { @@ -28,7 +28,7 @@ standard output = { "kind": "scalar", "scalarType": "float64" }, - "binding": {"kind": "uniform", "offset": 0, "size": 8} + "binding": {"kind": "uniform", "offset": 0, "size": 8, "elementStride": 0} }, { "name": "b", @@ -36,13 +36,13 @@ standard output = { "kind": "scalar", "scalarType": "uint8" }, - "binding": {"kind": "uniform", "offset": 8, "size": 1} + "binding": {"kind": "uniform", "offset": 8, "size": 1, "elementStride": 0} } ] }, "uniformStride": 16 }, - "binding": {"kind": "uniform", "offset": 0, "size": 16} + "binding": {"kind": "uniform", "offset": 0, "size": 16, "elementStride": 16} }, { "name": "c", @@ -50,7 +50,7 @@ standard output = { "kind": "scalar", "scalarType": "uint8" }, - "binding": {"kind": "uniform", "offset": 16, "size": 1} + "binding": {"kind": "uniform", "offset": 16, "size": 1, "elementStride": 0} }, { "name": "d", @@ -63,7 +63,7 @@ standard output = { "scalarType": "float16" } }, - "binding": {"kind": "uniform", "offset": 20, "size": 24} + "binding": {"kind": "uniform", "offset": 20, "size": 24, "elementStride": 0} }, { "name": "e", @@ -71,12 +71,12 @@ standard output = { "kind": "scalar", "scalarType": "uint8" }, - "binding": {"kind": "uniform", "offset": 44, "size": 1} + "binding": {"kind": "uniform", "offset": 44, "size": 1, "elementStride": 0} } ] }, "containerVarLayout": { - "binding": {"kind": "uniform", "offset": 0, "size": 8} + "binding": {"kind": "uniform", "offset": 0, "size": 8, "elementStride": 0} }, "elementVarLayout": { "type": { @@ -98,7 +98,7 @@ standard output = { "kind": "scalar", "scalarType": "float64" }, - "binding": {"kind": "uniform", "offset": 0, "size": 8} + "binding": {"kind": "uniform", "offset": 0, "size": 8, "elementStride": 0} }, { "name": "b", @@ -106,13 +106,13 @@ standard output = { "kind": "scalar", "scalarType": "uint8" }, - "binding": {"kind": "uniform", "offset": 8, "size": 1} + "binding": {"kind": "uniform", "offset": 8, "size": 1, "elementStride": 0} } ] }, "uniformStride": 16 }, - "binding": {"kind": "uniform", "offset": 0, "size": 16} + "binding": {"kind": "uniform", "offset": 0, "size": 16, "elementStride": 16} }, { "name": "c", @@ -120,7 +120,7 @@ standard output = { "kind": "scalar", "scalarType": "uint8" }, - "binding": {"kind": "uniform", "offset": 16, "size": 1} + "binding": {"kind": "uniform", "offset": 16, "size": 1, "elementStride": 0} }, { "name": "d", @@ -133,7 +133,7 @@ standard output = { "scalarType": "float16" } }, - "binding": {"kind": "uniform", "offset": 20, "size": 24} + "binding": {"kind": "uniform", "offset": 20, "size": 24, "elementStride": 0} }, { "name": "e", @@ -141,17 +141,17 @@ standard output = { "kind": "scalar", "scalarType": "uint8" }, - "binding": {"kind": "uniform", "offset": 44, "size": 1} + "binding": {"kind": "uniform", "offset": 44, "size": 1, "elementStride": 0} } ] }, - "binding": {"kind": "uniform", "offset": 0, "size": 48} + "binding": {"kind": "uniform", "offset": 0, "size": 48, "elementStride": 0} } } }, { "name": "sb", - "binding": {"kind": "uniform", "offset": 8, "size": 16}, + "binding": {"kind": "uniform", "offset": 8, "size": 16, "elementStride": 0}, "type": { "kind": "resource", "baseShape": "structuredBuffer", @@ -175,7 +175,7 @@ standard output = { "kind": "scalar", "scalarType": "float64" }, - "binding": {"kind": "uniform", "offset": 0, "size": 8} + "binding": {"kind": "uniform", "offset": 0, "size": 8, "elementStride": 0} }, { "name": "b", @@ -183,13 +183,13 @@ standard output = { "kind": "scalar", "scalarType": "uint8" }, - "binding": {"kind": "uniform", "offset": 8, "size": 1} + "binding": {"kind": "uniform", "offset": 8, "size": 1, "elementStride": 0} } ] }, "uniformStride": 16 }, - "binding": {"kind": "uniform", "offset": 0, "size": 16} + "binding": {"kind": "uniform", "offset": 0, "size": 16, "elementStride": 16} }, { "name": "c", @@ -197,7 +197,7 @@ standard output = { "kind": "scalar", "scalarType": "uint8" }, - "binding": {"kind": "uniform", "offset": 16, "size": 1} + "binding": {"kind": "uniform", "offset": 16, "size": 1, "elementStride": 0} }, { "name": "d", @@ -210,7 +210,7 @@ standard output = { "scalarType": "float16" } }, - "binding": {"kind": "uniform", "offset": 20, "size": 24} + "binding": {"kind": "uniform", "offset": 20, "size": 24, "elementStride": 0} }, { "name": "e", @@ -218,7 +218,7 @@ standard output = { "kind": "scalar", "scalarType": "uint8" }, - "binding": {"kind": "uniform", "offset": 44, "size": 1} + "binding": {"kind": "uniform", "offset": 44, "size": 1, "elementStride": 0} } ] } |
