diff options
| author | Tim Foley <tfoleyNV@users.noreply.github.com> | 2018-02-02 08:49:04 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-02-02 08:49:04 -0800 |
| commit | 0360f81b9741ece65768a65731bd23455a3b7a96 (patch) | |
| tree | eab15cf6737cf091bf94d073e82c7b233f958e57 /tests/cross-compile | |
| parent | b034398ab12d3cc3a5fc04174688cb707404791d (diff) | |
Remove support for the -no-checking flag (#392)
* Remove support for the -no-checking flag
Fixes #381
Fixes #383
Work on #382
- No longer expose flag through API (`SLANG_COMPILE_FLAG_NO_CHECKING`) and command-line (`-no-checking`) options
- Remove all logic in `check.cpp` that was withholding diagnostics (including errors) when the no-checking mode was enabled
- Remove `HiddenImplicitCastExpr`, which was only created to support no-checking mode (it represented an implicit cast that our checking through was needed, but couldn't emit because it might be wrong)
- Remove logic for storing function bodies as raw token lists when checking is turned off. I'm leaving in the `UnparsedStmt` AST node in case we ever need/want to lazily parse and check function bodies down the line.
- Remove a few of the code-generation paths we had to contend with, but keep the comment about them in place.
- Remove GLSL-based tests that can't meaningfully work with the new approach.
- Fix other tests that used a GLSL baseline so that their GLSL compiles with `-pass-through glslang` instead of invoking `slang` with the `-no-checking` flag.
- Remove tests that were explicitly added to test the "rewriter + IR" path, since that is no longer supported.
There is more cleanup that can be done here, now that we know that AST-based rewrite and IR will never co-exist, but it is probably easier to deal with that as part of removing the AST-based rewrite path.
We've lost some test coverage here, but actually not too much if we consider that we are dropping GLSL input anyway.
* Fixup: test runner was mis-counting ignored tests
* Fixup: turn on dumping on test failure under Travis
* Fixup: enable extensions in Linux build of glslang
Diffstat (limited to 'tests/cross-compile')
5 files changed, 10 insertions, 1 deletions
diff --git a/tests/cross-compile/compile-time-loop.slang.glsl b/tests/cross-compile/compile-time-loop.slang.glsl index a1f87be65..9f4bd385a 100644 --- a/tests/cross-compile/compile-time-loop.slang.glsl +++ b/tests/cross-compile/compile-time-loop.slang.glsl @@ -1,4 +1,5 @@ //TEST_IGNORE_FILE: +#version 420 layout(binding = 0) uniform texture2D t; diff --git a/tests/cross-compile/gl-layer-pick-version.slang.glsl b/tests/cross-compile/gl-layer-pick-version.slang.glsl index 55d419405..9e737cecf 100644 --- a/tests/cross-compile/gl-layer-pick-version.slang.glsl +++ b/tests/cross-compile/gl-layer-pick-version.slang.glsl @@ -6,11 +6,12 @@ struct VS_OUT uint layerID; }; -vec4 main_(VS_OUT vsOut) : SV_Target +vec4 main_(VS_OUT vsOut) { return vec4(float(vsOut.layerID)); } +layout(location = 0) out vec4 SLANG_out_main_result; void main() diff --git a/tests/cross-compile/integer-input.slang.glsl b/tests/cross-compile/integer-input.slang.glsl index ce6998a9a..7d45d4de1 100644 --- a/tests/cross-compile/integer-input.slang.glsl +++ b/tests/cross-compile/integer-input.slang.glsl @@ -1,12 +1,15 @@ //TEST_IGNORE_FILE: +#version 420 struct VS_OUT { uint drawID; }; +layout(location = 0) in flat uint SLANG_in_vsOut_drawID; +layout(location = 0) out vec4 SLANG_out_main_result; vec4 main_(VS_OUT vsOut) diff --git a/tests/cross-compile/matrix-mult.slang.glsl b/tests/cross-compile/matrix-mult.slang.glsl index 0349d854e..9a29e1ed5 100644 --- a/tests/cross-compile/matrix-mult.slang.glsl +++ b/tests/cross-compile/matrix-mult.slang.glsl @@ -1,4 +1,5 @@ //TEST_IGNORE_FILE: +#version 420 layout(binding = 0) uniform C diff --git a/tests/cross-compile/nointerpolation-input.slang.glsl b/tests/cross-compile/nointerpolation-input.slang.glsl index 279590fa5..d359f5bc8 100644 --- a/tests/cross-compile/nointerpolation-input.slang.glsl +++ b/tests/cross-compile/nointerpolation-input.slang.glsl @@ -1,12 +1,15 @@ //TEST_IGNORE_FILE: +#version 420 struct VS_OUT { float drawID; }; +layout(location = 0) in flat float SLANG_in_vsOut_drawID; +layout(location = 0) out vec4 SLANG_out_main_result; vec4 main_(VS_OUT vsOut) |
