diff options
| author | Jay Kwak <82421531+jkwak-work@users.noreply.github.com> | 2025-09-03 20:13:45 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-09-04 03:13:45 +0000 |
| commit | b45706b3f532f85525de5746f1f607ba2e57fc88 (patch) | |
| tree | 565085f6d40bc60fddd027cf765e73fff77106c6 /tests/cpp-compiler | |
| parent | a766d27447aa0fcf69334c0467d9b1124892e180 (diff) | |
Handle slang-test command comments better (#8363)
Before this PR only the following was a valid line without any
white-space character nor additional `/` character,
```
//TEST:
```
This PR is to allow slang-test to handle the following variants of the
test command comments,
```
///TEST:
// TEST:
// TEST:
////// TEST:
```
This PR revealed a regression on two tests:
- tests/cpp-compiler/c-compile-shared-library.c (cpu)
- tests/cpp-compiler/cpp-compile-shared-library.cpp (cpu)
They are disabled as a part of this PR.
And there is a new github issue to track it later,
- https://github.com/shader-slang/slang/issues/8362
Diffstat (limited to 'tests/cpp-compiler')
| -rw-r--r-- | tests/cpp-compiler/c-compile-shared-library.c | 3 | ||||
| -rw-r--r-- | tests/cpp-compiler/cpp-compile-shared-library.cpp | 3 |
2 files changed, 4 insertions, 2 deletions
diff --git a/tests/cpp-compiler/c-compile-shared-library.c b/tests/cpp-compiler/c-compile-shared-library.c index 5af13b4c9..7bf439f1e 100644 --- a/tests/cpp-compiler/c-compile-shared-library.c +++ b/tests/cpp-compiler/c-compile-shared-library.c @@ -1,4 +1,5 @@ -// TEST(smoke,shared-library):CPP_COMPILER_SHARED_LIBRARY: +// This test is failing due to a regression github issue #8362 +// DISABLE_TEST(smoke,shared-library):CPP_COMPILER_SHARED_LIBRARY: #include <stdio.h> #include <stdlib.h> diff --git a/tests/cpp-compiler/cpp-compile-shared-library.cpp b/tests/cpp-compiler/cpp-compile-shared-library.cpp index a69e22899..cd192d9f6 100644 --- a/tests/cpp-compiler/cpp-compile-shared-library.cpp +++ b/tests/cpp-compiler/cpp-compile-shared-library.cpp @@ -1,4 +1,5 @@ -// TEST(smoke):CPP_COMPILER_SHARED_LIBRARY: +// This test is failing due to a regression github issue #8362 +// DISABLE_TEST(smoke):CPP_COMPILER_SHARED_LIBRARY: #include <iostream> #include <stdio.h> |
