diff options
| author | ArielG-NV <159081215+ArielG-NV@users.noreply.github.com> | 2024-06-14 01:29:35 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-06-13 22:29:35 -0700 |
| commit | 2cc96907e4152291e0b6bca78a0bfbc69ddb8839 (patch) | |
| tree | c5ebf1cc6afc99d2058c673e79b1fef2d60f5f46 /tests/compute | |
| parent | a6b8348f69a4cd1ab1edbc1ccf1133c807b81b5b (diff) | |
Implement for metal `SV_GroupIndex` (#4385)
* Implement for metal `SV_GroupIndex`
1. If we don't have `sv_GroupThreadId` available we create one using `SV_GroupIndex`s location data.
2. We emit code emulating `sv_GroupThreadId` from the same logic that CUDA/CPP uses.
* address most review comments
Addressed all but two: [1](https://github.com/shader-slang/slang/pull/4385#discussion_r1639058473) and [2](https://github.com/shader-slang/slang/pull/4385#issuecomment-2166934855)
I want to enable tests and be sure there is no bugs using CI before I redesign the code so I have a working fallback.
* address comment, enable tests
enable now functioning tests due to `SV_GroupIndex` working with metal
* syntax error with groupThreadID search
did `= param` instead of `= i.param`
* add `sv_groupid` for test + test fixes
* disable test that won't work regardless
Diffstat (limited to 'tests/compute')
| -rw-r--r-- | tests/compute/texture-simpler.slang | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/compute/texture-simpler.slang b/tests/compute/texture-simpler.slang index 196e8e96c..0f9dfcbad 100644 --- a/tests/compute/texture-simpler.slang +++ b/tests/compute/texture-simpler.slang @@ -4,7 +4,7 @@ //TEST(smoke,compute):COMPARE_COMPUTE_EX:-slang -compute -dx12 -profile cs_6_0 -use-dxil -shaderobj -output-using-type //TEST(smoke,compute, vulkan):COMPARE_COMPUTE_EX:-vk -compute -shaderobj -output-using-type -render-feature hardware-device //TEST(smoke,compute):COMPARE_COMPUTE_EX:-cuda -compute -shaderobj -output-using-type -//DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -mtl +//TEST(smoke,compute):COMPARE_COMPUTE:-slang -shaderobj -mtl -output-using-type //TEST_INPUT: Texture2D(size=4, content = one):name t2D Texture2D<float> t2D; |