diff options
| author | Gangzheng Tong <tonggangzheng@gmail.com> | 2025-09-23 09:39:39 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-09-23 16:39:39 +0000 |
| commit | d61d6b57dfb0788ebf3449bfde6db288fe4e44a8 (patch) | |
| tree | f95d543f962a75917e401a44dfdc0fe18df4efdd /tests/bugs/serialization | |
| parent | 21c663605330d629e9022314a4720b86b017f295 (diff) | |
Legalize type as well in legalizeOperand (#8483)
This fixes a type mismatch issue. See the generated cuda code
```cuda
struct Query_0
{
EmptyExample_0 query_0;
uint hasNonEmptyAbsorbingBoundary_0;
};
struct Query_1
{
uint hasNonEmptyAbsorbingBoundary_0;
};
struct GlobalParams_0
{
Query_0* gQuery_0;
RWStructuredBuffer<float3 > gInput_0;
RWStructuredBuffer<float> gOutput_0;
};
...
Query_1 _S4 = *globalParams_0->gQuery_0; // ==> type mismatch at call site!
```
**Root Cause:** During the empty type legalization pass in Slang's IR
processing, struct types were being optimized. e.g., `Query_0` →
`Query_1` with empty type removed), but this created an inconsistency:
**Function parameters were updated:** When Query_compute_0 function was
legalized, its parameter type was correctly updated from `Query_0` to
the optimized `Query_1`
**Global parameter types were NOT updated:** The
`ParameterBlock<Struct>` type in globalParams still referenced the old
`Query_0` type
The PR adds special handling for type operands in the `legalizeInst`
function. This triggers the legalization of the `StructType` from the
original `legalizeOperand` call site. The leaglized result will be saved
in the type-to-legal-type map and be re-used when the same type requires
legalization again (e.g. in the `IRFunc` as parameter)
Fixes: https://github.com/shader-slang/slang/issues/7905
Diffstat (limited to 'tests/bugs/serialization')
0 files changed, 0 insertions, 0 deletions
