summaryrefslogtreecommitdiffstats
path: root/source
diff options
context:
space:
mode:
authorSai Praveen Bangaru <31557731+saipraveenb25@users.noreply.github.com>2024-02-26 18:22:16 -0500
committerGitHub <noreply@github.com>2024-02-26 15:22:16 -0800
commitceb87b25b387411dbb7978caf04ecd9e948493e3 (patch)
tree62b8eb42661498354e1f92043672da0de85c14d2 /source
parentd7bb80673a3ef91ec904ca487dcc71315054c654 (diff)
AD: Handle case where struct is created with `no_diff`-wrapped operands. (#3629)
* Handle case where struct is created with `no_diff`-wrapped operands. * Add test to reproduce crash upon initializing a struct with `no_diff`-wrapped operand type * Add expected result for test
Diffstat (limited to 'source')
-rw-r--r--source/slang/slang-ir-autodiff-fwd.cpp19
1 files changed, 16 insertions, 3 deletions
diff --git a/source/slang/slang-ir-autodiff-fwd.cpp b/source/slang/slang-ir-autodiff-fwd.cpp
index 2f61dfa72..334d4e678 100644
--- a/source/slang/slang-ir-autodiff-fwd.cpp
+++ b/source/slang/slang-ir-autodiff-fwd.cpp
@@ -498,9 +498,22 @@ InstPair ForwardDiffTranscriber::transcribeMakeStruct(IRBuilder* builder, IRInst
{
auto operandDataType = origMakeStruct->getOperand(ii)->getDataType();
auto diffOperandType = differentiateType(builder, operandDataType);
- SLANG_RELEASE_ASSERT(diffOperandType);
- operandDataType = (IRType*)findOrTranscribePrimalInst(builder, operandDataType);
- diffOperands.add(getDifferentialZeroOfType(builder, operandDataType));
+
+ if (diffOperandType)
+ {
+ operandDataType = (IRType*)findOrTranscribePrimalInst(builder, operandDataType);
+ diffOperands.add(getDifferentialZeroOfType(builder, operandDataType));
+ }
+ else
+ {
+ // This case is only hit if the field is of a differentiable type but the operand is of
+ // a non-differentiable type. This can happen if the operand is wrapped in no_diff.
+ // In this case, we use the derivative of the field type to synthesize the 0.
+ //
+ auto diffFieldOperandType = differentiateType(builder, field->getFieldType());
+ SLANG_RELEASE_ASSERT(diffFieldOperandType);
+ diffOperands.add(getDifferentialZeroOfType(builder, (IRType*)diffFieldOperandType));
+ }
}
ii++;
}