summaryrefslogtreecommitdiffstats
path: root/source
diff options
context:
space:
mode:
authorCopilot <198982749+Copilot@users.noreply.github.com>2025-07-03 23:53:02 -0700
committerGitHub <noreply@github.com>2025-07-04 06:53:02 +0000
commitb282c88d9743fc9bb60ef27cfa5d9cf58cccd60b (patch)
tree0abd8598051b277c02e459affd66f67ce5028abe /source
parentb4fc380af5e390ca11892f9e657e653f6869c21b (diff)
Make copysign function differentiable (#7585)
* Initial plan * Implement copysign forward and backward derivatives Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> * Fix copysign test format to use expected.txt file Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> * Add wgsl support to copysign and fix y==0 derivative case Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> * Add wgsl support to copysign helper functions Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> * Fix copysign derivative to return 0 when either x or y is 0 Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com>
Diffstat (limited to 'source')
-rw-r--r--source/slang/diff.meta.slang77
-rw-r--r--source/slang/hlsl.meta.slang10
2 files changed, 82 insertions, 5 deletions
diff --git a/source/slang/diff.meta.slang b/source/slang/diff.meta.slang
index 13c5d2d47..542983049 100644
--- a/source/slang/diff.meta.slang
+++ b/source/slang/diff.meta.slang
@@ -2160,6 +2160,83 @@ void __d_min(inout DifferentialPair<T> dpx, inout DifferentialPair<T> dpy, T.Dif
VECTOR_MATRIX_BINARY_DIFF_IMPL(min)
+// copysign
+__generic<T : __BuiltinFloatingPointType>
+[BackwardDifferentiable]
+[PreferRecompute]
+[ForwardDerivativeOf(copysign)]
+DifferentialPair<T> __d_copysign(DifferentialPair<T> dpx, DifferentialPair<T> dpy)
+{
+ // copysign(x, y) = sign(y) * abs(x)
+ // d/dx copysign(x, y) = sign(y) * sign(x) when x != 0 and y != 0, 0 when x == 0 or y == 0
+ // d/dy copysign(x, y) = 0 (sign function is not differentiable w.r.t y)
+ let sign_y = select(dpy.p >= T(0.0), T(1.0), T(-1.0));
+ let sign_x = select(dpx.p >= T(0.0), T(1.0), T(-1.0));
+ // When x == 0 or y == 0, derivative w.r.t. x should be 0
+ let dx_coeff = select((dpx.p == T(0.0)) || (dpy.p == T(0.0)), T(0.0), sign_y * sign_x);
+ return DifferentialPair<T>(
+ copysign(dpx.p, dpy.p),
+ __mul_p_d(dx_coeff, dpx.d)
+ );
+}
+
+__generic<T : __BuiltinFloatingPointType>
+[BackwardDifferentiable]
+[PreferRecompute]
+[BackwardDerivativeOf(copysign)]
+void __d_copysign(inout DifferentialPair<T> dpx, inout DifferentialPair<T> dpy, T.Differential dOut)
+{
+ let sign_y = select(dpy.p >= T(0.0), T(1.0), T(-1.0));
+ let sign_x = select(dpx.p >= T(0.0), T(1.0), T(-1.0));
+ // When x == 0 or y == 0, derivative w.r.t. x should be 0
+ let dx_coeff = select((dpx.p == T(0.0)) || (dpy.p == T(0.0)), T(0.0), sign_y * sign_x);
+ // Gradient flows only to x since d/dy copysign = 0
+ dpx = diffPair(dpx.p, __mul_p_d(dx_coeff, dOut));
+ dpy = diffPair(dpy.p, T.dzero());
+}
+
+__generic<T : __BuiltinFloatingPointType, let N : int>
+[BackwardDifferentiable]
+[PreferRecompute]
+[ForwardDerivativeOf(copysign)]
+DifferentialPair<vector<T, N>> __d_copysign_vector(
+ DifferentialPair<vector<T, N>> dpx, DifferentialPair<vector<T, N>> dpy)
+{
+ vector<T, N> result;
+ vector<T, N>.Differential d_result;
+ [ForceUnroll] for (int i = 0; i < N; ++i)
+ {
+ DifferentialPair<T> dp_elem = __d_copysign(
+ DifferentialPair<T>(dpx.p[i], __slang_noop_cast<T.Differential>(dpx.d[i])),
+ DifferentialPair<T>(dpy.p[i], __slang_noop_cast<T.Differential>(dpy.d[i])));
+ result[i] = dp_elem.p;
+ d_result[i] = __slang_noop_cast<T>(dp_elem.d);
+ }
+ return DifferentialPair<vector<T, N>>(result, d_result);
+}
+
+__generic<T : __BuiltinFloatingPointType, let N : int>
+[BackwardDifferentiable]
+[PreferRecompute]
+[BackwardDerivativeOf(copysign)]
+void __d_copysign_vector(
+ inout DifferentialPair<vector<T, N>> dpx,
+ inout DifferentialPair<vector<T, N>> dpy,
+ vector<T, N>.Differential dOut)
+{
+ vector<T, N>.Differential x_d_result, y_d_result;
+ [ForceUnroll] for (int i = 0; i < N; ++i)
+ {
+ DifferentialPair<T> x_dp = DifferentialPair<T>(dpx.p[i], __slang_noop_cast<T.Differential>(dpx.d[i]));
+ DifferentialPair<T> y_dp = DifferentialPair<T>(dpy.p[i], __slang_noop_cast<T.Differential>(dpy.d[i]));
+ __d_copysign(x_dp, y_dp, __slang_noop_cast<T.Differential>(dOut[i]));
+ x_d_result[i] = __slang_noop_cast<T>(x_dp.d);
+ y_d_result[i] = __slang_noop_cast<T>(y_dp.d);
+ }
+ dpx = diffPair(dpx.p, x_d_result);
+ dpy = diffPair(dpy.p, y_d_result);
+}
+
// Lerp
__generic<T : __BuiltinFloatingPointType>
[BackwardDifferentiable]
diff --git a/source/slang/hlsl.meta.slang b/source/slang/hlsl.meta.slang
index 38f274984..7879fc493 100644
--- a/source/slang/hlsl.meta.slang
+++ b/source/slang/hlsl.meta.slang
@@ -7685,7 +7685,7 @@ matrix<T, N, M> ceil(matrix<T, N, M> x)
/// @category math
__generic<let N: int>
[__readNone]
-[require(cpp_cuda_glsl_hlsl_metal_spirv)]
+[require(cpp_cuda_glsl_hlsl_metal_spirv_wgsl)]
vector<half,N> copysign_half(vector<half,N> x, vector<half,N> y)
{
let ux = reinterpret<vector<uint16_t,N>>(x);
@@ -7702,7 +7702,7 @@ vector<half,N> copysign_half(vector<half,N> x, vector<half,N> y)
/// @category math
__generic<let N: int>
[__readNone]
-[require(cpp_cuda_glsl_hlsl_metal_spirv)]
+[require(cpp_cuda_glsl_hlsl_metal_spirv_wgsl)]
vector<float,N> copysign_float(vector<float,N> x, vector<float,N> y)
{
let ux = reinterpret<vector<uint32_t,N>>(x);
@@ -7719,7 +7719,7 @@ vector<float,N> copysign_float(vector<float,N> x, vector<float,N> y)
/// @category math
__generic<let N: int>
[__readNone]
-[require(cpp_cuda_glsl_hlsl_metal_spirv)]
+[require(cpp_cuda_glsl_hlsl_metal_spirv_wgsl)]
vector<double,N> copysign_double(vector<double,N> x, vector<double,N> y)
{
let ux = reinterpret<vector<uint64_t,N>>(x);
@@ -7740,7 +7740,7 @@ vector<T,N> __real_cast(vector<U,N> val);
/// @category math
__generic<T : __BuiltinFloatingPointType, let N: int>
[__readNone]
-[require(cpp_cuda_glsl_hlsl_metal_spirv)]
+[require(cpp_cuda_glsl_hlsl_metal_spirv_wgsl)]
vector<T,N> copysign(vector<T,N> x, vector<T,N> y)
{
__target_switch
@@ -7766,7 +7766,7 @@ vector<T,N> copysign(vector<T,N> x, vector<T,N> y)
__generic<T : __BuiltinFloatingPointType>
[__readNone]
-[require(cpp_cuda_glsl_hlsl_metal_spirv)]
+[require(cpp_cuda_glsl_hlsl_metal_spirv_wgsl)]
T copysign(T x, T y)
{
__target_switch