diff options
| author | jsmall-nvidia <jsmall@nvidia.com> | 2020-07-17 16:38:18 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-07-17 16:38:18 -0400 |
| commit | 975c5db3f0a71bc93369a321318e7d3b43001ff5 (patch) | |
| tree | 858ff3f6510ffdb178d68f9b417007a4361ef35e /source | |
| parent | ee755589356f77ef0a01540ba464f9a87d16fce4 (diff) | |
Disable specializing function calls if they have a struct param, that contains an array (#1448)
* This code is disabled, it was part of the optimization `Specialize function calls involving array arguments. (#1389)` on github.
It is disabled here because it causes a problem when a struct is passed to a function that contains a structured buffer *and* an array. It is specialized on the struct type, and so those types become parameters to the function. If the struct contains a structured buffer this is a problem on GLSL/VK based targets because currently structured buffers cannot be function parameters.
The fix for now is to just disable this optimization.
* Fix typo in name of test expected values.
Diffstat (limited to 'source')
| -rw-r--r-- | source/slang/slang-ir-specialize-resources.cpp | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/source/slang/slang-ir-specialize-resources.cpp b/source/slang/slang-ir-specialize-resources.cpp index 60439abeb..2d84cfd8c 100644 --- a/source/slang/slang-ir-specialize-resources.cpp +++ b/source/slang/slang-ir-specialize-resources.cpp @@ -230,8 +230,20 @@ struct ResourceParameterSpecializationContext return true; if(as<IRByteAddressBufferTypeBase>(type)) return true; + +#if 0 + // This code is disabled, and is part of the optimization `Specialize function calls involving array arguments. (#1389)` on github. + // + // It is disabled here because it causes a problem when a struct is passed to a function that contains a structured buffer *and* + // an array. It is specialized on the struct type, and so those types become parameters to the function. + // If the struct contains a structured buffer this is a problem on GLSL/VK based targets because currently + // structured buffers cannot be function parameters. + // + // The fix for now is to just disable this optimization. + if (isStructTypeWithArray(type)) return true; +#endif } // For now, we will not treat any other parameters as |