diff options
| author | Yong He <yonghe@outlook.com> | 2023-02-15 17:18:00 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-15 17:18:00 -0800 |
| commit | 86675155eb79532039ba79655ed14a76998e9f85 (patch) | |
| tree | e6749018fb853d0f1d228631dafeebf3fd4df4df /source | |
| parent | 266dc667485b38e16877cb9868873619e1b263e9 (diff) | |
Treat user defined backward derivative function as non differentiable. (#2650)
Co-authored-by: Yong He <yhe@nvidia.com>
Diffstat (limited to 'source')
| -rw-r--r-- | source/slang/slang-ir-check-differentiability.cpp | 5 | ||||
| -rw-r--r-- | source/slang/slang-lower-to-ir.cpp | 2 |
2 files changed, 0 insertions, 7 deletions
diff --git a/source/slang/slang-ir-check-differentiability.cpp b/source/slang/slang-ir-check-differentiability.cpp index e7d5a0e5c..a3f7ae7c0 100644 --- a/source/slang/slang-ir-check-differentiability.cpp +++ b/source/slang/slang-ir-check-differentiability.cpp @@ -165,7 +165,6 @@ public: HashSet<IRInst*> produceDiffSet; HashSet<IRInst*> expectDiffSet; - int differentiableInputs = 0; int differentiableOutputs = 0; for (auto param : funcInst->getFirstBlock()->getParams()) { @@ -173,8 +172,6 @@ public: { if (as<IROutTypeBase>(param->getFullType())) differentiableOutputs++; - if (!as<IROutType>(param->getFullType())) - differentiableInputs++; produceDiffSet.Add(param); } } @@ -186,8 +183,6 @@ public: if (differentiableOutputs == 0) sink->diagnose(funcInst, Diagnostics::differentiableFuncMustHaveOutput); - if (differentiableInputs == 0) - sink->diagnose(funcInst, Diagnostics::differentiableFuncMustHaveInput); DifferentiableLevel requiredDiffLevel = DifferentiableLevel::Forward; if (isBackwardDifferentiableFunc(funcInst)) diff --git a/source/slang/slang-lower-to-ir.cpp b/source/slang/slang-lower-to-ir.cpp index 9cf6aedf4..957f74d40 100644 --- a/source/slang/slang-lower-to-ir.cpp +++ b/source/slang/slang-lower-to-ir.cpp @@ -8436,8 +8436,6 @@ struct DeclLoweringVisitor : DeclVisitor<DeclLoweringVisitor, LoweredValInfo> else { originalSubBuilder->addUserDefinedBackwardDerivativeDecoration(originalFuncVal, derivativeFuncVal.val); - getBuilder()->addForwardDifferentiableDecoration(irFunc); - getBuilder()->addBackwardDifferentiableDecoration(irFunc); } } subContext->irBuilder->setInsertInto(irFunc); |
