diff options
| author | Yong He <yonghe@outlook.com> | 2023-04-04 15:29:36 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-04 15:29:36 -0700 |
| commit | 492c6f2fd1a64c9d60a968b55bfd1000cc2ae8e7 (patch) | |
| tree | 2fa6849e2b0228d7cede69f5ac5445b1d543fa01 /source | |
| parent | 68c7d5cda2d6f2eb7bfb3a7e15860eb3ded25424 (diff) | |
Diagnose on using assignment as predicate expr. (#2774)
Co-authored-by: Yong He <yhe@nvidia.com>
Diffstat (limited to 'source')
| -rw-r--r-- | source/slang/slang-check-stmt.cpp | 4 | ||||
| -rw-r--r-- | source/slang/slang-diagnostic-defs.h | 1 |
2 files changed, 5 insertions, 0 deletions
diff --git a/source/slang/slang-check-stmt.cpp b/source/slang/slang-check-stmt.cpp index bc89dc94e..a61f48af6 100644 --- a/source/slang/slang-check-stmt.cpp +++ b/source/slang/slang-check-stmt.cpp @@ -151,6 +151,10 @@ namespace Slang Expr* SemanticsVisitor::checkPredicateExpr(Expr* expr) { + if (as<AssignExpr>(expr)) + { + getSink()->diagnose(expr, Diagnostics::assignmentInPredicateExpr); + } Expr* e = expr; e = CheckTerm(e); e = coerce(m_astBuilder->getBoolType(), e); diff --git a/source/slang/slang-diagnostic-defs.h b/source/slang/slang-diagnostic-defs.h index 39ceb6678..fed4944d3 100644 --- a/source/slang/slang-diagnostic-defs.h +++ b/source/slang/slang-diagnostic-defs.h @@ -277,6 +277,7 @@ DIAGNOSTIC(30053, Error, breakLabelNotFound, "label '$0' used as break target is DIAGNOSTIC(30054, Error, targetLabelDoesNotMarkBreakableStmt, "invalid break target: statement labeled '$0' is not breakable.") DIAGNOSTIC(30055, Error, useOfNonShortCircuitingOperatorInDiffFunc, "non-short-circuiting `?:` operator is not allowed in a differentiable function, use `select` instead.") DIAGNOSTIC(30056, Warning, useOfNonShortCircuitingOperator, "non-short-circuiting `?:` operator is deprecated, use 'select' instead.") +DIAGNOSTIC(30057, Error, assignmentInPredicateExpr, "use an assignment operation as predicate expression is not allowed, wrap the assignment with '()' to clarify the intent.") DIAGNOSTIC(30043, Error, getStringHashRequiresStringLiteral, "getStringHash parameter can only accept a string literal") |