diff options
| author | ArielG-NV <159081215+ArielG-NV@users.noreply.github.com> | 2025-07-15 17:48:30 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-07-16 00:48:30 +0000 |
| commit | 439e025c1d3c58cc261c36f1e8d804a403b2856a (patch) | |
| tree | 7256b0982f4ff5a0587d2bc5a782438ff76b5b7b /source | |
| parent | 223ccd40599ffcd74b409c7321f2264b93aec4bd (diff) | |
Document why failing VVL coop-vec tests cannot be enabled & minor cleanup/bug-fix (#7754)
* Changes
Fix a coop-vec bug, fix incorrect test synax, clean up test, comment why some coop-vec tests are stil disabled
* Changes
Fix a coop-vec bug, fix incorrect test synax, clean up test, comment why some coop-vec tests are stil disabled
* disable failing tests
* push changes
* add to failing GLSL test list
Diffstat (limited to 'source')
| -rw-r--r-- | source/slang/hlsl.meta.slang | 17 |
1 files changed, 14 insertions, 3 deletions
diff --git a/source/slang/hlsl.meta.slang b/source/slang/hlsl.meta.slang index 1443843a9..216dfc04a 100644 --- a/source/slang/hlsl.meta.slang +++ b/source/slang/hlsl.meta.slang @@ -26742,7 +26742,6 @@ CoopVec<T, M> coopVecMatMulAddPacked<T : __BuiltinArithmeticType, let M : int, l if (__isSignedInt<U>()) { operands |= 0x02; // MatrixBSignedComponentsKHR - operands |= 0x04; // MatrixCSignedComponentsKHR } if (__isSignedInt<T>()) { @@ -27193,7 +27192,6 @@ CoopVec<T, M> coopVecMatMulAddPacked<T : __BuiltinArithmeticType, let M : int, l if (__isSignedInt<U>()) { operands |= 0x02; // MatrixBSignedComponentsKHR - operands |= 0x04; // MatrixCSignedComponentsKHR } if (__isSignedInt<T>()) { @@ -27370,6 +27368,10 @@ CoopVec<T, M> coopVecMatMulPacked( int operands = 0; // NoneKHR let zero = 0; let cvtMatPtr = (Ptr<T[]>)matrixPtr; + if (__isSignedInt<U>()) + { + operands |= 0x02; // MatrixBSignedComponentsKHR + } if (__isSignedInt<T>()) { operands |= 0x08; // MatrixResultSignedComponentsKHR @@ -27439,9 +27441,18 @@ CoopVec<T, M> coopVecMatMulAddPacked<T : __BuiltinArithmeticType, let M : int, l let zero : int32_t = 0; let cvtMatPtr = (Ptr<T[]>)matrixPtr; let cvtBiasPtr = (Ptr<T[]>)biasPtr; + int operands = 0; // NoneKHR + if (__isSignedInt<U>()) + { + operands |= 0x02; // MatrixBSignedComponentsKHR + } + if (__isSignedInt<T>()) + { + operands |= 0x08; // MatrixResultSignedComponentsKHR + } return spirv_asm { - result:$$CoopVec<T, M> = OpCooperativeVectorMatrixMulAddNV $input $inputInterpretationSpirv $cvtMatPtr $zero $matrixInterpretationSpirv $cvtBiasPtr $zero $biasInterpretationSpirv $m $k $memoryLayoutSpirv $transpose $matrixStride; + result:$$CoopVec<T, M> = OpCooperativeVectorMatrixMulAddNV $input $inputInterpretationSpirv $cvtMatPtr $zero $matrixInterpretationSpirv $cvtBiasPtr $zero $biasInterpretationSpirv $m $k $memoryLayoutSpirv $transpose $matrixStride !operands; }; } } |