summaryrefslogtreecommitdiffstats
path: root/source/slang
diff options
context:
space:
mode:
authorEllie Hermaszewska <ellieh@nvidia.com>2023-08-29 20:58:44 +0800
committerGitHub <noreply@github.com>2023-08-29 20:58:44 +0800
commitf3ecf978a07b02681a4d70a9d83991e6661bf753 (patch)
tree124c12ea8a1000caa9405871a21d44dbed83580c /source/slang
parent9d4e044bad6161a593806fc6fb610d41aa8b4b22 (diff)
Correct parsing spirv with no rhs operands (#3161)
* Correct parsing spirv with no rhs operands * Guard against eof
Diffstat (limited to 'source/slang')
-rw-r--r--source/slang/slang-parser.cpp29
1 files changed, 20 insertions, 9 deletions
diff --git a/source/slang/slang-parser.cpp b/source/slang/slang-parser.cpp
index 57a21a90a..7e6d7d308 100644
--- a/source/slang/slang-parser.cpp
+++ b/source/slang/slang-parser.cpp
@@ -6411,8 +6411,27 @@ namespace Slang
// At this point we can also parse bitwise or expressions
//
while(!(parser->LookAheadToken(TokenType::RBrace)
- || parser->LookAheadToken(TokenType::Semicolon)))
+ || parser->LookAheadToken(TokenType::Semicolon)
+ || parser->LookAheadToken(TokenType::EndOfFile))
+ || resultTypeOperand
+ || resultOperand)
{
+ // Insert the LHS result-type operand
+ if(ret.operands.getCount() == opInfo->resultTypeIndex && resultTypeOperand)
+ {
+ ret.operands.add(*resultTypeOperand);
+ resultTypeOperand.reset();
+ continue;
+ }
+
+ // Insert the LHS result operand
+ if(ret.operands.getCount() == opInfo->resultIdIndex && resultOperand)
+ {
+ ret.operands.add(*resultOperand);
+ resultOperand.reset();
+ continue;
+ }
+
if(ret.operands.getCount() == opInfo->maxOperandCount)
{
parser->diagnose(
@@ -6423,14 +6442,6 @@ namespace Slang
);
}
- // Insert the LHS result-type operand
- if(ret.operands.getCount() == opInfo->resultTypeIndex && resultTypeOperand)
- ret.operands.add(*resultTypeOperand);
-
- // Insert the LHS result operand
- if(ret.operands.getCount() == opInfo->resultIdIndex && resultOperand)
- ret.operands.add(*resultOperand);
-
if(auto operand = parseSPIRVAsmOperand(parser))
{
while(AdvanceIf(parser, TokenType::OpBitOr))