Remove support for the -no-checking flag (#392)

* Remove support for the -no-checking flag

Fixes #381
Fixes #383
Work on #382

- No longer expose flag through API (`SLANG_COMPILE_FLAG_NO_CHECKING`) and command-line (`-no-checking`) options

- Remove all logic in `check.cpp` that was withholding diagnostics (including errors) when the no-checking mode was enabled

- Remove `HiddenImplicitCastExpr`, which was only created to support no-checking mode (it represented an implicit cast that our checking through was needed, but couldn't emit because it might be wrong)

- Remove logic for storing function bodies as raw token lists when checking is turned off. I'm leaving in the `UnparsedStmt` AST node in case we ever need/want to lazily parse and check function bodies down the line.

- Remove a few of the code-generation paths we had to contend with, but keep the comment about them in place.

- Remove GLSL-based tests that can't meaningfully work with the new approach.

- Fix other tests that used a GLSL baseline so that their GLSL compiles with `-pass-through glslang` instead of invoking `slang` with the `-no-checking` flag.

- Remove tests that were explicitly added to test the "rewriter + IR" path, since that is no longer supported.

There is more cleanup that can be done here, now that we know that AST-based rewrite and IR will never co-exist, but it is probably easier to deal with that as part of removing the AST-based rewrite path.

We've lost some test coverage here, but actually not too much if we consider that we are dropping GLSL input anyway.

* Fixup: test runner was mis-counting ignored tests

* Fixup: turn on dumping on test failure under Travis

* Fixup: enable extensions in Linux build of glslang

1 files changed, 0 insertions, 12 deletions

diff --git a/source/slang/slang.cpp b/source/slang/slang.cpp
index 0ba3e790c..90a9a3aef 100644
--- a/source/slang/slang.cpp
+++ b/source/slang/slang.cpp
@@ -267,11 +267,6 @@ void CompileRequest::generateIR()
     // in isolation.
     for( auto& translationUnit : translationUnits )
     {
-        // Also skip IR generation if semantic checking is turned off
-        // for a given translation unit.
-        if(translationUnit->compileFlags & SLANG_COMPILE_FLAG_NO_CHECKING)
-            continue;
-
         translationUnit->irModule = generateIRForTranslationUnit(translationUnit);
     }
 }
@@ -309,13 +304,6 @@ int CompileRequest::executeActionsInner()
     for (auto& translationUnit : translationUnits)
     {
         translationUnit->compileFlags |= compileFlags;
-
-        // However, the "no checking" flag shouldn't be applied to
-        // any translation unit that is native Slang code.
-        if (translationUnit->sourceLanguage == SourceLanguage::Slang)
-        {
-            translationUnit->compileFlags &= ~SLANG_COMPILE_FLAG_NO_CHECKING;
-        }
     }
 
     // If no code-generation target was specified, then try to infer one from the source language,