Language Server improvements. (#2269)

* Language Server improvements.
- Improve parser robustness around `attribute_syntax`.
- Exclude instance members in a static query.
- Coloring accessors
- Improved signature help cursor range check.

* Add expected test result.

* Language server: support configuring predefined macros.

* Fix constructor highlighting.

* Improving performance by supporting incremental text change notifications.

* Fix UTF16 positions and highlighting of constructor calls.

* Add completion suggestions for HLSL semantics.

* Fix tests.

* Fix: don't skip static variables in a static query.

* Include literal init expr value in hover text.

* Fix scenarios where completion failed to trigger.

* Fixing language server protocol field initializations.

Co-authored-by: Yong He <yhe@nvidia.com>

1 files changed, 2 insertions, 2 deletions

diff --git a/source/slang/slang-serialize-factory.cpp b/source/slang/slang-serialize-factory.cpp
index a6b7e0ba8..351742e60 100644
--- a/source/slang/slang-serialize-factory.cpp
+++ b/source/slang/slang-serialize-factory.cpp
@@ -75,14 +75,12 @@ SerialIndex ModuleSerialFilter::writePointer(SerialWriter* writer, const NodeBas
     if (Decl* decl = as<Decl>(ptr))
     {
         ModuleDecl* moduleDecl = findModuleForDecl(decl);
-        SLANG_ASSERT(moduleDecl);
         if (moduleDecl && moduleDecl != m_moduleDecl)
         {
             ASTBuilder* astBuilder = m_moduleDecl->module->getASTBuilder();
 
             // It's a reference to a declaration in another module, so first get the symbol name. 
             String mangledName = getMangledName(astBuilder, decl);
-
             // Add as an import symbol
             return writer->addImportSymbol(mangledName);
         }
@@ -110,6 +108,8 @@ SerialIndex ModuleSerialFilter::writePointer(SerialWriter* writer, const NodeBas
     //
     // For now we just ignore all stmts
 
+    // TODO(yong): We should by default serialize everything. The logic to skip bodies need to be
+    // behind a option flag.
     if (Stmt* stmt = as<Stmt>(ptr))
     {
         //