Defer `IRCastStorageToLogicalDeref` in lowerBufferElementType pass. (#8668)

Fix a regression on metal test.

In `lowerBufferElementTypeToStorageType` pass, not only we want to defer
an argument that is `CastStorageToLogical` to the callee, but also apply
the same defer logic to `CastStorageToLogicalDeref` as well.

Because `CastStorageToLogicalDeref` will appear as argumnet if
`lowerBufferElementTypeToStorageType` is run before we apply the
`in->borrow` transformation pass, which is the case for metal parameter
block legalization.

1 files changed, 4 insertions, 6 deletions

diff --git a/source/slang/slang-ir.cpp b/source/slang/slang-ir.cpp
index ebaebcc8a..ba8864684 100644
--- a/source/slang/slang-ir.cpp
+++ b/source/slang/slang-ir.cpp
@@ -6187,14 +6187,12 @@ IRInst* IRBuilder::emitCastStorageToLogical(IRType* type, IRInst* val, IRInst* b
     return (IRCastStorageToLogical*)emitIntrinsicInst(type, kIROp_CastStorageToLogical, 2, args);
 }
 
-IRCastStorageToLogicalDeref* IRBuilder::emitCastStorageToLogicalDeref(
-    IRType* type,
-    IRInst* val,
-    IRInst* bufferType)
+IRInst* IRBuilder::emitCastStorageToLogicalDeref(IRType* type, IRInst* val, IRInst* bufferType)
 {
     IRInst* args[] = {val, bufferType};
-    return (IRCastStorageToLogicalDeref*)
-        emitIntrinsicInst(type, kIROp_CastStorageToLogicalDeref, 2, args);
+    if (type == tryGetPointedToType(this, val->getDataType()))
+        return emitLoad(type, val);
+    return emitIntrinsicInst(type, kIROp_CastStorageToLogicalDeref, 2, args);
 }
 
 IRGlobalConstant* IRBuilder::emitGlobalConstant(IRType* type)