diff options
| author | Tim Foley <tfoleyNV@users.noreply.github.com> | 2021-03-26 10:53:58 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-03-26 10:53:58 -0700 |
| commit | 129faf8c4af4a57b7f1c71749f45b31aebfab038 (patch) | |
| tree | 8ce3f618abf76d9144e28ac5860e425866cb866a /source/slang/slang-ir.cpp | |
| parent | abb020b15c4f1057657e5f8f63c02b15615bf6ec (diff) | |
Append proper suffixes to 16-bit literals for GLSL (#1767)
* Append proper suffixes to 16-bit literals for GLSL
The GLSL output path wasn't putting suffixes on literals of 16-bit types, and that was leading to compilation errors in downstream `glslang`. This change adds the suffixes defined by `GL_EXT_shader_explicit_arithmetic_types`.
This change also wraps up 8-bit literals so that they are emitted as, e.g., `int8_t(1)` instead of just `1`, to make sure we don't have implicit conversions in the output GLSL that weren't implicit in the Slang IR. We similarly wrap floating-point special values like infinities in their desired types when the type is `float` (e.g., `double(1.0 / 0.0)` for a double-precision infinity).
Note: Standad IEEE 754 half-precision doesn't provide an encoding for infinite or not-a-number values, so it might be considered an error if we emit `half(1.0 / 0.0)` but there really isn't a significantly better alternative for us to emit.
* fixup
Diffstat (limited to 'source/slang/slang-ir.cpp')
| -rw-r--r-- | source/slang/slang-ir.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/source/slang/slang-ir.cpp b/source/slang/slang-ir.cpp index 945cf488f..a983188b7 100644 --- a/source/slang/slang-ir.cpp +++ b/source/slang/slang-ir.cpp @@ -4945,10 +4945,14 @@ namespace Slang { case kIROp_IntLit: dump(context, irConst->value.intVal); + dump(context, " : "); + dumpType(context, irConst->getFullType()); return; case kIROp_FloatLit: dump(context, irConst->value.floatVal); + dump(context, " : "); + dumpType(context, irConst->getFullType()); return; case kIROp_BoolLit: |