diff options
| author | Ellie Hermaszewska <ellieh@nvidia.com> | 2023-08-08 06:01:02 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-08-07 15:01:02 -0700 |
| commit | 10b2038a8e71eb4a0e41cff38bc71e36dc0003aa (patch) | |
| tree | 54820b38e8c124ad581651c697a6264a81c2b7d0 /source/slang/slang-ir-spirv-snippet.cpp | |
| parent | 9eb6a84285c1597d723be13924a7ad2991cf717f (diff) | |
Diagnostic improvements for direct spirv (#3053)
* Fail on an unhandled spv operand
* Diagnose on emitting a function with no definition or intrinsic
* clearer error message
* Add assert
* Add assert
* remove unused assert
* Disagnostic on snippet parsing failure
* Mention unimplemented instruction in error message
* mention unhandled local instruction for spirv in error message
* Allow specifying dump options in dumpIRToString
---------
Co-authored-by: Yong He <yonghe@outlook.com>
Diffstat (limited to 'source/slang/slang-ir-spirv-snippet.cpp')
| -rw-r--r-- | source/slang/slang-ir-spirv-snippet.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/source/slang/slang-ir-spirv-snippet.cpp b/source/slang/slang-ir-spirv-snippet.cpp index 81e4d0bff..a263ad7f7 100644 --- a/source/slang/slang-ir-spirv-snippet.cpp +++ b/source/slang/slang-ir-spirv-snippet.cpp @@ -288,7 +288,7 @@ RefPtr<SpvSnippet> SpvSnippet::parse(UnownedStringSlice definition) } else { - SLANG_ASSERT(!"Invalid SPV ASM operand."); + SLANG_UNEXPECTED(("Invalid SPV ASM operand: \"" + identifier + "\"").getBuffer()); } } break; @@ -302,7 +302,7 @@ RefPtr<SpvSnippet> SpvSnippet::parse(UnownedStringSlice definition) } catch (const Slang::Misc::TextFormatException&) { - SLANG_ASSERT(!"Invalid ASM format."); + return nullptr; } return snippet; } |