SPIR-V WIP (#3064)

* Add type layout for structured buffer

* Default to generating spirv directly

* vk test for compute simple

* Add spirv-dis as a downstream compiler

* Emit Array types in SPIR-V

* makevector for spirv

* Dump whole spirv module on validation failure

* register array types

todo, use emitTypeInst

* Neater formatting for unhandled inst printing

* break out emitCompositeConstruct

* Correct array type generation

* neaten

* Allow getElement for vector

* Remove unused

* Allow predicating target intrinsics on types

* Consider functions with intrinsics to have definitions

We need to specialize these if they are predicated on types

* Correct array type generation

* makeArray for spir-v

* replace getElement with getElementPtr for spirv

* Correct translation of field access for spirv

* Push layouts to types for spirv

* Spirv intrinsics * operator now makes a pointer

* Add structured buffer of struct test

* Preserve type layout in spirv structured buffer legalization

* neaten

* makeVectorFromScalar for SPIRV

* placeholder for layouts on param groups

* More type safe spirv op construction

* Know that constants and types only go in one section

* Remove emitTypeInst

* Add todo for spirv sampling

* Add links to spirv documentation on emit functions

* OpTypeImage support for SPIR-V

* Add simpler texture test for spirv

* s/spirv_direct/spirv/g

* Allow several string literals in target_intrinsic

* Handle global params without a var layour for SPIR-V

For example groupshared vars

* uint spirv asm type

* Add todo for isDefinition

It is currently too broad

* Some atomic op spirv intrinsics

* Strip ConstantBuffer wrappers for spirv

* Add todo for matrix annotations

* Do not associate decorations insts with spirv counterparts

* Correct entry point parameter generation

* Spelling

* Assert that fieldAddress is returning a pointer

* Add error for existential type layout getting to spir-v emit

* Add IRTupleTypeLayout

Unused so far

* Allow getElementPtr to work with vectors

* Correct target name in test

* Hide default spirv direct behind a premake option --default-spirv-direct=true

* Do not insert space at start of intrinsic def

* Correct asm rendering in tests

* remove redundant option

* Emit directly from direct test

* Add source language options for spirv-dis

* Add comments to spirv dis

* Add dead debug print for before spirv module

* Correct asm rendering in tests

* s/spirv_direct/spirv/g

* Only specialize intrinsic functions with predicates

* regenerate vs projects

* squash warnings

* squash warnings

* remove duplication

* Silence warnings from msvc

* squash warnings

* Overload for zero sized array

* More msvc warnings

* warnings

* Add spirv-tools to path for tests

* Do not be specific about dxc version for diag test

* Normalize line endings from spirv-dis

* Correct filecheck matches

* Temporarily disable two spirv tests

Failing on CI, undebuggable hang :/

* Do not emit storage class more than once for spirv snippet

* Do not pass spir-v to spirv-dis by stdin

* Do not get spirv-dis output via stream, use file

* normalize file endings in spirv-dis output

1 files changed, 24 insertions, 8 deletions

diff --git a/source/slang/slang-ir-specialize.cpp b/source/slang/slang-ir-specialize.cpp
index f1de6e408..83e2cad70 100644
--- a/source/slang/slang-ir-specialize.cpp
+++ b/source/slang/slang-ir-specialize.cpp
@@ -288,17 +288,10 @@ struct SpecializationContext
         IRGeneric* g = generic;
         for (;;)
         {
-            // We can't specialize a generic if it is marked as
-            // being imported from an external module (in which
-            // case its definition is not available to us).
-            //
-            if (!isDefinition(g))
-                return false;
-
             // Given the generic `g`, we will find the value
             // it appears to return in its body.
             //
-            auto val = findGenericReturnVal(g);
+            const auto val = findGenericReturnVal(g);
             if (!val)
                 return false;
 
@@ -311,6 +304,29 @@ struct SpecializationContext
                 continue;
             }
 
+            // HACK: there are conflicting features in our target intrinsic decorations
+            // Some reference generic parameter with the `$G0` syntax (the
+            // first generic parameter) while other have a predicate
+            // `boolean(T)` where the T is resolved properly in IR lowering. We
+            // need to specialize the latter and not the former.
+            //
+            // The solution is to remove the `$G` syntax and replace that with
+            // resolved types too.
+            bool intrinsicNeedsSpecialization = false;
+            for(const auto dec : val->getDecorations())
+            {
+                // TODO: We should probably take into account our target to see if the intrinsic applies
+                if(const auto intrinsicDec = as<IRTargetIntrinsicDecoration>(dec))
+                    intrinsicNeedsSpecialization = intrinsicNeedsSpecialization || intrinsicDec->hasPredicate();
+            }
+
+            // We can't specialize a generic if it is marked as
+            // being imported from an external module (in which
+            // case its definition is not available to us).
+            //
+            if (!isDefinition(g) && !intrinsicNeedsSpecialization)
+                return false;
+
             // We should never specialize intrinsic types.
             //
             // TODO: This logic assumes that having *any* target