summaryrefslogtreecommitdiff
path: root/source/slang/slang-ir-specialize-address-space.cpp
diff options
context:
space:
mode:
authorArielG-NV <159081215+ArielG-NV@users.noreply.github.com>2025-08-29 15:52:34 -0700
committerGitHub <noreply@github.com>2025-08-29 22:52:34 +0000
commit7758625d3fea67e55e98e7e4103d56c9918365be (patch)
tree2ed40aeb4d16262866e5540dad1a519951b5f772 /source/slang/slang-ir-specialize-address-space.cpp
parent450ef7934c1adfdf4a3a3c72967de3c5798a020d (diff)
[CBP] Pointer frontend changes + groupshared pointer support (#7848)
Resolves #7628 Resolves: #8197 Primary Goals: 1. Add `Access` to pointer 2. AddressSpace::GroupShared support for pointers (SPIR-V) 3. Add `__getAddress()` to replace `&` * `&` is not updated to `require(cpu)` since slangpy uses `&`. This means we must: (1) merge PR; (2) replace `&` with `__getAddress()`; (3) add `require(cpu)` to `&` Changes: * Added to `Ptr` the `Access` generic argument & logic (for `Access::Read`). * Moved the generic argument `AddressSpace` from `Ptr` to the end of the type. * Added pointer casting support between any `Ptr` as long as the `AddressSpace` is the same * Disallow globallycoherent T* and coherent T* * Disallow const T*, T const*, and const T* * Fixed .natvis display of `ConstantValue` `ValOperandNode` * Support generic resolution of type-casted integers * Added `VariablePointer` emitting for spirv + other minor logic needed for groupshared pointers Breaking Changes: * Anyone using the `AddressSpace` of `Ptr` will now have to account for the `Access` argument * we disallow various syntax paired with `Ptr` and `T*` --------- Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com>
Diffstat (limited to 'source/slang/slang-ir-specialize-address-space.cpp')
-rw-r--r--source/slang/slang-ir-specialize-address-space.cpp15
1 files changed, 11 insertions, 4 deletions
diff --git a/source/slang/slang-ir-specialize-address-space.cpp b/source/slang/slang-ir-specialize-address-space.cpp
index 2bc1de775..29f1ec516 100644
--- a/source/slang/slang-ir-specialize-address-space.cpp
+++ b/source/slang/slang-ir-specialize-address-space.cpp
@@ -103,8 +103,11 @@ struct AddressSpaceContext : public AddressSpaceSpecializationContext
if (ptrType)
{
auto paramAddrSpace = key.getArgAddrSpaces()[paramIndex];
- auto newParamType =
- builder.getPtrType(ptrType->getOp(), ptrType->getValueType(), paramAddrSpace);
+ auto newParamType = builder.getPtrType(
+ ptrType->getOp(),
+ ptrType->getValueType(),
+ ptrType->getAccessQualifier(),
+ paramAddrSpace);
param->setFullType(newParamType);
mapInstToAddrSpace[param] = paramAddrSpace;
}
@@ -310,6 +313,7 @@ struct AddressSpaceContext : public AddressSpaceSpecializationContext
auto newResultType = builder.getPtrType(
ptrResultType->getOp(),
ptrResultType->getValueType(),
+ ptrResultType->getAccessQualifier(),
addrSpace);
fixUpFuncType(func, newResultType);
retValAddrSpaceChanged = true;
@@ -349,8 +353,11 @@ struct AddressSpaceContext : public AddressSpaceSpecializationContext
if (ptrType->getAddressSpace() != addrSpace)
{
IRBuilder builder(inst);
- auto newType =
- builder.getPtrType(ptrType->getOp(), ptrType->getValueType(), addrSpace);
+ auto newType = builder.getPtrType(
+ ptrType->getOp(),
+ ptrType->getValueType(),
+ ptrType->getAccessQualifier(),
+ addrSpace);
setDataType(inst, newType);
}
}